gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
28,505 Commits 9 Branches 0 Tags
96bed09af63edbd1baf1a1b96f81d4e8e6a6cb2d
Commit Graph

315 Commits

Author SHA1 Message Date
chandan270
96bed09af6 fix: remove image from challenge (#43303) 2021-08-25 22:02:09 +02:00
srijit2002
ab3e12935d fix(curriculum):Incorrect answer passes test for Set the font-size for Multiple Heading Elements challenge. (#43297) 2021-08-25 20:16:49 +02:00
MChiancone
1745411c24 fix(curriculum): add sentence to instructions for clarity (#43227) 2021-08-18 17:17:50 +02:00
Jay Huang
e71b1f3dbf fix(curriculum): Removed URL for wrong video solution (#43210) 2021-08-18 16:35:57 +05:30
Tom
8b2a4cbab9 fix(curriculum): grid area template lesson (#43059) 
* fix(curriculum): grid area template lesson

* fix: remove next step mention and fix hint

* fix: rework to make solution line up with seed of next lesson

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/divide-the-grid-into-an-area-template.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
 2021-08-06 06:52:00 +02:00
Nicholas Carrigan (he/him)
8535c23b08 fix: address crowdin issues (#43021) 2021-07-26 19:43:15 +01:00
Nicholas Carrigan (he/him)
8900fe0b8e feat: CSS Cafe Menu (#41797) 
* fix: general bugs

- Ensure editable region at end of code-block is followed by a blank
line.
- Remove apparent duplicate step.
- Address spelling issues.

* feat: some tests

* feat: tests 6-20

Add tests for steps 6-20.

* feat: tests 21-30

Add tests for steps 21 through 30.

* feat: tests 31-40

Add tests for steps 31 through 40.

* feat: tests 41-50

Add tests for steps 41 through 50.

* feat: tests 51-60

Add tests for steps 51 through 60.

* feat: tests 61-70

Add tests for steps 61 through 70.

* feat: tests 71-80

Add tests for steps 71 through 80.

* feat: steps 81-92

Add tests for steps 81 through 92.

* feat: align dashed names

Align the dashed names with the titles and file names.

* fix: apply gikf's suggestions

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: manual review suggestions

Apply gikf's other suggestions.

* feat: more thorough testing

When a test asserts that a camper adds a new element relative to
an existing element, also test that the existing element is not
malformed.

* feat: optional semi colons

Make EOL semi-colons optional in the CSS. If they're missing and the
CSS doesn't render correctly, other tests will catch that. If they
are on the last property of the ruleset, they technically aren't
required so we shouldn't require them?

* chore: apply review suggestions

Apply review suggestions from gikf

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* chore: apply suggestions from code review

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* feat: review suggestions

Apply Ahmad's review suggestions.

* chore: additional suggestions

Manual application of Ahmad's review suggestions.

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* chore: apply shaun's review suggestions

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* feat: add clarification

Add a bit of text clarifying the file switch in the editor.

* chore: replace URLs

Replace the tinyurls with our self-hosted CDN images.

* feat: new CSS tests

Re-write CSS tests with new parser.

* fix: grammar

Apply Shaun's grammar reviews.

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: optional chaining

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply reviews manually

* chore: getStyle update

Replace getStyleDeclaration with getStyle.

* fix: resolve test issue

* chore: remove jQuery :(

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* chore: apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fiux: Update curriculum/challenges/english/01-responsive-web-design/basic-css-cafe-menu/part-073.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-07-21 14:03:09 -05:00
Tom
8e28785913 fix(curriculum): remove outdated video (#42945) 2021-07-20 18:07:14 +02:00
Shaun Hamilton
ff20199e63 feat(curriculum): add tests to css variables skyline (#42067) 
* add(tests): parts 1-2

* refactor for multi-file editor, and add temp css tests

* re-re-rebasing

* add link to subsequent challenges

* add test strings to 007-015

* add final tests 001-016

* fix 005-007, add 017-022 tests and test strings

* add: tests 021-030, and formatting

* add: 031-034 tests

* tests: add 035-046

* fix: test in 021

* tests: add 047-050

* format: 009, 051-118 remove css whitespace

* tests: add 051-078

* tests: add 079-105

* tests: add 104-118

* fix: empty -> isEmpty, and include -> match

* fix: correct editable region

* fix: formatting and spelling

* fix: test logic, and add TODO for whitespace

* fix: add final part solution 🤦‍♂️

* fix typo in part-006

* remove whitespace in prep

* getStyleDeclaration -> getStyle

* remove editable region from solution 🤦‍♂️

* fix: correct tests to fail on initial

* fix: add missing regex

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

* fix: correct tests

* remove commas and stuff 🤷‍♂️

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* uppercaserise doctype

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add "the"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* remove half-colon

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* use more boring form of the word "shoudl"

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* add suggestions to tests

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-015.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-016.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-022.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-093.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-098.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-101.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-023.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-024.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-026.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-035.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-058.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-064.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-076.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-070.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-079.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-085.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-086.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-087.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-090.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-019.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-074.md

* Update curriculum/challenges/english/01-responsive-web-design/css-variables-skyline/part-078.md

* fix: the few commits I couldn't add on github

* fix: lesson 41

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-07-15 22:46:40 -05:00
Lorem Ispum
28efec9e63 fix: recognize background-image as correct (#42738) (#42745) 
* fix: recognize background-image as correct (#42738)

The page mentioned in #42738 before would not accept background-image and background, now it should.

* fix: CI build error

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
 2021-07-05 12:28:49 +02:00
Devesh Rane
dba157e7c0 Add a period at the end of an ul tag (#42483) 2021-06-15 20:44:36 +05:30
Stephan Düsterhöft
d6491a9902 fix(curriculum): Period added to the end of the sentence. (#42480) 
Dot added to the end of the sentence.
 2021-06-14 20:44:23 +05:30
Shaun Hamilton
35b18829d1 fix(curriculum): use mediaText for CSSHelp (#42393) 
* fix(curriculum): use mediaText in CSSHelp

prevent selection of style elements with class or media attributes
this should avoid picking up some browser extensions
 2021-06-07 23:33:58 +02:00
Seth Falco
dfe80470c6 fix: require a link element in html (#42336) 
* fix: require a link element in html

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-06-02 22:38:21 +02:00
impirios
f7ca9796c1 Update specify-how-fonts-should-degrade.md (#42335) 
Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif".
 2021-06-02 22:28:57 +04:00
Shaun Hamilton
d5cc9ba259 feat(dev): add css helper function (#42148) 
* feat(dev): add css helper function

* add media declaration methods

* use a selector to grab styles

* add CSSHelp class with annoying TS warnings (no-verify)

* replace indexing with getPropertyValue

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* connect CSSHelp to helpers, clean up types

* fix: return extended object, not modify prototype

* fix: unnecessary assertion error

* add tests with fixtures

* add afterAll document clean-up

* 'fix' tests

* undo jest transform config

* remove erroneous comments and logs

* reafactor: use existing types and narrow types

* refactor test descriptions

* rename files to appease Mrugesh 😄

* remove probably unnecessary document clean

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-05-25 07:34:55 -07:00
Seth Falco
4d024f3e4b fix(curriculum): css and html test issues (#42045) 
* fix: css and html issues

* fix: issues with css test

* fix: allow spaces in solution css

* fix: css tests for use-rgb-to-mix-colors
 2021-05-21 12:18:42 +01:00
Sem Bauke
607b1c3dbf fix(curriculum): look for possible www link in regex (#41955) 
* fix(curriculum): look for possible www. link in regex

* Add suggestions from Nick

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
 2021-05-06 10:06:33 +05:30
sjc5
a0463d2c99 fix: insert missing forward-slash in instructions (#41934) 
inserted forward-slash in closing 'sup' tag in instructions section
 2021-04-28 08:07:43 +02:00
Tom
093325abdf fix(curriculum): tabindex order lesson (#41901) 
Co-authored-by: Sem Bauke <46919888+Sembauke@users.noreply.github.com>
 2021-04-27 00:55:28 +05:30
EboranBokaj
e45689d495 fix(curriculum): HTML-challenges: links are inconsistent. (#41900) 
Co-authored-by: Ilenia <nethleen@gmail.com>
 2021-04-26 22:34:53 +05:30
Tom
6be76738b0 fix(curriculum): import a google font lesson regex test (#41907) 2021-04-24 12:43:55 +02:00
GDAD3
3fbe1ebc05 fix(curriculum): remove stale video from nest anchor element (#41914) 2021-04-24 02:47:35 +07:00
Tom
a329eec0a8 fix(curriculum): sanitize css comments on typography lesson (#41902) 2021-04-23 16:24:50 +02:00
Ritesh Arora
ec761dbdfa fix(curriculum): add target in challeges link (#41876) 2021-04-22 11:34:23 +07:00
Glitchy-Tozier
dbdc704271 fix(curriculum): give better instructions on alignment p-tags (#41859) 
* Improve instructions

* Remove unneccessary line break

* Move empty line
 2021-04-19 19:42:59 +02:00
Evgeny Klimenchenko
9057750727 fix(curriculum): Fix a type in line -> inline in basic css challenge (#41847) 2021-04-18 11:54:17 +02:00
Jonathan
ca3d5d51d6 fix: wrong text in standardize times challenge (#41842) 2021-04-17 06:19:52 +02:00
Sem Bauke
d4aef30ea7 fix(curriculum): regex compatibility issue for Safari (#41725) 
* fix(curriculum) regex compatibility issue for Safari

* fix: escape the dot parameter in regex

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-04-09 06:39:57 +02:00
Nicholas Carrigan (he/him)
a962d6afd4 fix(curriculum): cat photo app (#41768) 
Fix a couple of bugs I encountered when running through this
course.
 2021-04-08 13:37:18 +05:30
Hassaan Pasha
d51460dba8 fix (curriculum): added top level label-input pair to challenge (#41717) 
* fix (curriculum): added top level label-input pair to challenge

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
 2021-04-05 08:41:31 +02:00
Sem Bauke
87c9c799c6 fix(curriculum): Regex fix for Create a Variable for a Specific Area (#41501) 2021-03-29 17:09:52 +05:30
Randell Dawson
18ac058840 fix(curriculum): Improve wording of test text (#41606) 
Co-authored-by: Ricardo Passos <55499252+dizz-y@users.noreply.github.com>
 2021-03-26 13:01:20 -05:00
Sem Bauke
b064991667 fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design (#41519) 
* fix(curriculum) replace single-line block with multi-line blocks

* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
 2021-03-18 17:24:09 -06:00
Randell Dawson
d2f4b70ea6 fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
Randell Dawson
c198d508be fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge (#41456) 2021-03-12 10:09:22 -07:00
Randell Dawson
33bd4fb2c4 fix(learn): Change Codepen template link (#41440) 2021-03-12 10:41:48 +05:30
pandacoder7
53d372c298 fix: update challenge for crowdin in anchor page (#41450) 2021-03-11 13:35:34 -07:00
Sem Bauke
5b760e50a3 fix(curriculum) Improved readability and grammar (#41340) 
* fix(curriculum) Improved readability and grammar

* fix missing tags and grammar

* fix(curriculum) changes to grammar

* fix(curriculum) grammar fixes

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/make-elements-only-visible-to-a-screen-reader-by-using-custom-css.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix(curriculum) Grammar fix

* chore: apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
 2021-03-10 09:00:03 -08:00
Emer Conghaile
18068cdeaa fix: remove forward slash from <source> tag (#41422) 
The forward slash at the end of the <source> tag in the example is removed, as this is more common.
 2021-03-09 16:20:22 +00:00
Ricardo Passos
ae79525493 fix(learn): added a missing period and removed single quotes (#41377) 
* Added missing period

On line 24, just before "Note that in your CSS..." a period was missing.

* Removed single quotes and added a missing period

On line 24, just before "Note that in your CSS..." there is a missing period. 
On line 30, the text "red-text" within a code tag is enclosed in single quotes.
 2021-03-05 07:16:30 -08:00
Sem Bauke
f328bdb93e fix(curriculum) fixes for grammar and missing articles (#41335) 
* fix(curriculum) fixes for grammar and missing articles

* Update curriculum/challenges/english/01-responsive-web-design/css-grid/add-gaps-faster-with-grid-gap.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-02 12:27:45 -07:00
Ilenia
051a010798 fix(learn): disallow www link from challenge (#41275) 
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
 2021-02-27 02:47:47 +05:30
Randell Dawson
f4bbe3f34c fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Ilenia
aa615763af fixed tests for link to external pages challenge (#41191) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-21 11:46:00 +05:30
Randell Dawson
167f93df76 fix(learn): Add inline code blocks to for i18n (#40921) 2021-02-05 14:16:19 +05:30
Nicholas Carrigan (he/him)
12658d33fc fix(i18n, learn): more crowdin fixes (#40905) 2021-02-04 13:34:44 +05:30
Keith
c21b2a9707 fix(learn): corrected typo (#40902) 
Fixed typo at the end of the 4th paragraph. Changed "Others options include:" to "Other options include:".
 2021-02-03 15:11:44 -08:00
Guilherme Dias Simões
ddf495c335 Fix 'wrap' and 'wrap-reverse' definitions. (#40766) 
The definitions for the options 'wrap' and 'wrap-reverse' were slightly wrong as can be seen by applying them to the challenge.
 2021-02-03 13:01:43 -06:00
Nicholas Carrigan (he/him)
b0bd3f5549 fix(learn): abstract comments from code (#40869) 2021-02-03 22:28:33 +05:30