Commit Graph

332 Commits

Author SHA1 Message Date
Jacob Bearden
020632962b fix image protocol 2016-03-16 20:32:12 -06:00
Rex Schrader
b5128336a4 Change nameXX properties to title XX properties 2016-03-11 21:00:06 -08:00
Eric Leung
fe0ca1e732 Fix javascript to JavaScript in Basic JavaScript 2016-03-10 00:09:18 -08:00
Vladimir Támara Patiño
3672a52edc Finishing reviewing of spanish translation by @jorgeruvalcaba.
Thanks for corrections to @justinian336
2016-03-08 21:58:27 -05:00
Randy Tolentino
b579d80dda Changed very last test for the Comparisons with the Logical And Operator challenge.
- the last test was a repeat, of testing the number 51 and expecting No
- changed the spec to test for 80, and should still return No
2016-03-02 09:54:21 -06:00
Eric Leung
30db3f0942 Remove unnecessary line break in Counting Cards 2016-02-21 13:23:53 -08:00
Logan Tegman
b1879d19b9 Merge pull request #7091 from jorgeruvalcaba/add/ES-translation-basic-javascript
Verify and update translation to spanish of basic javascript
2016-02-19 20:16:45 -08:00
Jorge Ruvalcaba
632a376145 Challenges of Basic Javascript translated. Closes #6496
Challenges of Javascript translated and corrected.

Some changes in challenges of Javascript.

Format nameEs and general corrections.
2016-02-18 18:18:06 -06:00
Jami Gibbs
a4465ae853 Fix grammar in the Golf Code challenge directions 2016-02-17 16:00:09 -06:00
Eric Leung
8287438d57 Clarify Counting Cards instructions & add tests
- Clarify instructions by changing table column "Value" to "Count Change"
- Add two more tests with mix of 7, 8, 9 and other card values
2016-02-16 07:31:41 -08:00
Logan Tegman
866b14b61a Merge pull request #6925 from erictleung/fix/further-clarify-dot-operator
Clarify instructions on saving object properties
2016-02-14 13:32:26 -08:00
Ankit Aggarwal
41e1c6a282 Improve test cases of Record Collection challenge 2016-02-12 19:15:28 +05:30
Eric Leung
e24abbdf29 Clarify instructions on saving object properties 2016-02-11 19:12:33 -08:00
Rex Schrader
5026ba7fde Migrate invalid Challenge IDs 2016-02-10 15:18:48 -08:00
Alister N. Mada
7ad4ef5b44 Fix test for Iterate Through An Array With For Loop 2016-02-10 06:29:11 +07:00
Joshua Henson
9a0bc20667 Clarify "Nest one Array..." challenge to include multiple arrays 2016-02-06 11:27:54 -08:00
Rex Schrader
b62f675802 Merge pull request #6729 from alistermada/fix/test-for-loop-challenge-too-strict
Fix test for Iterate Through an Array with a For Loop
2016-02-05 20:35:57 -08:00
Alister N. Mada
493b7f4f15 Make Iterate Through Array for loop test less strict 2016-02-05 14:21:49 +07:00
Mrugesh Mohapatra
0608c759e2 Fix Range Error : Maximum Call Stack Size Exceeded
This commit fixes the `capture` console.log, with an alternate logic
to resolve the objects with correct scope.

Refer the PR FreeCodeCamp/FreeCodeCamp#6681 discussion for details.
Tested locally.

Updated fix to resolve broken CI
2016-02-04 14:51:37 +05:30
Quincy Larson
23aa1db530 Merge pull request #6562 from SaintPeter/fix/restore-es-translations
Restore Prior Spanish Translations to basic-javascript.json
2016-02-02 00:16:39 -08:00
Mrugesh Mohapatra
509ae8a6c5 Add Instructions Clarification to Using Objects for Lookups
This commit adds clarification to the Instructions.
Tested locally.
2016-02-02 02:17:56 +05:30
BKinahan
a7869cf072 Changed 'will gives' to 'will give'
Corrected typo for challenge Generate Random Whole Numbers with Javascript, 'will gives' to 'will give'.
2016-02-01 11:24:19 +00:00
Eric Leung
cbcdb8df4f Clarify escape literal quotes instructions
- Change example quote to valid JavaScript
- Add example of what you will get if you print said example quote
- Place emphasis on "if" in the instructions so that it'll hopefully be clear
  you do not actually need to print it
2016-01-31 01:39:47 -08:00
Rex Schrader
ee2b7e5ef9 Merge pull request #6581 from raisedadead/fix/comparison-with-the-greater-than-or-equal-to-operator
Fix the test case for Comparison with operators
2016-01-30 11:35:53 -08:00
Rex Schrader
6292867132 Merge pull request #6583 from raisedadead/fix/undefined-is-not-explained
Add a hint to Return Early Pattern for Functions
2016-01-30 11:32:07 -08:00
Mrugesh Mohapatra
6761aa4aef Fix the test case for Comparison with operators
This commit fixes the test case with change to assert in one case,
and change to the test case message in another case.

I intentionally, changed the assert for one case and message for other

Tested locally.
2016-01-30 11:45:40 +05:30
Mrugesh Mohapatra
6af0f0f448 Add a hint to Return Early Pattern for Functions
This commit adds a hint as disccussed in the issue, to clarify,
the difference between `undefined` and `"undefined"`.

Tested locally.
2016-01-30 11:34:11 +05:30
Hallaathrad
7726989f9a Fix for "Multiple Identical Options in Switch Statements"
Corrects typo "ommitted".
Closes #6593
2016-01-29 22:58:29 -05:00
Rex Schrader
39b8ee0c97 Merge pull request #6567 from raisedadead/fix/introducing-javascript-object-notation-json
Fix the release year for Billy Joel - Piano Man
2016-01-29 09:26:52 -08:00
Mrugesh Mohapatra
2376c545ec Fix test case in Comparisons with the Logical And Operator
This fixes the test case to do the correct assert as per the message.

tested locally.
2016-01-29 13:55:59 +00:00
Mrugesh Mohapatra
74528cc98b Fix the release year for Billy Joel - Piano Man
This fixes the release year as mentioned in the issue.
Hope the fans will forgive us!

Tested locally.
closes #6561
2016-01-29 07:42:48 +00:00
SaintPeter
dac587cb67 Restore Prior Spanish Translations to basic-javascript.json
Tested Locally

Please review, @vtamara
2016-01-28 20:07:34 -08:00
Rex Schrader
495022aebe Merge pull request #6529 from robjloranger/fix/all-greaterthan-quotes
Fix for greater than + less than quotes
2016-01-28 10:20:48 -08:00
Alister N. Mada
ce38b2931e Fix test for Comparison with the Equality Operator 2016-01-28 11:15:52 +07:00
robjloranger
3a2fb76fa0 fixing regex asserts
Changed all regex test to accept option single/double quotes around digits in comparrisons.
Used ('|\")*

Mistakenly had strict comparisons changed, reverted those.

fixed typo

one last typo

how did i miss so many errors

last error i hope

..last .. one ..
2016-01-28 03:15:13 +00:00
Rex Schrader
f487270d23 Merge pull request #6467 from tahmid-ul/fix/improve-assignment-with-a-returned-value
Assignment with a Returned Value - Improved Challenge Seed
2016-01-27 10:58:27 -08:00
Rex Schrader
e4cf49807b Merge pull request #6455 from alistermada/fix/more-tests-basic-javascript
Add more tests for Basic JavaScript challenges
2016-01-27 10:55:59 -08:00
Tahmid ul karim
f2adce323e Improved Challenge Seed
Assignment with a Returned Value .
2016-01-26 21:36:55 +06:00
Eric Leung
c0dfcb1b39 Adds spaces between paragraphs
Tested locally. Closes #6374
2016-01-26 07:36:55 -08:00
Alister N. Mada
5a253e6027 Remove extra spaces from Basic Javascript challenge description 2016-01-26 17:24:21 +07:00
Alister N. Mada
5a1bbd158e Add more tests for Basic JavaScript challenges 2016-01-26 16:37:26 +07:00
Rex Schrader
e108861efa Merge pull request #6437 from raisedadead/fix/change-instruction-accesing-nested-objects-in-json
Fix the instruction text in the Accessing Nested objects challenge
2016-01-25 11:53:24 -08:00
Tahmid ul karim
3c9cf77f38 Removed double quotes
closes #5825
2016-01-25 21:19:59 +06:00
Mrugesh Mohapatra
8894ccd588 Fix the instruction text in the Accessing Nested objects challenge
This commit fixes the instruction text in the challenge to
`Use bracket notation for properties with a space in their name.`
from
`Only use object notation for properties with a space in their name.`
I have removed the extra `Only` on purpose for sake of grammar.

closes #6422
2016-01-25 12:13:50 +00:00
Arsen Melikyan
2c8952f9b3 Merge pull request #6415 from erictleung/fix/extra-spacing-in-editor
Remove unnecessary spaces in the editor
2016-01-25 11:11:25 +04:00
Arsen Melikyan
3a94ec2262 Merge pull request #6417 from erictleung/fix/add-open-new-tab-in-links
Added "target='_blank'" to links missing them
2016-01-25 11:09:56 +04:00
Eric Leung
2394fcc961 Added "target='_blank'" to links missing them 2016-01-24 12:46:30 -08:00
Eric Leung
d6250452db Remove extra word of 'use' in range challenge 2016-01-24 12:24:41 -08:00
Eric Leung
09085a04a9 Remove unnecessary spaces in the editor 2016-01-24 12:19:26 -08:00
Tahmid ul karim
dee07e7980 fixed an issue #6380 .... basic-javascript.json
added 'or' in between greater than equal to.
2016-01-23 01:43:22 +06:00