freeCodeCamp

gaspersic/freeCodeCamp

Fork 0

Commit Graph

Author	SHA1	Message	Date
Kristofer Koishigawa	5e53ebded9	fix(seed): Simplify Unique Titles Test (#17056 ) Originally the test would check for the index of a title in an array of unique challenge titles. However, the index of the title within the array isn't important for this test, so I simplified the code using @Bouncey's suggestion in PR #17035. Also changed grammar for the error that's thrown when a challenge title isn't a valid string. BREAKING CHANGE: None	2018-04-13 15:15:40 +01:00
Kristofer Koishigawa	5fa098ea0d	test(seed): Add Test for Unique Challenge Titles (#17035 ) Due to the recent problem with two challenges having the same title, I added a check for unique titles to the test suite so that hopefully won't happen again. Addresses a comment in issue #16906, which was recently closed. BREAKING CHANGE: None Closes #16906	2018-04-10 21:23:36 +01:00

Author

SHA1

Message

Date

Kristofer Koishigawa

5e53ebded9

fix(seed): Simplify Unique Titles Test (#17056 )

Originally the test would check for the index of a title in an array of
unique challenge titles. However, the index of the title within the
array isn't important for this test, so I simplified the code using
@Bouncey's suggestion in PR #17035.

Also changed grammar for the error that's thrown when a challenge
title isn't a valid string.

BREAKING CHANGE: None

2018-04-13 15:15:40 +01:00

Kristofer Koishigawa

5fa098ea0d

test(seed): Add Test for Unique Challenge Titles (#17035 )

Due to the recent problem with two challenges having the same title, I
added a check for unique titles to the test suite so that hopefully
won't happen again.

Addresses a comment in issue #16906, which was recently closed.

BREAKING CHANGE: None

Closes #16906

2018-04-10 21:23:36 +01:00

2 Commits