gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,358 Commits 9 Branches 0 Tags
9c35bf0bd1e1e127e724b698246ea5bd29486424
Commit Graph

151 Commits

Author SHA1 Message Date
Nicholas Carrigan (he/him)
7d83a6b65d fix(curriculum): verbiage (#41732) 
* fix(curriculum): verbiage

Modify the wording of the tests in this challenge to avoid having
two tests which sound the same.

* fix: Shaun's arrays have elements

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
 2021-04-03 23:00:15 +02:00
Sem Bauke
e75685f803 fix(curriculum): change tests to allow more solutions (#41703) 
* fix(curriculum) only allow  new object to be the second value in array

* fix(curriculum) remove direct array index notation

* Apply suggestions from Shaun

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
 2021-03-31 14:24:20 -07:00
Emer Conghaile
e5b4ae17a0 fix: Simplify wording to make more sense (#41586) 
* fix: Simplify wording to make more sense

I think that "count odd numbers backward by twos" instead of "count backward by twos by odd numbers" is easier to understand.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

I think that this variation sounds better than what I originally wrote.

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-25 22:18:51 +00:00
Randell Dawson
b5ed2619eb fix: replace inline code blocks (#41576) 2021-03-26 02:37:48 +05:30
Randell Dawson
e18c6955b0 fix(curriculum): Improve test to allow any valid function call for Write Reusable JavaScript with Functions challenge (#41538) 
* fix: improve test to allow function call anywhere

* fix: force user to put console.log in function
 2021-03-20 12:23:32 +00:00
Arjun Yadav
3f1cd6eb33 fixed the grammar of the description (#41531) 2021-03-19 06:55:21 -06:00
Kelvin Sánchez
35a8f55515 fix(learn): Remove unnecessary inline code tag in challenge (#41428) 
* remove unnecessary inline code tag

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-less-than-or-equal-to-operator.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* improve challenge wording

* improve challenge wording

* keep wording consistency

* keep wording consistency between similar challenges

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-10 10:16:03 -08:00
Nicholas Carrigan (he/him)
c5bcebc724 fix(learn): revert backslash change (#41382) 
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-09 10:13:27 -06:00
Nicholas Carrigan (he/him)
77730ae209 fix(learn): address translator comments (#41381) 
* fix(learn): address translator comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/quoting-strings-with-single-quotes.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-09 08:15:26 -06:00
Andrew Cen
65cc800689 fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Nicholas Carrigan (he/him)
7117919d36 chore(learn): audit javascript algorithms and data structures (#41092) 
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-03-02 17:12:12 -07:00
Randell Dawson
b11dd87047 fix: remove sentence not needed (#41235) 2021-02-23 11:21:58 -06:00
Randell Dawson
f4bbe3f34c fix(learn): Updated code blocks to help with translation on two challenges (#41217) 2021-02-22 11:21:59 +05:30
Alexander Heß
b12360d4a8 Removed the hint Fixes #41192 (#41215) 
* Removed the hint Fixes #41192

* Removed the blank line as suggested
 2021-02-21 13:36:14 -07:00
Kelvin Sánchez
f08174b5b1 fix(learn): Remove unnecessary inline code tag in challenge (#41177) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-19 09:44:50 +05:30
Kelvin Sánchez
fad168b465 fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161) 
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-18 08:45:12 -07:00
Kelvin Sánchez
2c1280af65 fix(learn): Improve the clarity on a challenge sentence (#41154) 
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-18 08:29:31 -07:00
Kelvin Sánchez
1fe1371b16 add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Kelvin Sánchez
b45406ec9d fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Nicholas Carrigan (he/him)
21c7abf584 fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Nicholas Carrigan (he/him)
18e821bcd3 fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
matias-miller
8a9f3319c6 fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478) 
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-01-21 08:44:10 -08:00
Nicholas Carrigan (he/him)
062b1cd424 fix: replace h tags (#40750) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-01-21 13:41:46 +05:30
Nicholas Carrigan (he/him)
8d8d25e9f2 fix(learn): address escaped backticks (#40717) 
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-01-20 19:01:00 -07:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683) 
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
 2021-01-12 19:31:00 -07:00
Ilenia
7de8549e02 fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465) 
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-12-16 08:07:47 -08:00
vbinithyanandamv
7c19c82076 [BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409) 
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams
0bd52f8bd1 Feat: add new Markdown parser (#39800) 
and change all the challenges to new `md` format.
 2020-11-27 10:02:05 -08:00
Ilenia
f294d9cacc fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
rajapandi_vijayakumar
e8b6a9e5dd fix(learn): add example declaration for clarity (#40207) 
Variable declaration is added which is used inside the switch case.
 2020-11-09 17:09:21 +00:00
Randell Dawson
895e6b8daf fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Oliver Eyton-Williams
a71150074d fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
dhanush1909
a32427c120 fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
Oliver Eyton-Williams
2b9e38a17b fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Mainak Debnath
362e8254f8 fix(learn): update test to allow negative arguments (#39701) 
* Updated the regex in test

* Changed regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Updated changes in regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-09-28 16:03:24 +01:00
Nicholas Carrigan
6ccd0d21a1 fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Gaurav Khairnar
a338d4b79d fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
Hassaan Pasha
80438cac3e feat(client, learn): add helper functions for common validation operations (#38605) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-09-17 19:38:01 +05:30
Randell Dawson
30c61b808b fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Aleksa S. Stevic
5cb609dc5c Changed "statement" to "expression" (#39564) 
The ternary operator doesn't allow statements, just expressions.
 2020-09-12 10:37:59 +02:00
Randell Dawson
c345bc9886 fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Siddharth Pathak
5418307936 fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Tom
b79a332984 fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00
Oliver Eyton-Williams
bd68b70f3d Feat: hide blocks not challenges (#39504) 
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
 2020-09-03 15:07:40 -07:00
skaparate
f97c847e29 fix(learn): formatting bug preventing tests to pass (#39045) 
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-09-03 12:34:12 +01:00
bhagerty
db15a44160 fix(learn): clarify instructions to remove confusion (#39479) 
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2020-09-02 18:41:59 +01:00
Beau Carnes
f334734e98 feat: split JS challenge into two (#39044) 
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-08-31 19:44:56 +01:00
anthony
20d397f719 remove MDN links from English challenges (#39337) 
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
 2020-07-31 15:19:49 +09:00
Bianca Zanardi
35f24c6085 Fix text inconsistency (#39203) 
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-07-09 16:18:11 +02:00
Nicholas Carrigan
2aee480c46 Remove example code from challenge seed (#39083) 
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2020-06-22 16:13:21 +05:30