114 Commits

Author SHA1 Message Date
Tom
9cd4b93601
fix(learn): getter setter instructions (#39512)
* Update use-getters-and-setters-to-control-access-to-an-object.english.md

* fix: revert changes, keep example

Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Josh Queen
23ca15241c
fix:(curriculum): Moved code tag to include new keyword (#38780)
* Moved code tag to include new keyword

The new keyword hasn't been explained in the curriculum yet, so have moved the <code> tag to include the new keyword to give a prompt that it needs to be used in the solution.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-arrow-functions-to-write-concise-anonymous-functions.english.md

Added comma.

Co-authored-by: Lasse Jørgensen <28780271+lasjorg@users.noreply.github.com>
2020-05-20 10:09:35 +02:00
Paul Gamble
54d59ffc37
Fix/curriculum en es6 complete a promise - modified test messages to be more clearer (#38836)
* Changed tests messages to indicate string

* minor tweak with wording of message

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-05-19 12:44:59 +02:00
Enock Kasaadha
06d97ac813
fix(curriculum/learn): moved the comment one line below. (#38422)
moved the comment ` //add code above this line` in the text editor of [this challenge](https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/es6/use--to-import-everything-from-a-file) one line below so that it makes meaning.
2020-03-26 20:01:58 -05:00
Randell Dawson
e0e6334628
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 3 of 4 (#38264)
* fix: remove example code from challenge seed

* fix: remove declaration from solution

* fix: added sum variable back in

* fix: reverted description back to original version

* fix: added examples to description section

* fix: added complete sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: corrected typo

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: reverted to original desc with formatted code

* fix: removed unnecessary code example from description section

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: failiing test on iterate through array with for loop

* fix: changed to Only change this line

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
Co-authored-by: moT01 <tmondloch01@gmail.com>
2020-03-25 16:07:13 +01:00
Randell Dawson
50f15886b8
fix(curriculum): Strip comments from user code for Use Destructuring Assignment to Extract Values from Objects challenge (#38213)
* fix: strip user code to improve tests

* fix: removed closing section tag messing up tests
2020-03-25 13:28:17 +01:00
Randell Dawson
9252f96566
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 4 of 4 (#38267)
* fix: consolidate comments


Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-03-08 15:46:28 +01:00
Tom
17a55c6e18
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258)
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-03-04 13:08:54 -06:00
Randell Dawson
6a7a7e6d7d
fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Josh Soref
004b99bf8f chore: fix typos in spelling (#38100)
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
2020-02-08 23:59:10 +05:30
Perrottarichard
bc470325d0 Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md (#38092)
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
2020-01-21 08:25:10 -06:00
ML
d824c77012 Move the comment on line 71 to its own line (#38036)
* Move the comment on line 71 to its own line

The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.

* Update line 71 comment per @manish-giri suggestion

Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
2020-01-15 08:17:34 +05:30
Randell Dawson
a70e15c0a7 fix: allow-space-in-destructuring-regex (#37997) 2020-01-07 17:22:15 +01:00
Randell Dawson
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761)
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
Waldo Luis Ribeiro
deb24f77b6 fix(curriculum): English editing (#37814)
* fix(curriculum): English editing

* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* Update use-class-syntax-to-define-a-constructor-function.english.md
2019-11-24 16:38:30 -05:00
Randell Dawson
dc1b59070e fix: use arrow function syntax (#37818) 2019-11-24 02:37:11 -05:00
Waldo Luis Ribeiro
0c22313760 fix(curriculum): English editing (#37815)
* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-23 18:37:36 -05:00
Waldo Luis Ribeiro
70f736fe07 fix(curriculum): English editing (#37816) 2019-11-23 17:28:56 -05:00
Louisa
2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
shrobbins
a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
Ent Wickler
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Lauren Van Sloun
4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
enrider
76bd5f4fc3 Issue #36564 update regex for spread operator (#36565)
* Issue #36564 update regex for spread operator

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-the-spread-operator-to-evaluate-arrays-in-place.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-08-06 14:56:48 -07:00
Randell Dawson
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
mrugesh
91df817cfe
fix(guide) add stubs, update spellings and prepare for move (#36531)
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)

* fix: corrected file path to match curriculum

* fix: renamed to newer challenge name

* fix: added solutions to articles from challenge files

* fix: added missing .english to file name

* fix: added missing title to guide article

* fix: correct solution for guide article

* fix: replaced stub with hint

* fix: added space in Hint headers

* fix: added solution to guide article

* fix: added solution to guide article

* test: replaced stub with hint and solution

* fix: add Problem number: to title

* fix: changed generatorexponential to correct name

* fix: renamed knight's tour to knights-tour

* fix: updated guide article
2019-07-30 00:25:58 +05:30
Randell Dawson
5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
Oliver Eyton-Williams
b8593326b0 fix: remove guide linting and fix failing challenges 2019-07-19 15:30:17 +05:30
Randell Dawson
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
moT01
9ce8bbb4c0 fix/add-suggested-grammar-and-punctuation 2019-07-12 22:44:23 +09:00
moT01
d3cf6f42dd fix/grammar+punctuation 2019-07-12 22:44:23 +09:00
moT01
fa365a7f77 fix/capitalization-in-title 2019-07-12 22:44:23 +09:00
moT01
832cbc91b1 fix/the-mess-I-made 2019-07-12 22:44:23 +09:00
moT01
da254743cd feat/new-lessons-on-js-promises 2019-07-12 22:44:23 +09:00
lasjorg
f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Tom
50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01
2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01
9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01
9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01
9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01
d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01
61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00