311 Commits

Author SHA1 Message Date
CharmedSatyr
9e9bc276aa fix(challenges): add comments to getter/setter instructions codeblock
ISSUES CLOSED: #92
2018-07-01 19:50:47 +09:00
Guy Even
66d84631ca fix(challenges): fixed RegEx for template literals javascript challenge
ISSUES CLOSED: #65
2018-06-30 19:31:01 +09:00
mrugesh mohapatra
1d3e0764fb fix(challenge): syntax error in sample code snippet 2018-06-30 06:55:40 +05:30
Rob Anthony
46fcf434cd fix(challenges): change comment to make it clearer (#72) 2018-06-30 01:03:16 +05:30
Guy Even
ff266972e5 fix(challenges): removed a test in basic javascript challenge (#76)
removed a test looking for timesFive call and it is not clear from the instrucitons to do so

ISSUES CLOSED: #73
2018-06-30 00:19:47 +05:30
Niraj Nandish
0c0702d6c0 fix(challenges): Typo errors (#39) 2018-06-29 23:47:58 +05:30
Matthew Smith
9fa5907da0 fix(challenges): update regular expression that fails (#56)
* fix(challenges): update regular expression that fails

Changes regular expression in testString to remove negative look behind that is not implemented
across all browsers.

ISSUES CLOSED: #55

* Fixed line spacing

It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR!

* Back to `prettier` formatting

Reverting back to pretty formatting from commit.
2018-06-29 23:47:58 +05:30
Guy Even
2375d0c98d fix(challenges): cherry pick pr 17664 & 17672 from main repo (#52) 2018-06-29 23:47:58 +05:30
Guy Even
2b034e267b fix(challenges): fixed telephone number validator project (#53)
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
2018-06-29 23:47:58 +05:30
Kristofer Koishigawa
4b1c5ebc7a fix(challenges): change test for template literals challenge (#37)
The original test was too rigid, and many users were forced to use one solution, usually map, to
complete the challenge. The test is changed here to allow for multiple solutions to the problem,
including the use of either single or double quotes when naming a class.

BREAKING CHANGE:
None
2018-06-29 23:47:58 +05:30
Thomas Lombart
cf9336a3b1 fix(challenges): Correct a regex in ES6 read-only challenge (#41)
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
2018-06-24 14:41:31 +01:00
John Kennedy
d4cf9deee6 fix: sample code in intro to currying
Corrected the code sample that didnt work
Amended uncurried example to better tie in with rest of code making the lesson more cohesive
2018-06-21 18:48:04 +05:30
Niraj Nandish
16ff132f44 fix: typo errors (#23)
* Typo errors

Unnecessary break

Grammatical error

* remove an unnecessary <br>
2018-06-21 18:48:04 +05:30
Michael Silverman
999c6af639 fix: changes text to bold in the JS Algo and DS (#20) 2018-06-21 18:48:04 +05:30
Ankit Tiwari
e1dfe8f43c fix: Remove an unnecessary line from basic javascript challenge (#19) 2018-06-21 18:48:04 +05:30
Tom
d31e0a3a24 fix: blockquote-formatting-in-challenges (#17590) 2018-06-19 17:53:24 +05:30
Kristofer Koishigawa
20fac4e2c3 revert: "test(challenges): Corrected expected average value" (#17568) 2018-06-14 03:30:04 +05:30
Vimal Raghubir
9e84a54d72 fix: rename incorrect variable name (#17538)
* fix: rename incorrect variable name

* Fix: Bad variable naming
2018-06-13 13:02:11 +05:30
Matthew Smith
ed5e02d7ae test(challenges): Corrected expected average value (#17562)
Modified 8.675 to 8.52 in three places for correct average value

BREAKING CHANGE: n/a

Closes #17561
2018-06-13 13:02:11 +05:30
Todd Bradshaw
8d57e1607f fixed line breaks in 'Prevent Object Mutation' challenge (#17547)
* fix(seed):line breaks in 'Prevent Object Mutation' challenge #17541

* Update es6.json
2018-06-13 13:02:11 +05:30
bogadodiegoh
c9f572d271 fix(seed): updated basic javascript URLs for hints (#17445)
* Updated json file with right url values

* Updated url links after review

* Updated another broken url link after review
2018-06-11 18:22:32 +05:30
Vimal Raghubir
0874eca77c fix: added new test and fixed incorrect variable (#17471)
* Added new test and fixed incorrect variable

* Fix: Incorrect sentences and descriptions

* Update es6.json
2018-06-11 18:22:32 +05:30
Rajat Kanti Nandi
2a3369aa6b Updated basic-javascript.json file for challenge Manipulate arrays with shift; issue: #17235 2018-05-25 19:28:17 +00:00
Stuart Taylor
4e645a5ff6 Package: Validate challenges on test (#17216)
This PR allows us to validate the schema during test.

It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
2018-05-22 18:13:14 +05:30
Stuart Taylor
ee66d84ccb feat(package): Initial Curriculum separation (#17174)
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30
Irina Brennen
746413bd68 fix(seed): Fixed test to fail if console.clear is still commented out (#17097)
Closes #16958
2018-05-03 18:31:42 +05:30
Nicholas Nadeau, P.Eng., AVS
a8efeb50d7 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Akkshay Lawrence
f9a63ee581 fix(challenges): Fixed typo in the challenge (#16991)
changed vowels to letters.

BREAKING CHANGE: none.

Closes #16979
2018-04-03 15:25:41 -04:00
Lovepreet Singh
fc87d71af3 fix(seed): Added missing text 'new tab' (#16978)
'new tab' was missing from description

Closes #16970
2018-04-03 11:42:04 -04:00
Alex Chaffee
52ca2b9ad6 feat(seed): reformat seed/challenges JSON via repack script 2018-04-03 19:53:44 +05:30
Stuart Taylor
b7930795d6 fix(seed): Fix schema violations 2018-04-03 19:52:01 +05:30
Stuart Taylor
197635ffe7 chore(seed): Normalise decsription field 2018-04-03 19:52:01 +05:30
Stuart Taylor
f1317f0b89 chore(seed): Remove depricated file 2018-04-03 19:52:01 +05:30
Stuart Taylor
3f4bffcfca fix(translations): Fix translation fields 2018-04-03 19:52:01 +05:30
Paul Rail
181949b2c7 fix(seed): Correct typos in es6.json (#16972) 2018-03-28 20:01:52 +05:30
Nguyen Quoc Bao
0b9b67169c fix(seed): Make element naming optional (#16926)
Closes #16905
Closes #15224
2018-03-23 14:12:28 -04:00
Ahmad Abdolsaheb
d987ce416d fix(seed): Chall seed and test are modified to allow better t (#16928)
es6.json seed file changed

Closes #16356
2018-03-23 13:41:44 -04:00
Seth Wilson
14c0414a08 fix(challenges): Fix typo in code example (#16866) 2018-03-16 21:15:35 +05:30
Murat Doğan
0fa5296f87 fix(challange): Redundant note has been removed (#16895) 2018-03-14 17:14:14 +05:30
Quincy Larson
34dea0ab9c Fix/copy improvements (#16859)
* fix(seed): Simplify copy of lessons and remove need for image

* rework copy for account creation and login emails

* fix: Fixup email template and lock-file
2018-03-09 19:39:44 +00:00
Pavel Tsurbeleu
38825dcb94 Improve instructions of "Global vs Local Scope in Functions" challenge (#16832) 2018-03-06 09:46:23 +05:30
Quincy Larson
b02aafc9b6 fix(seed): Make algorithm projects appear after intermediate algorithms (#16655)
* fix(seed): Make algorithm projects appear after intermediate

* fix(seed): Update order values to remove ambiguity
2018-02-10 09:20:59 +00:00
Jason Kao
102a233e69 feat(seed): Added ES6's strict mode to a lesson and made verbiage clearer (#16652) 2018-02-08 18:16:18 +05:30
Zuzana
6337592b99 fix(seed): Fix Modify Array challenge description typo (#16662) 2018-02-08 11:49:51 +05:30
Neenad Ingole
b36ba2cc99 fix(seed): Typo correction to es6.json in javascript challeng (#16589)
Closes #16584
2018-01-28 13:18:09 +05:30
mrugesh mohapatra
62c5720d9b Merge pull request #16573 from tarun7singh/fix/relative-protocol-URLs
fix(URLs): Changed protocol relative URLs to HTTPS URLs
2018-01-26 01:38:11 +05:30
Tarun Singh
8b5b0f338a fix(URLs): Changed protocol relative URLs to Https URLs
BREAKING CHANGE: None

Closes #16522
2018-01-25 20:11:01 +05:30
Timo
04c1ac1815 test(challenges): Add missing tests to escaping quotes challenges (#16566)
These tests were removed because there were issues with the head and
tail being added to the code variable. Now that they've been removed, we
can add the tests back in.
2018-01-24 23:35:32 +00:00
ATLowther
32930c9ed7 fix(challenges): Change invalid ObjectId
Closes #16550
2018-01-24 17:24:35 +01:00
A-J Roos
b75d7ae128 fix(seed): Fix invalid MongoDB ObjectId in array seed challenge (#16532)
In the `Introduction to Arrays` seed challenge there was a
incorrect MongoDB ObjectId. Created a new MongoDB ObjectId
that fixes it.

Closes #16530
2018-01-19 19:26:02 +05:30