7c19c82076
[BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 ( #40409 )
...
* [BUG] #40406 Fix
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md
Requested Change.
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-12-15 18:07:36 -07:00
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
f294d9cacc
fix(learn): removed use strict from various challenges ( #40321 )
2020-11-25 15:59:04 -08:00
7ce8c58709
Put value into quotes ( #40172 )
...
* Put value into quotes
It can be missunderstanding that "value" is a string!
* fix: remove quotes from inside code tags
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-25 16:32:14 -06:00
49f6875db5
fix(learn): ES6 Getters + Setters tests ( #40238 )
...
* Strengthen tests
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Improve verbiage
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* Add second check to setter test
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2020-11-25 14:22:44 -08:00
df44da9dc2
fix(challenge): correct terminology and inform of correct array copying ( #40045 )
...
* fix(challenge): correct terminology and inform of correct array copying
* fix(challenge): update text with proposed changes
2020-11-25 08:14:33 -08:00
bce3d5b372
fix(learn): remove white space for quick fix ( #40231 )
...
* fix(learn): remove white space for quick fix
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2020-11-20 09:21:21 +01:00
e8b6a9e5dd
fix(learn): add example declaration for clarity ( #40207 )
...
Variable declaration is added which is used inside the switch case.
2020-11-09 17:09:21 +00:00
895e6b8daf
fix(learn): add test to prevent hardcoded pass ( #40179 )
2020-11-06 17:05:20 +00:00
1badd3c3a6
fix(learn): add test case to regex challenge ( #40087 )
...
existing test cases can be satisfied by /^[a-z][a-z]+$|^[a-z][a-z]*\d\d+$/i
2020-11-01 13:24:35 +00:00
fb0812b6d2
fix(learn): added description about a nonallowed method ( #40121 )
2020-10-31 20:01:03 +01:00
8ceae38730
fix(learn): modified usage of words from argument to parameter based on the title ( #40130 )
2020-10-31 19:59:43 +01:00
35c4020f4d
fix(curriculum): test typos ( #39984 )
2020-10-15 14:49:57 -04:00
cc464a6e56
fix(learn): Possible semantic error in explanation comment ( #39813 )
...
* Possible semantic error
"identical" generally means that both variables are linked to exact same array which is not the case:
``` thisArray !== thatArray ```
Maybe "similar" or other word could be used instead
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/copy-an-array-with-the-spread-operator.md
Made the comment more accurate
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-10-14 19:53:49 -06:00
e2ae6303d5
fix(learn): Implement map and filter ( #39621 )
...
* Added changes to implement-filter-method challenge as requested in reviews by Randall D and moT01
* Added changes requested for in code review
2020-10-14 10:33:43 -06:00
a71150074d
fix(learn): preserve whitespace in the tool panel ( #39973 )
2020-10-14 21:40:15 +05:30
10d3126383
fix(learn): correct minor grammar mistake ( #39915 )
2020-10-13 12:14:49 +01:00
a32427c120
fix(learn): make semicolon at end of line optional ( #39821 )
2020-10-08 21:02:59 +01:00
94f0cf0ef8
chore(learn): Remove remaining isHidden keys from frontmatter (English and Chinese challenges) ( #39809 )
...
* fix: remove isHidden key from tool template
* fix: removed isHidden key from English challenges
* fix: remove isHidden key from Chinese challenges
2020-10-08 14:18:47 +02:00
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
362e8254f8
fix(learn): update test to allow negative arguments ( #39701 )
...
* Updated the regex in test
* Changed regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
* Updated changes in regex
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com >
2020-09-28 16:03:24 +01:00
104a8068e3
fix(learn): in ES6 spread operator challenge test for arr2 length > 0 ( #39680 )
...
* fix(learn): in ES6 spread operator challenge test for arr2 length > 0 too
Fixes #39662
* Accept correction
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com >
2020-09-24 16:14:44 -07:00
6ccd0d21a1
fix(learn): Update test text in Profile Lookup ( #39678 )
2020-09-25 00:38:40 +05:30
a86b220eb7
chore: remove isRequired from curriculum files
2020-09-21 20:51:46 +05:30
d8e8da36a0
Fixed tests for JS Basic Algorithms: Slice and Splice challenge as suggested in issue #39560 ( #39610 )
2020-09-18 11:30:56 -07:00
d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 ( #39609 )
2020-09-18 10:30:37 -05:00
a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson ( #39587 )
2020-09-17 13:00:58 -05:00
80438cac3e
feat(client, learn): add helper functions for common validation operations ( #38605 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-09-17 19:38:01 +05:30
30c61b808b
fix: consolidate misc comments ( #39583 )
2020-09-16 13:29:50 -05:00
b9c9a95223
chore(learn): Renamed all project-based curriculum project step filenames to use 3-digit format of part-ddd.md ( #39463 )
...
* fix: renamed basic html cat photo app steps
* fix: renamed css-variables project steps
* fix: renamed d3-dashboard filenames
* fix: renamed rpg-game filenames
* fix: renamed functional-progamming-spreadsheet filenames
* fix: renamed calorie-counter project filenames
2020-09-16 11:54:12 +05:30
4f1be63055
feat(learn): sync master and next-curriculum branches
2020-09-16 11:54:01 +05:30
dae411d408
fix: failing test ( #38253 )
2020-09-16 11:54:00 +05:30
9ba1f1f6d0
feat: tests for calorie counter
...
split up calorie counter lesson
2020-09-16 11:54:00 +05:30
b99d78858b
fix: basic js rpg spacing and tests
...
Replaced tabs with spaces so spacing is consistent in the monaco editor. Also adjust some tests to account for the new loop protection.
2020-09-16 11:54:00 +05:30
39b0afd5f0
feat: tests for calorie counter
2020-09-16 11:54:00 +05:30
d3d5147c1f
fix: renamed files and titles in the frontmatter for consitency ( #37792 )
2020-09-16 11:53:59 +05:30
2fbafda167
feat: functional programming spreadsheet ( #36873 )
...
* Add meta.json for spreadsheet
* Add spreadsheet files
* Close code tags for tests in 2 files
* Add solution section
* Add index file
* Add javascript-spreadsheet to stringifier
* Move index to step
* Rename steps in meta.json
* Rename step numbers in files
* Add index file to proper location
* Remove inappropriate files from spreadsheet dir
* Fix typo in first step
* Fix test sections
* Rename files to correct step
* Fix broken tests
* Add newline between sections
* Change challengeType from 1 to 0
* Add missng ) in step-079.md
* test -> tests in step-079
* Simplify test in step-103
* Fix step-137 test
* Remove last step
* Added solutions and adjusted some tests
* Fix some challenges
* Remove wrong spaces
* Fix more tests
* Add missing semicolon
* Fix more tests
* Fix type: lastttwo
* Fix all remaining tests
2020-09-16 11:53:59 +05:30
529f2596d9
feat: JS RPG game tests ( #37678 )
...
* feat: Add JavaScript RPG Game for testing
2020-09-16 11:53:58 +05:30
5cb609dc5c
Changed "statement" to "expression" ( #39564 )
...
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
c345bc9886
fix: removed scrimba video links that do not reflect current challenge ( #39559 )
2020-09-11 11:17:50 -05:00
2743ac2e84
fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" ( #39525 )
...
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"
* fix(challenge): update solution code
* fix:(challenge) update instructions and variable name
* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
5418307936
fix(learn): add whitespace check to else-if test ( #39555 )
2020-09-09 20:30:33 +01:00
b79a332984
fix: remove scrimba link for inaccurate video ( #39545 )
2020-09-08 13:09:53 -07:00
c23c4ef8e4
fix: negative sentiment → neutral language ( #39522 )
...
The existing terminology carries negative sentiment that can be
interpreted in a racial or sense. Updating the name to have no
potential for such a connection.
Co-authored-by: Justin Rogers <justrog@gmail.com >
2020-09-07 11:04:44 +05:30
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
2020-09-03 15:07:40 -07:00
56469d1c5c
fix(learn): update tests to allow more valid solutions ( #39054 )
...
* fix(curriculum): updated tests: fixed #39049
It won't pass something like this now:
const myConcat = () => {};
console.log(3);
* fix: add suggested change
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-03 15:28:35 +01:00
f97c847e29
fix(learn): formatting bug preventing tests to pass ( #39045 )
...
* implemented object validation
* fix: formatting bug preventing tests to pass
* implemented object validation
* fix: formatting bug preventing tests to pass
* integrated changes again
* added suggested changes
* fix: refine instructions
* fix: revert some bad instructions and change album to albumTitle
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-03 12:34:12 +01:00
046137891e
fix(learn): clarify how object names are associated with destructured fields ( #39485 )
...
* Clarify how object names are associated with destructured fields
* fix: make description more concise
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-pass-an-object-as-a-functions-parameters.english.md
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-09-02 19:06:27 +01:00
db15a44160
fix(learn): clarify instructions to remove confusion ( #39479 )
...
* Clarify instructions to remove confusion
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com >
2020-09-02 18:41:59 +01:00
9cd4b93601
fix(learn): getter setter instructions ( #39512 )
...
* Update use-getters-and-setters-to-control-access-to-an-object.english.md
* fix: revert changes, keep example
Co-authored-by: Daniel Sing <danielsingsong@gmail.com >
2020-09-02 18:07:17 +01:00
