gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
3,770 Commits 9 Branches 0 Tags
a5399361ee19bc8a95dc8c29cee80a4934e56c4c
Commit Graph

98 Commits

Author SHA1 Message Date
Jarek Wojciechowski
68b089e95d fix(challenges): add info about ReactDOM.render in an early react challenge (#17186) (#17473) 2018-06-11 18:22:32 +05:30
manjeet5
ff8b13b316 fix(challenges): Corrected a test case for challenge (#17162) 
For the last test case in 'Access Props using this.props' challenge, I
updated the test condition to check that the value of the tempPassword
prop is the same as the content within the <strong/> tags. This test
case will ensure that there is text present in the strong tag and its
value is as expected.

BREAKING CHANGE: none

Closes #17134
 2018-05-30 01:47:52 +08:00
Stuart Taylor
7c694c2666 Fix/react versions (#17236) 
<!-- freeCodeCamp Pull Request Template -->

<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.

#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] Add new translation (feature adding new translations)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17215

#### Description
<!-- Describe your changes in detail -->
 2018-05-25 17:27:15 +05:30
Stuart Taylor
4e645a5ff6 Package: Validate challenges on test (#17216) 
This PR allows us to validate the schema during test.

It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
 2018-05-22 18:13:14 +05:30
Stuart Taylor
ee66d84ccb feat(package): Initial Curriculum separation (#17174) 
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
 2018-05-21 19:26:49 +05:30
Aditya Rohilla
c212258e2d fix(seed): removed typo from task description (#17166) 2018-05-15 10:16:33 +05:30
Marcin Procyk
2b5e39e1f8 fix(seed): Bootstrap default button fix (#17082) 
added btn-default class to lessons with basic Bootstrap buttons, which
add proper styles for default button

Closes #17075
 2018-05-03 10:07:00 -04:00
Nicholas Nadeau, P.Eng., AVS
a8efeb50d7 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Ahmad Abdolsaheb
49a5fdafc2 fix(seed): Fixes tests (#17051) 
tests assert changed

Closes #17019
 2018-04-17 15:53:55 -04:00
Chaitanya
9610c2729f Fix to tests messages (#17059) 
In https://beta.freecodecamp.org/en/challenges/react/write-a-simple-counter challenge code is referring to Component Counter but messages are referring to myComponent
 2018-04-17 15:02:57 -04:00
Varun
857c9955d5 fix: SASS challenge and code indentation (#17036) 2018-04-17 14:08:35 -04:00
Hakeem Davis
9f5eb3b14c fix(seed): Clarify instructions (#17050) 
Closes #17044
 2018-04-13 09:49:01 +05:30
Edit Bazso
b208c477fc fix(seed): Fixed broken link in React Introducing Inline Styl (#17040) 
* fix(seed): Fixed broken link in React Introducing Inline Styl

* fix(seed): Fixed broken link in React Introducing Inline Style
 2018-04-07 22:06:11 -04:00
Varun
ad2d782c4d fix: typo in challenges/react.json (#17037) 2018-04-07 21:43:22 -04:00
Ákos
8a7198d335 fix(seed): Sass Challenge:Use @each to Map Over Items in a Li (#17032) 
Closes #16896
Closes #16894
 2018-04-07 11:45:50 -04:00
Alex Chaffee
52ca2b9ad6 feat(seed): reformat seed/challenges JSON via repack script 2018-04-03 19:53:44 +05:30
Stuart Taylor
2d77dc00b6 chore(challenges): Normalise challengeTypes 2018-04-03 19:52:01 +05:30
Gandharv Kumar Garg
d035932df9 fix(seed): Add test for checking the length of buttons is 2 (#16921) 2018-03-27 09:02:33 -04:00
Huyen Nguyen
29d967314f fix(projects): Add user stories to projects' description (#16924) 
BREAKING CHANGE: none

Closes #16810
 2018-03-23 13:22:55 -04:00
Durgesh Agrawal
7c38b2c89b fix(seed): Fix typo in redux.json (#16935) 
Closes #16920
 2018-03-23 00:32:30 -05:00
Quincy Larson
34dea0ab9c Fix/copy improvements (#16859) 
* fix(seed): Simplify copy of lessons and remove need for image

* rework copy for account creation and login emails

* fix: Fixup email template and lock-file
 2018-03-09 19:39:44 +00:00
Stuart Taylor
56b188389b chore(translations): Remove empty translation descriptions (#16805) 2018-03-02 11:39:29 -06:00
Neenad Ingole
d8fdaea661 fix(seed): message update to the test (#16718) 2018-02-26 12:37:43 +00:00
Quincy Larson
be7245bb0f fix(seed): Add legacy project back in and update id (#16749) 
Closes #16336
 2018-02-24 11:56:15 +05:30
Stuart Taylor
32073aaef4 feat(sass): Enable client-side sass compiling (#16747) 2018-02-19 14:41:01 -06:00
Stuart Taylor
4c650a6d85 feat(settings): Expand Settings page functionality (#16664) 
* fix(layout): Fix Settings layout in firefox

* chore(availableForHire): Remove available for hire setting

* feat(helpers): Use helper components for Settings layout

* fix(map): Fix undefined lang requested

* feat(settings): Expand Settings page functionality

* chore(pledge): Remove pledge from Settings

* fix(about): Adjust AboutSettings layout

* fix(portfolio): Improve PortfolioSettings layout

* fix(email): Improve EmailSettings layout

* fix(settings): Align save buttons with form fields

* fix(AHP): Format AHP

* fix(DangerZone): Adjust DangerZone layout

* fix(projectSettings): Change Button Copy

* fix(CertSettings): Fix certificate claim logic

* chore(lint): Lint
 2018-02-16 17:18:53 -06:00
Nguyen Quoc Bao
444aa7f939 fix(seed): Add length check for component find (#16678) 
Closes #16677

fix(seed): Use triple equal
 2018-02-14 17:50:38 +00:00
Jason Kao
e0aded6565 fix(seed): Removed inconsistent and unnecessary ReactDOM.rend (#16711) 2018-02-14 22:25:05 +05:30
Samuel Coe
5668502720 fix(seed): Replaced 'include' with 'match' and RegExp for the (#16700) 
Closes #16698
 2018-02-14 11:24:25 +00:00
Nguyen Quoc Bao
65a28d95e2 fix(seed): Add default values to incompleted declarations (#16704) 
Closes #16696

fix(seed): Fix undefined render
 2018-02-13 11:45:12 +00:00
Jason Kao
63069db4bf test(seed): Tests now send string values into input, not number (#16639) 
Closes #16636
 2018-02-08 11:36:42 +05:30
Nguyen Quoc Bao
536ef79213 fix(seed): Fix solution doesn't pass for challenge "React: Use Advanced JavaScript in React Render Method" (#16631) 
Closes #16629
 2018-02-08 11:23:20 +05:30
Tarun Singh
9f7f0077f2 fix(seed): Squashed a bug from Disable an element using Jquery 2018-02-06 15:53:07 +00:00
Jason Kao
d3b663338c fix(seed): Fixed disruptive, unclosed <code> tag (#16594) 
Closes #16581
 2018-02-06 10:18:11 +00:00
Nguyen Quoc Bao
6d566bfb9b fix(seed): Add missing bindings outside comment lines (#16585) 2018-02-05 23:18:10 -05:00
Neenad Ingole
0a225dce8f fix(seed): Change Line Number & Typo (#16586) 
Line number in the problem is corrected to 52 which was previously 38
and spelling mistake of 'compponent' is changed to 'component'

Closes #16567
 2018-01-28 17:37:37 +05:30
mrugesh mohapatra
62c5720d9b Merge pull request #16573 from tarun7singh/fix/relative-protocol-URLs 
fix(URLs): Changed protocol relative URLs to HTTPS URLs
 2018-01-26 01:38:11 +05:30
Tarun Singh
8b5b0f338a fix(URLs): Changed protocol relative URLs to Https URLs 
BREAKING CHANGE: None

Closes #16522
 2018-01-25 20:11:01 +05:30
Diogo Righi
698eeb33e3 fix(challenges): Fix test on react challenge that was always passing (#16558) 2018-01-23 20:16:57 -05:00
build65
235c77ed0d Turn Bootstrap relative URL into https URL (#16547) 2018-01-21 12:05:58 +05:30
A-J Roos
601f08b6c2 fix(seed): Fix invalid MongoDB ObjectID in jquery seed (#16535) 
In the `Introduction to jQuery' seed challenge there is a incorrect
MongoDB ObjectId. Created a new MongoDB ObjectId.

Closes #16523
 2018-01-19 19:18:00 +05:30
mrugesh mohapatra
77808b0feb fix(seed): Typos in testing code (#16515) 
Just formatting issues - missing quote, unescaped quotes in strings and
fixed a typo by moving code chars out of string literals.
 2018-01-17 23:10:50 -05:00
Berkeley Martinez
054dd8b4f6 Merge pull request #16442 from iabrenne/feature/link-to-guide 
Feature/link to guide
 2018-01-16 12:52:03 -08:00
Stephen Mayeux
0f73022cfd fix(seed): Eliminate regex bug for async assertions (#16341) 2018-01-16 11:25:20 +05:30
Irina Brennen
98d27c16c1 refactor(seed): Add link to guide 
Partially #16388
 2018-01-10 18:32:16 -06:00
Quincy Larson
ecc2c9f2f0 fix(seed): Fix label 
Closes #16456
 2018-01-09 16:10:27 -06:00
Berkeley Martinez
53b03596a0 Merge pull request #16217 from no-stack-dub-sack/fix/react-redux-finishing-touches 
fix(challenges): put finishing touches on react & redux challenges
 2017-12-21 09:22:23 -08:00
Peter Weinberg
652f943709 fix(challenges): put finishing touches on react & redux challenges 2017-12-21 00:03:42 -05:00
Jonathan Grah
43abd79788 feat(cert): Certificates (#16185) 
* feat(cert): finished layout and design of legacy certificates

* feat(cert): added new certs

* feat(cert): added logic for new certs

* feat(cert): updated claiming challenges

* feat(cert): fixed various small issues

* feat(cert): completed suggested changes
 2017-12-20 19:15:23 -06:00
Berkeley Martinez
3c56044e6c Feat: react redux migration (#16200) 
* feat: crudely enables test to run solution code against React challenge (and passes!)

* feat: Updates comment

* feat: Adds React 2 and 3, validates challenges in app

* feat: Adds React 4, validates tests

* feat: Adds Peter's migrated challenge seed files for all challenges

* feat: Adds redux, react-redux imports, adds tests for React 7,

* feat: Adds tests for React 08

* fix(challenges): wrap reserved words in <code> and add tests

* feat: complete first two tests for React 9

* feat: modifies tests in React 09

* feat: Adds working tests for React 37, including async setState tests

* feat: Escape hatch to avoid async tests in automated test suite

* feat: Updates React 15 with working tests

* feat: build passes, yay

* feat: Provisions original code string in challenges and adds tests for React Redux 01

* fix(tests): add self-closing tags challenge, other small fixes

* fix(challenge): add react_10, some other stuff

* fix(challenges): update react 22, add react 23

* fix(challenges): react 5 and react 8

* feat: removes dependencies that will break in browser, will replace later

* feat: fix build

* feat: add redux 1

* fix(challenge): add react 24 tests

* feat: partial implemented Redux 2

* feat: migrate redux 3

* feat: Adds React-Redux 04 with working tests under npm test

* feat: Updates automated test runner, just provide all the dependencies. Adds Redux-Thunk.

* feat: Adds working tests for React Redux 07

* feat: redux challenge 4

* feat: migrate redux 5

* feat: redux 6

* feat: migrate Redux test 7

* fix(challenge): add react 25 tests

* feat: Adds tests for React 48, npm test does not pass...

* feat: Migrate Redux test 8

* fix(challenges): skip 26, add react 27 tests

* fix(challenges): add react 28 tests, replace function w/ => throughout, fix linter warnings

* feat: fixes (patches) hard to understand problem with automated test suite

* feat: updates async tests patch

* feat: adds converted tests for React 47

* feat: adds converted tests for React 46

* feat: Partially adds tests for React 43

* docs: adds TO-DO tests for React 43

* feat: migrates tests for React 42

* feat: migrates tests for React 41

* feat: migrates tests for React 39

* feat: Migrates tests for React 38, automated test script fails again!

* feat: migrates tests for React 32

* feat: QAs more React Redux challenge in FCC UI

* feat: Updates tests for React 7

* feat: Migrates React-Redux 3 tests and hardcodes deep-freeze dependency

* feat: migrates React Redux 05 tests

* feat: migrates React Redux 06 tests

* feat: Migrates React Redux 10

* feat: Migrates tests for React 16

* feat: Migrates React 17 tests

* feat: Migrates React 18 tests

* feat: Migrates React 19 tests

* feat: Migrates React 19 tests

* feat: fixing usage of code, replace with editor.getOriginalCode

* feat: Migrates React 21 tests

* feat: Finishes migration of React 09

* fix(challenges): add react 45 tests 💀

* feat: Adds React 11 tests

* feat: Migrates React 50 tests

* feat: Re-enables original code in FCC editor, QAs challenges blocked by original code

* feat: hacks head tail code in editor test environment

* feat: updates React 20 head code

* feat: QAs React Redux 07 in UI

* fix(challenges): add React 29 tests

* fix(challenges): add React 30 tests

* feat: updates async tests

* feat: Migrates React 12, gets ReactDOM challenges working and QAs them

* feat: Migrates React 13 tests

* feat: Migrates tests for React 14 and updates challenge description formatting

* feat: Refactors 2nd test for Redux 02

* feat: Migrates React 33

* feat: Removes React 26 and 43

* feat: Adds React 34 from Kevin

* fix(challenges): add React 31 & 35 tests (thanks Kevin)

* feat: Migrate Redux challenge 10 - pass both UI QA and terminal test

* fix(challenge): add react 40 tests

* feat: Migrates React Redux 02 tests

* feat: Migrates React Redux 08 and fixes async syntax in React challenge

* fix(challenge): add react 49 tests with caveat

* feat: fixes React 49 tests and adds first tests for React Redux 09

* feat: Migrate Redux 11 - pass both terminal test and UI test

* feat: Migrate Redux 12 - passing both UI test and terminal test

* feat: Migrate Redux 13 - passing both terminal and UI tests

* feat: Adding in code tags for previous redux challenges - terminal and UI tests pass

* feat: Migrates React Redux 09 and React 44 (thanks Kevin)

* feat: fix code tag issues - passed UI and terminal tests

* feat: Migrates Redux 14 tests

* feat: Migrates Redux 14

* feat: Migrates Redux 15

* feat: Migrates Redux 17

* feat: Final migration and QA of Redux, except for Redux 9

* feat: migrates React 36 and QAs

* feat: Rewrites Redux 09 and migrates

* feat: refactors pull request and cleans up code

* style(challenges): QA React challenges

* style(challenges): QA react challenges

* fix(challenges): fix react 41 and 45 tests

* style(challenges): QA redux challenges

* style(challenges): QA react and redux challenges

* fix(seed/react): Move head/tail to files

* fix(seed/redux): Move head/tail to file level

* chore(packages): Move jsdom to dev deps

* fix(seed/react/redux): Async funcs

make async func defined

* fix(seed): %s/editor.getUserCode/getUserInput/gc

* fix(Challenges/build): Make sure head/tail is bundled and transformed

* feat(Challenges.react): Add tail to render component

* chore(seed): Disable modern challenge testing for now

We will put these on beta while we update the auto testing framework
 2017-12-18 15:04:03 -06:00