Commit Graph

100 Commits

Author SHA1 Message Date
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761)
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
2019-11-27 11:57:38 +01:00
deb24f77b6 fix(curriculum): English editing (#37814)
* fix(curriculum): English editing

* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* Update use-class-syntax-to-define-a-constructor-function.english.md
2019-11-24 16:38:30 -05:00
dc1b59070e fix: use arrow function syntax (#37818) 2019-11-24 02:37:11 -05:00
0c22313760 fix(curriculum): English editing (#37815)
* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-11-23 18:37:36 -05:00
70f736fe07 fix(curriculum): English editing (#37816) 2019-11-23 17:28:56 -05:00
2287d73b4f fix missing closing brace and bracket for promise (#37474)
There was a missing closing brace, bracket and semi-colon for the constructor new Promise in its definition
2019-11-07 19:24:54 +01:00
a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
4507a6b254 Minor grammar fixes (#36643)
* Minor grammar fix
2019-08-20 14:36:22 +01:00
76bd5f4fc3 Issue #36564 update regex for spread operator (#36565)
* Issue #36564 update regex for spread operator

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-the-spread-operator-to-evaluate-arrays-in-place.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-08-06 14:56:48 -07:00
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
91df817cfe fix(guide) add stubs, update spellings and prepare for move (#36531)
* fix(guide) add stubs and correct file path misspellings and pr… (#36528)

* fix: corrected file path to match curriculum

* fix: renamed to newer challenge name

* fix: added solutions to articles from challenge files

* fix: added missing .english to file name

* fix: added missing title to guide article

* fix: correct solution for guide article

* fix: replaced stub with hint

* fix: added space in Hint headers

* fix: added solution to guide article

* fix: added solution to guide article

* test: replaced stub with hint and solution

* fix: add Problem number: to title

* fix: changed generatorexponential to correct name

* fix: renamed knight's tour to knights-tour

* fix: updated guide article
2019-07-30 00:25:58 +05:30
5bf8527523 fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 02 (#36402)
* fix: rm assert msg basic-algorithm-scripting

* fix: rm assert msg debugging

* fix: rm assert msg es6

* fix: rm assert msg functional-programming
2019-07-24 10:47:32 +02:00
b8593326b0 fix: remove guide linting and fix failing challenges 2019-07-19 15:30:17 +05:30
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
9ce8bbb4c0 fix/add-suggested-grammar-and-punctuation 2019-07-12 22:44:23 +09:00
d3cf6f42dd fix/grammar+punctuation 2019-07-12 22:44:23 +09:00
fa365a7f77 fix/capitalization-in-title 2019-07-12 22:44:23 +09:00
832cbc91b1 fix/the-mess-I-made 2019-07-12 22:44:23 +09:00
da254743cd feat/new-lessons-on-js-promises 2019-07-12 22:44:23 +09:00
f03f05d53d fix(challenge): rename challenge, change fields to properties, fix test (#36338)
* fix(challenge): rename challenge, change fields to properties, fix test

* fix(challenge): update challenge name in meta.json

* fix(challenge): update test and assertion message

* fix(challenge): update second assert message

* fix(challenge): remove the word Person from text
2019-07-10 10:31:15 +02:00
Tom
50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom
72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom
81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
4b4762716c fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section (#35954)
* fix: reworded and moved challenge

* fix: removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix; removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: reworded sentence

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-15 11:12:17 -05:00
338d7ee8a7 Change "rest operator" to say "rest parameter" in challenges and guide (#35496)
* change es6 challenges rest operator to param

* fix rest parameter typos

* change rest operator to parameter in guide

* fix casing

* change rest operator to rest parameter in guide

* change rest operator to rest parameter in curriculum

* remove extra whitespace

* remove whitespaces

* remove whitespace

* fix: removed arabic file

* fix: removed chinese file
2019-05-08 16:30:24 +02:00
7d7a1127a7 fix: remove comments before tests (#35906) 2019-04-30 19:26:07 -05:00
dae22c95c3 Edit Instructions Text To Make Goal Clearer (#35887)
* Edit Instructions Text To Make Goal Clearer

The instructions end with "using the object provided" which is unclear since the user is expected to create their own name for the object. Users may think they need to reference an object name and be confused when they do not find it. Reiterating that the user needs to create the name for the object themselves makes the task clearer.

* Updated commit based on comments
2019-04-26 18:33:04 +05:30