Randell Dawson
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-11-20 20:15:19 +05:30
Randell Dawson
39df6a2b56
fix(curriculum): added new test to Give Links Meaning by Using Descriptive Link Text challenge to specifically for href attribute ( #37699 )
...
* fix: added new test to test href attribute
* fix: changed You to Your
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed a to an
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-15 10:14:54 -06:00
Randell Dawson
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson
d0d8282f86
fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections ( #36457 )
...
* fix: remove double quoted assert msg arg - responsive
* fix: remove double quoted assert msg arg - js
* fix: remove double quoted assert msg arg - libraries
* fix: remove double quoted assert msg arg - coding interview
2019-07-24 13:06:12 +01:00
Randell Dawson
e763330fc3
fix: removed assert msg argument ( #36405 )
2019-07-24 11:42:26 +02:00
Randell Dawson
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
Steven Failla
438e7d4c51
fixed testString to disallow any extra characters from passing. Also … ( #35987 )
...
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
Co-Authored-By: Stevo99 <Sfailla1983@gmail.com >
* fixed test so it won't pass if datetime attr is left blank
* fixed test so it will not pass if datetime attribute is left empty
* fixed error in testString where test would pass if user runs test right away
* added tear-down div to make test code look cleaner
* fixed merge conflict. added tear-down div to make code look cleaner
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
improvement to test case where element should have closing tag.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fixed conflict in git
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md
removed unnecessary test
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2019-06-28 18:49:00 -04:00
adamthahir
acbc07e0ff
Fixed typo addressed in #36225 ( #36227 )
...
* Fixed typo addressed in #36225
* Updated as per discussion.
2019-06-15 13:02:01 +07:00
Weibin Luo
8cb540fe85
fix: use lowercase for 'article' tag ( #36222 )
2019-06-09 07:47:09 -07:00
Randell Dawson
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
Ian Effendi
cf86246866
fix(curriculum): Add solutions to 16 Applied Accessibility challenges #35751 ( #35809 )
...
This commit adds 16 full working solutions to the responsive web design
principles dealing with applied accessibility.
2019-04-24 19:12:46 +05:30
Beau Carnes
7e522dc473
fix: add new scrimbas ( #35803 )
2019-04-10 09:23:12 -07:00
Ian Effendi
f74d507434
fix(curriculum): replace js with full solution in accessibility challenge ( #35810 )
...
* fix(curriculum): add full, working solution for accessibility challenge.
This commit replaces a JavaScript only solution where a full, working
solution should have been written.
* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
Co-Authored-By: rimij405 <effendiian@gmail.com >
2019-04-10 17:55:16 +02:00
rupali317
bc72c86dc6
fix: updated the note sections for responsive web design english ( #35528 )
2019-03-22 15:02:12 +01:00
Dana Ottaviani
0a2aa3dcfa
feat: add solution to accessibility challenge ( #35553 )
...
* feat: add solution to accessibility challenge
* Remove space before closing `time` tag
Co-Authored-By: Dana94 <dana.ottaviani@gmail.com >
2019-03-10 11:09:57 -07:00
Dana Ottaviani
3d1fd805e6
feat: add solution to accessibility challenge ( #35484 )
2019-03-01 20:03:38 -05:00
Dana Ottaviani
30fd0aa78e
fix: add solution for accessibility challenge ( #35366 )
2019-02-25 21:58:35 -05:00
Randell Dawson
aa621a20b5
fix: removed unecessary guideUrl from frontmatter
2019-02-19 11:34:27 +03:00
Dana Ottaviani
9562bf0baa
Solution to implementing an accessible date picker ( #35262 )
...
* feat: add challenge solution
* fix: remove whitespace and filler comments
2019-02-17 17:25:41 -08:00
Melkisedek Hamakali
a0c00de32b
Use correct spelling of navigable ( #34817 )
2019-02-17 01:52:19 -08:00
Randell Dawson
9c3145ea49
fix: improved the grammar and readability ( #35133 )
2019-02-16 18:02:35 +05:30
Dana Ottaviani
bad8846e04
feat: add solution to accessibility challenge ( #35131 )
2019-02-16 18:00:42 +05:30
Dovid Majowka
16ef2639c0
Updated wrong guideUrl to correct one ( #35066 )
...
* Update add-a-text-alternative-to-images-for-visually-impaired-accessibility.english.md
* Use standard link for guide URLs
* fix: corrected guideUrl
* fix: corrected guideUrl again
2019-02-16 17:52:16 +05:30
The Coding Aviator
9c881dcc6e
Fixed issue with accessibility challenge about contrast ( #19711 )
...
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
* Update avoid-colorblindness-issues-by-using-sufficient-contrast.english.md
2019-02-10 14:03:01 -06:00
Cryotechnic
80e80a4c8b
Word Correction ( #29689 )
...
* Word Correction
Some words were missing, making the sentence sound grammatically incorrect.
* fix: removed the word its
2019-02-10 07:51:00 -08:00
Naveen
f6f58d3228
Remove unwanted comma ( #26050 )
2019-02-10 07:33:56 -08:00
Leo
16bca6e24a
Closes #34988 : "Clicking on link in the code preview opens up the web page within the web page" ( #34995 )
2019-02-04 15:57:49 +03:00
Leo
47857d9fcb
Deleted wrong comma ( #34979 )
2019-01-28 08:33:11 -08:00
Leo
721cbba477
Deleted an unneccessary comma ( #34976 )
2019-01-28 08:28:11 -08:00
Leo
7f31aa807c
Deleted comma ( #34987 )
2019-01-28 08:18:42 -08:00
Quincy Larson
d006696c85
Correct two mixed up Scrimba links ( #34892 )
2019-01-18 03:27:01 +05:30
The Coding Aviator
fd8414062d
Fixed issue which was causing problem while testing for headings challenge ( #19590 )
...
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
* fix(tests): for closing tags
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
* Update use-headings-to-show-hierarchical-relationships-of-content.english.md
2018-11-15 20:59:35 +05:30
Valeriy
79d9012432
fix(curriculum): quotes in tests ( #18828 )
...
* fix(curriculum): tests quotes
* fix(curriculum): fill seed-teardown
* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
Bouncey
ee9f6b2d72
chore(meta): Move challenge meta to challenges root
2018-10-11 02:15:05 +05:30
Beau Carnes
46d8d61776
docs: update guide url
2018-10-08 11:02:25 -04:00
Bouncey
a859035023
fix(challenge-md): Fix quotes that failed in the transform
2018-10-08 11:38:26 +05:30
Bouncey
8f39bc1288
chore(curriculum): Remove files in wrong format
2018-10-05 15:58:12 +01:00