396 Commits

Author SHA1 Message Date
moT01
9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01
d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01
61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom
72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01
3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom
81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01
d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
moT01
21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
moT01
246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
Tom
51b5defb7e fix/regex-upper-and-lower-bounds-tests (#36059)
* fix/regex-upper-and-lower-bounds-tests

* fix/add-solution-back

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/specify-upper-and-lower-number-of-matches.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-25 14:45:20 -07:00
Randell Dawson
3fa14df925 fix: renamed folder without starting dash (#36124) 2019-06-21 18:05:33 -04:00
Randell Dawson
f53ca79890 fix: changed tests to allow other valid solutions (#36210) 2019-06-21 18:04:30 -04:00
Randell Dawson
63a0fa745b fix: improved tests to allow more valid solutions (#36193) 2019-06-20 17:09:46 -04:00
Oliver Eyton-Williams
2024e238fa feat(curriculum): Add basic recursion lesson (#36200)
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-06-19 23:50:44 +05:30
Michał Kozłowski
8b40da02a3 multiple ternary operator challenge - add note about code readability (#36269)
* fix multiple ternary operator challenge

* Fix a typo in multiple ternary operator challenger

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Fix a typo in multiple ternary operator challenge #2

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-15 19:06:56 +01:00
Siddhant Shekhar
c1d3817732 fix : replaced test cases' string to make more sense (#36170) 2019-06-06 15:53:31 -07:00
Randell Dawson
5a06b71ac4 fix: modified tests text (#36169) 2019-06-04 16:14:52 -04:00
Natalie Cardot
db1b435775 Fix spelling (#36111)
"hachedEgg" -> "hatchedEgg"
2019-05-22 17:42:44 -05:00
Varun
3a4402434b fix(curriculum): Update challenge instructions (#36104) 2019-05-21 15:07:50 -07:00
Natalie Cardot
545b8a6f34 Modify if statement (#36088)
* Modify if statement

Change the solution so an empty string is returned when num is less than 1 rather than less than 0 for consistency with instructions.

* Add test 

New test checks that if num is 0, an empty string is returned

* Fix test 

Fixing errors in newly proposed test that checks that empty string is returned when num is 0

* Modify intermediate solution

Changing if statement in intermediate solution to check whether num is less than 1 rather than less than 0. (Also adding curly brackets to that solutions if/else statements.)

* fix: removed unnecessary assert message arguments
2019-05-20 21:08:20 -04:00
Natalie Cardot
39c43dbe8a Alter instructions (#36099)
Removing the word "below" since the object's properties are shown to the right of, not below, the challenge description/instructions.
2019-05-20 19:11:17 -04:00
Tom
21118bc26a fix/regex-lower-number-of-matches (#36004)
* fix/regex-lower-number-of-matches

* fix/update-guide

* fix/convert-blockquote-to-backticks
2019-05-17 23:53:00 +01:00
Randell Dawson
05f73ca409 fix(curriculum): Convert blockquote elements to triple backtick syntax for JavaScript Algorithms and Data Structures (#35992)
* fix: convert js algorithms and data structures

* fix: revert some blocks back to blockquote

* fix: reverted comparison code block to blockquotes

* fix: change js to json

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: convert various section to triple backticks

* fix: Make the formatting consistent for comparisons
2019-05-17 08:20:30 -05:00
Randell Dawson
4b4762716c fix(curriculum): Rewrote the Write Higher-Order Arrow Functions challenge and moved to Functional Programming section (#35954)
* fix: reworded and moved challenge

* fix: removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix; removed extra line

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: reworded sentence

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-15 11:12:17 -05:00
Matt Schlosser
08c4807b09 Added missing </code> in test text string (#36040) 2019-05-14 10:06:55 +02:00
Tom
fc547999fd fix/record-collection (#36002)
* fix/record-collection

* fix/remove-old-assert-messages

* fix/attempt-to-fix-build-error

* fix/attempt-to-fix-build-error

* fix/change-verbiage-and-tidy-up

* fix/remove-brackets-in-regex
2019-05-12 23:45:18 -04:00
Randell Dawson
7437145bb4 fix: improved existing tests (#35801) 2019-05-09 09:01:50 -04:00
Deanna Tran
338d7ee8a7 Change "rest operator" to say "rest parameter" in challenges and guide (#35496)
* change es6 challenges rest operator to param

* fix rest parameter typos

* change rest operator to parameter in guide

* fix casing

* change rest operator to rest parameter in guide

* change rest operator to rest parameter in curriculum

* remove extra whitespace

* remove whitespaces

* remove whitespace

* fix: removed arabic file

* fix: removed chinese file
2019-05-08 16:30:24 +02:00
Tom
93e5554615 fix: added semi-colon not in original code
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-05-07 10:43:43 -07:00
Randell Dawson
5cfff58c7b fix: added all js to end of 3 backticks 2019-05-07 10:43:43 -07:00
Randell Dawson
5cf039e5fd fix: performed first conversions 2019-05-07 10:43:43 -07:00
Randell Dawson
1cb6092dd9 fix: performed first conversions 2019-05-07 10:43:43 -07:00
Oliver Eyton-Williams
cde8035b79 fix: add test for and slight rewrite to hazards of imperative (#35331)
* fix: add test for and slight rewrite to hazards of imperative

* fix: Resolve merge conflict

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/understand-the-hazards-of-using-imperative-code.english.md

Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: Make the only mistake in seed the use of splice
2019-05-06 07:27:38 -05:00
Randell Dawson
a092c76688 fix: added 22 missing solutions (#35747) 2019-05-03 12:05:26 +02:00
Randell Dawson
365ce2ddc7 fix(curriculum): Added test and corrected solution for Restrict Possible Usernames challenge (#35847)
* fix: added test and corrected solution

* fix: removed redundant regex

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
2019-04-30 20:40:38 -05:00
Randell Dawson
3bff4151cf fix: rewrote challenge instructions and tests (#35899) 2019-04-30 20:19:06 -05:00
Randell Dawson
7d7a1127a7 fix: remove comments before tests (#35906) 2019-04-30 19:26:07 -05:00
Randell Dawson
66398a9300 fix(curriculum): Improved the tests for Find the length of a String challenge (#35940)
* fix: split tests into two requests

* fix: removed typeof number check

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: remove unneeded After Test section
2019-04-30 19:12:22 -05:00
RIHANE ZAKARIA
6630b2be7a bug fix / test of Spread Operator javascript challenge / english (#35856)
* bug fix test with the Spread Operator

* test of Spread Operator javascript challenge / english / change test and add a helper function
2019-04-30 18:37:26 -05:00