Commit Graph

299 Commits

Author SHA1 Message Date
Anton Strömkvist
7a3e84cb0d Merge pull request #2739 from bugron/bugron-1881
Changes nonexistent variable name to proper one
2015-09-08 01:57:41 +02:00
ahstro
0055c3b271 Move brace out of user-edit scope
Move the closing brace of a function down below the
`// Only change code above this line`-comment in
`Use Conditional Logic with IfElse Statements`

Fix #3152
2015-09-07 22:56:27 +02:00
Jakob Dahl
033175ae23 Updated and rebased pr 2015-09-07 03:08:08 +02:00
natac13
34246716c0 Test improvements
changed the jquery selector to account for single and double quotes
as well as optional spaces on:
[Give your JavaScript Slot Machine some stylish images](http://www.freecodecamp.com/challenges/waypoint-give-your-javascript-slot-machine-some-stylish-images)
[Bring your JavaScript Slot Machine to Life](http://www.freecodecamp.com/challenges/waypoint-bring-your-javascript-slot-machine-to-life)
[Target the same element with multiple jQuery Selectors](http://www.freecodecamp.com/challenges/waypoint-target-the-same-element-with-multiple-jquery-selectors)
[Target the Parent of an Element Using jQuery](http://www.freecodecamp.com/challenges/waypoint-target-the-parent-of-an-element-using-jquery)
2015-09-06 13:12:06 -04:00
Arsen Melikyan
c8dee301ee Merge pull request #3109 from AryanJ-NYC/AryanJ-NYC-2136
Added details to instructions of JS arrays waypoint
2015-09-06 10:18:44 +04:00
Aryan Jabbari
0f46ed8c9d Used strict equality for second assert 2015-09-06 00:39:07 -04:00
Aryan Jabbari
2817ec49a9 Checks that length is used twice for JS bracket notation challenges; closes #3105 2015-09-06 00:37:12 -04:00
Aryan Jabbari
aa34bf1a41 Added details to instructions of JS arrays waypoint; closes #2136 2015-09-05 20:53:54 -04:00
bugron
f417adc2d1 fixes a condition in assert 2015-09-05 19:20:41 +04:00
bugron
f4512dd929 fixes assert and some text 2015-09-05 18:05:09 +04:00
bugron
7289607f07 Fixes 'd[0].toLowerCase() is not a function' error 2015-09-05 16:38:09 +04:00
Quincy Larson
6bcc72ece7 Merge pull request #3002 from dmytroyarmak/dmytroyarmak-2999
Improve test cases for Generate Random Whole Numbers within a Range
2015-09-04 15:27:36 -07:00
natac13
d789633494 Added tests to JavaScript Give Slot Machine Some Style
The challenge could be passed by copying the code 3 times.
Made new tests to stop this

closes #2111
2015-09-04 13:48:51 -04:00
Dmytro Yarmak
dd5feb4a2c Improve test cases for Generate Random Whole Numbers within a Range 2015-09-02 23:17:33 +03:00
Dmytro Yarmak
bdd2803923 Add output block to "Iterate with JavaScript For Loops" challange 2015-09-01 13:41:40 +03:00
Atik Shaikh
da6fdcb9e5 Update basic-javascript.json 2015-08-31 00:49:27 +05:30
Ben McMahon
20d58b5208 Merge pull request #2490 from abhisekp/patch-3
Add correction to Waypoint - Sift through Text with Regular Expressions
2015-08-30 16:16:48 +01:00
Abhisek Pattnaik
a2db581771 Change challenge seed 2015-08-30 20:37:32 +05:30
Abhisek Pattnaik
a0f700b7db Merge remote-tracking branch 'upstream/staging' into patch-3 2015-08-30 13:49:04 +05:30
Natac13
20462582f4 fixed minor typo where there was a 's' left when the sentence was changed. Issue #2853 2015-08-29 18:30:16 -04:00
Ben McMahon
e3e1f16195 Merge pull request #2820 from AEA2002/staging
Minor edit in Find the Nth Character
2015-08-29 19:25:29 +01:00
Ben McMahon
fc5316f545 Merge pull request #2821 from uwaseem/uwaseem-1979
Fixed typo for issue 1979
2015-08-29 19:23:46 +01:00
bugron
beab6a4472 fixes 'editor.getValue(...).match(...) is null' 2015-08-29 02:35:06 +04:00
waseem
eec0d073f1 Fixed typo for issue 1979 2015-08-29 04:08:48 +08:00
ahstro
33ed3ae8b0 return(foo) => return foo 2015-08-27 22:19:03 +02:00
Arsen Melikyan
b24f367749 Changes nonexistent variable name to proper one 2015-08-26 18:59:59 +04:00
AEA2002
b9cfc09eb9 Minor edit in Find the Nth Character
In "Use Bracket Notation to Find the Nth Character in a String" section removed "last" from  'The third last letter of lastName should be..."
2015-08-25 18:34:31 -04:00
Aniruddh Agarwal
57c3261415 replaced + by . 2015-08-25 22:42:58 +08:00
Aniruddh Agarwal
0cc032a6e9 fixed conflicts 2015-08-25 22:21:33 +08:00
Aniruddh Agarwal
beb537d5eb Cleaned up description for 'Sift through Text with Regular Expressions' waypoint 2015-08-25 20:26:32 +08:00
Aniruddh Agarwal
5ce26c5b4b Expanded description of 'Build Javacript Objects' waypoint 2015-08-25 19:36:47 +08:00
Quincy Larson
048a7d3dce Merge pull request #2620 from bugron/bugron-1522
Fixes missing backslash in waypoints' instructions'
2015-08-24 19:02:22 -07:00
Quincy Larson
e5a9b697ae Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging 2015-08-24 17:54:00 -07:00
bugron
f750182a4b Adds a desctiption to avoid confusion in JS challenges 2015-08-25 04:41:02 +04:00
Berkeley Martinez
26e1f3fdac Merge pull request #2568 from AryanJ-NYC/AryanJ-NYC-1876
Fixed #1876; fixed some grammar issues; adhered to JS comment convent…
2015-08-24 11:14:32 -07:00
Berkeley Martinez
c82909de0c Merge pull request #2596 from suhussai/suhussai-2592
Typo Fix. Closes #2592
2015-08-24 11:03:34 -07:00
Arsen Melikyan
d54bbaaf2d Fixes missing backslash in waypoints' instructions'
In three waypoints: [Find Numbers with Regular Expressions](http://www.freecodecamp.com/challenges/waypoint-find-numbers-with-regular-expressions), [Find White Space with Regular Expressions](http://www.freecodecamp.com/challenges/waypoint-find-white-space-with-regular-expressions), [Invert Regular Expression Matches with JavaScript](http://www.freecodecamp.com/challenges/waypoint-invert-regular-expression-matches-with-javascript) there are confusing instructions: /d+/gi instead of /\d+/gi, /s+/gi instead of /\s+/gi, /S+/gi instead of /\S+/gi.This commit fixed them.
2015-08-24 14:48:38 +04:00
benmcmahon100
8136443f87 Fix #2605 2015-08-24 00:22:35 +01:00
suhussai
2cc09ce374 Typo Fix. Closes #2592
Changed "greater then" to "greater than" in Waypoint 30, http://freecodecamp.com/challenges/waypoint-generate-random-whole-numbers-with-javascript
2015-08-23 12:20:28 -06:00
Aryan Jabbari
ba0ff40604 Fixed #1876; fixed some grammar issues; adhered to JS comment conventions 2015-08-23 05:19:45 -04:00
Quincy Larson
9fc3fd72b1 Merge branch 'staging' of github.com:FreeCodeCamp/freecodecamp into staging 2015-08-22 18:08:37 -07:00
Quincy Larson
ebf1530d6f update JavaScript copy from pull request 2015-08-22 17:40:59 -07:00
Berkeley Martinez
810e40e4db Merge pull request #2505 from issyl0/fix_typo_iterate_with_js
In the while loop iterator section, advise while loops, not for loops
2015-08-22 17:22:14 -07:00
Abhisek Pattnaik
3b6da88e7f Fix error in string 2015-08-23 03:26:20 +05:30
Abhisek Pattnaik
e87913edad Fix Add your JavaScript Slot Machine Instructions 2015-08-23 03:22:05 +05:30
Isabell Long
1206655940 In the while loop iterator section, advise while loops, not for loops
- Fixes #2504.
2015-08-22 20:27:08 +01:00
Berkeley Martinez
f90f59f0c6 Merge pull request #2498 from issyl0/add_full_stops
Add full stops at the end of "Random Whole Number" waypoint
2015-08-22 10:14:04 -07:00
Isabell Long
a816dc5a19 Add periods at the end of sentences in the Random Whole Number waypoint
- Partially fixes #1991.
2015-08-22 18:08:58 +01:00
waseem
7fad44e648 Fixed grammar - replaced 'but' with 'by' 2015-08-22 22:21:15 +08:00
Abhisek Pattnaik
c5c68c252c Correct Sift through Text with Regular Expressions
- Change information text
- Change regular expression
- Change code in editor
- Change assertion
2015-08-22 19:05:41 +05:30