gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
25,839 Commits 9 Branches 0 Tags
aff56ac392f6b6ffbc9550c8236bee49dc5f713c
Commit Graph

349 Commits

Author SHA1 Message Date
Randell Dawson
6a7a7e6d7d fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Oliver Eyton-Williams
2d7b1255cc fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Vincent Shury
b49b9f3e3c Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247) 
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0 fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105) 
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-02-24 15:30:48 +01:00
Oliver Eyton-Williams
b0f1fa4b96 fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
Igor Snitkin
dc7092ecd1 (fix learn): Update description to accommodate tests (#38224) 2020-02-19 00:13:34 +05:30
Oliver Eyton-Williams
f84173866a fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
Hassaan Pasha
0498e27902 fix: added white space checks including newlines to ensure pro… (#38166) 
* fix: added white space checks including newlines to ensure proper validation of trim method

* fix: Addressing comments
 2020-02-12 12:17:54 +05:30
Ashraf Nazar
5feabd762c fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00
Hassaan Pasha
80ba943ca3 fix: fixed regex for validating newlines in for loops (#38180) 2020-02-09 18:43:43 -06:00
Josh Soref
004b99bf8f chore: fix typos in spelling (#38100) 
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
 2020-02-08 23:59:10 +05:30
Kiara Barias
afd467f5dc Removes RSA links from English challenges (#37869) 
* RSA links deleted from challenges

* fix: remove remaining RSA links in challenges
 2020-02-07 14:46:07 +09:00
Shubham Shah
bef738f0d4 modfied tests and made correction in solution (#38023) 2020-02-06 20:31:03 -05:00
Hassaan Pasha
d89eae392f fix: adding test to check if flat or flatMap method was used in the steamroller challenge (#38158) 
* fix: adding test to check if flat or flatMap method was used in the steamroller challenge

* Addressed comments and acknowledged suggestions
 2020-02-04 17:00:33 -05:00
Ashraf Nazar
fda7fb174e fix: Correct paths in English exercises by prefixing "/" before "learn" (#38099) 
* fix: Correct paths in English exercises by prefixing "/" before "learn"

* fix(lang): Correct paths to exercises by prefixing "/" before "learn" in remaining languages
 2020-01-26 12:51:21 -06:00
Ashraf Nazar
1159a8dcaf fix: Add edge case for mixed grouping of characters exercise, where "Frank Roosevelt" returns false (#38097) 2020-01-22 15:58:47 +05:30
Perrottarichard
bc470325d0 Update use-destructuring-assignment-with-the-rest-parameter-to-reassign-array-elements.english.md (#38092) 
I added 'the' to correct the English grammar and hence improve the readability of the instructions.
 2020-01-21 08:25:10 -06:00
ML
d824c77012 Move the comment on line 71 to its own line (#38036) 
* Move the comment on line 71 to its own line

The comment "use function argument destructuring" was on the same line as some code, and when displayed as a challenge it returned to a new line and was not commented out.

* Update line 71 comment per @manish-giri suggestion

Move the comment "use function argument destructuring" to above the "change code below this line" comment for clarity. Based on conversation in this pull request https://github.com/freeCodeCamp/freeCodeCamp/pull/38036
 2020-01-15 08:17:34 +05:30
Randell Dawson
a70e15c0a7 fix: allow-space-in-destructuring-regex (#37997) 2020-01-07 17:22:15 +01:00
Tom
1b06bb29f0 fix: allow g flag on regex (#37941) 2020-01-02 18:24:07 -07:00
Nikolas Broman
d07c85151b Fix typo (remove duplicate word 'should') (#37998) 2019-12-31 08:50:46 -08:00
Randell Dawson
1f98af5841 fix: used assert.deepEqual to compare arrays (#37959) 2019-12-31 13:33:04 +05:30
Shubham Shah
3cc0395964 added a test to challenge:falsy-bouncer (#37973) 
* added a test to challenge:falsy-bouncer

* modified tests of challenge:falsy-bouncer
 2019-12-29 17:17:17 -06:00
Gregory Gubarev
8bd2fb8bc5 fix(i18n): delete duplicate text in test desc (#37975) 2019-12-23 20:47:10 +05:30
Sean Coleman
203c9823e8 Fixed minor grammar issue in escape-sequences-in-strings.english.md (#37940) 
* Update escape-sequences-in-strings.english.md

Fixed minor grammar issue in list item 1 of the description section.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2019-12-16 06:16:16 -08:00
Arthur
616d96f612 refactor: update trivial regex capture group find and replace challenge (#37768) 
* refactor: replace trivial regex capture group challenge

Previous challenge could be completed without any capture groups. New
challenge requires 3 capture groups and 3 uses of the submatches in the
replacement.

resolves #17645

* test: validate at least 3 capture groups were used

Use solution from SO
(https://stackoverflow.com/questions/16046620/regex-to-count-the-number-of-capturing-groups-in-a-regex)
as suggested by @RandellDawson to count the number of capturing
groups, regardless of whether or not the regex in question solves the
broader problem.

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* refactor: more meaningful variable name

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* test: add parenthesized substring test

* test: ensure 3 uses of substring replacement

* refactor: reword instructions

* fix: minor grammar fix

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* refactor: elaborate wording in test
 2019-12-14 16:41:47 -05:00
Randell Dawson
cb3524ee31 fix: simplify challenge testString (#37826) 2019-12-07 15:47:08 -05:00
Randell Dawson
623c08cbfa fix: removed semi-colon from regex (#37881) 2019-12-07 15:02:42 -05:00
Waldo Luis Ribeiro
8af54eb272 fix(curriculum): Technical language correction (#37812) 
Technically, the prototype is not cloned; it is merely referenced.
 2019-12-04 21:01:49 +00:00
Randell Dawson
dd2fb28ee0 fix: make tests more robust (#37830) 2019-12-02 18:42:32 -05:00
Randell Dawson
a68e3ef39d fix: change rating to ratings (#37863) 2019-12-02 17:25:11 -05:00
Randell Dawson
7454719334 fix(curriculum): Improved Use Recursion to Create a Countdown challenge (#37548) 
* fix: improved recursive challenge

* fix: rewording of two challenges

* fix: add code tags

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-12-02 17:58:07 +01:00
Tom
da99033b77 fix: sum all primes description (#37750) 
* fix: sum all primes description

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/sum-all-primes.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-11-30 16:33:37 -06:00
Tim dinia
c331b12413 fix(curriculum): correct typo in nest one array within another array challenge instruction (#37851) 2019-11-29 10:07:51 +01:00
Randell Dawson
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761) 
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-27 11:57:38 +01:00
Randell Dawson
b7949087e3 fix(curriculum): Improve verbiage and add examples to the map, filter, and reduce challenges (#37709) 
* fix: improve verbiage and add examples to challenges

* fix: condensed map method wording

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: remove leading space

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened reduce challenge verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shorten verbiage related to reduce 2nd parameter

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added comma

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened filter verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix; added comma

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: improved verbiage of map method

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: shortened reduce verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: correct map method verbiage

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: added word array

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: added missing comma

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: changed u to sumOfAges

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: created one sentence out of many

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* fix: changed to on each iteration

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* fix: fixed verbiage in filter and map challenges
 2019-11-27 07:33:09 +05:30
Randell Dawson
ba415184f6 fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce (#37829) 
* fix: simplify challenge without using reduce

* fix: prevent user from adding new elements to sum to 10

* fix:  add from

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
 2019-11-26 15:14:44 -05:00
Randell Dawson
98bb2c1085 fix: added new test case to prevent invalid regex (#37769) 2019-11-25 20:25:24 -05:00
Kiara Barias
c1b3588e59 Basic JS challenge: use-prototype-properties link added (#37802) 
* Update use-prototype-properties-to-reduce-duplicate-code.english.md

* Update use-prototype-properties-to-reduce-duplicate-code.english.md
 2019-11-25 13:02:21 -06:00
Divyanshu
a987245e18 Added new test cases and corrected the solution for positive and negative lookahead for ensuring that strings beginning with numbers are not accepted (#37485) 
* Added new test case '8pass99' for positive and negative lookahead

* Changed the pwRegex to reflect the new solution

* Updated the pwRegex to reflect the latest solution as on forum

* Added another test case to catch "/^(?=\w{6,})(?=\D*\d{2})/" solution
 2019-11-24 17:11:20 -05:00
Waldo Luis Ribeiro
deb24f77b6 fix(curriculum): English editing (#37814) 
* fix(curriculum): English editing

* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-class-syntax-to-define-a-constructor-function.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* Update use-class-syntax-to-define-a-constructor-function.english.md
 2019-11-24 16:38:30 -05:00
Randell Dawson
dc1b59070e fix: use arrow function syntax (#37818) 2019-11-24 02:37:11 -05:00
Waldo Luis Ribeiro
0c22313760 fix(curriculum): English editing (#37815) 
* fix(curriculum): English editing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-getters-and-setters-to-control-access-to-an-object.english.md

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
 2019-11-23 18:37:36 -05:00
Waldo Luis Ribeiro
70f736fe07 fix(curriculum): English editing (#37816) 2019-11-23 17:28:56 -05:00
Waldo Luis Ribeiro
5ea745d61f fix(curriculum): English punctuation correction (#37811) 2019-11-22 06:35:10 -08:00
Waldo Luis Ribeiro
1fc71e6969 Update create-a-basic-javascript-object.english.md (#37810) 
small spelling correction (everyday -> every day)
 2019-11-22 06:34:34 -08:00
Mo Zargham
437ba8b103 fix(curriculum): Read-search-ask link now point to correct url as noted in the issue (#37753) 
* fix: broken Read-search-ask link now point to correct url

* fix: changed link to original forum link with more views

* fix: changed http links to correct version

* fix: link in help modal
 2019-11-19 19:54:48 -05:00
Marco Valero
fc1a923dd5 Made description of logical operator under "or operator" challenge a little more intuitive. (#37772) 
* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md

* Update comparisons-with-the-logical-or-operator.english.md
 2019-11-16 21:30:52 -05:00
Kiara Barias
c4dc0b297f Switch statement example updated (#37757) 
* Switch statement example updated

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update switch-statements.english.md example

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2019-11-14 12:07:08 -08:00
allison-strandberg
2c5453e3bd Clarify instructions (#37735) 
Closes #37734
 2019-11-11 16:48:51 +01:00