Commit Graph

1433 Commits

Author SHA1 Message Date
Bernardo Sequeira
af71ad2f36 Fixed Automatic Translation of JS Keywords (#37530) 2019-11-04 12:30:00 -05:00
Bernardo Sequeira
250a3727a8 Fixed automatic translation of JS Keywords (#37529) 2019-11-04 11:35:53 -05:00
danielrs975
8389ec1139 Change all ocurrences of the word "matriz" for "arreglo" (#36975)
* Update implement-merge-sort.spanish.md

Change the text "matriz" by "arreglo" that is more accurated

* Change "ordenada" for "ordenado"
2019-11-04 11:24:36 -05:00
Roberto Ruccia
36de803902 Fix link in use-proptypes-to-define-the-props-you-expect.english.md (#37665)
* Fix link in use-proptypes-to-define-the-props-you-expect.english.md

* Add a blank line before Note line
2019-11-01 20:22:19 -05:00
mariorguez
4d3aebb7f7 docs: fix Spanish description mixing inline term (#37273)
The Spanish description became difficult to understand due to unnecessary translations of code words (inline, button, etc.).
The final statement for the challenge was also half translated, when it should remain in English to match the tests.
2019-11-01 19:14:15 +01:00
melascuco
c957f5d4f2 Improve challenge description in Spanish (#37040)
Rephrase the challenge description to make it more understandable in Spanish, due to false friends and words order.
2019-11-01 19:06:26 +01:00
Beau Carnes
28575e9877 Add updated Scrimba link to Word Blank challenge (#37630) 2019-10-31 11:37:26 -05:00
Luis Ignacio Collantes
7d119b67dd Fix grammar and edit the DELETE Request's name (#36951) 2019-10-31 11:24:45 +01:00
lasjorg
316d56ba11 fix(challenge): use offsetHeight to get height value (#36995) 2019-10-27 19:02:53 -04:00
Andres Arrieta
b9ba5c02a8 small grammatical correction (#36931)
changed the phrase ¨Rellene el código del <code>incrementer</code> función...¨to Rellene el código de la función <code>incrementer...</code> as it was grammatically incorrect
2019-10-27 22:38:20 +01:00
nico-alvarez-eu
3059380ce0 Update change-text-inside-an-element-using-jquery.spanish.md (#36863) 2019-10-27 22:32:35 +01:00
SomeDer
bfa5c26288 fix: use dfn instead of code tag (#36640)
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
2019-10-27 12:45:37 -04:00
Rajat Hans
0551a6a57f Word change in responsive design principles English (#37559)
* Word change in responsive design principles

* Word change in responsive design principles
2019-10-26 16:57:20 -04:00
Ahmad Shahzad
9db88a0d7c Fixed a typo in Specify How Fonts Degrade lesson. (#37567)
* Fixed a typo in Specify How Fonts Degrade.

'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.

Instead of "'-->!'.", it should be "'-->'."

* Made text wording consistent for the test instructions.

* Changed "To begin with," to "To begin," and fixed a minor typo.

If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.

Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
2019-10-26 16:55:10 -04:00
Omar Dabour
b59f72961f Fix Typo (#37557) 2019-10-26 16:48:06 -04:00
csteacher1
1a019f952b Added hyphen to "coopted" on Line 17 (#37468)
* Added hyphen to "coopted" on Line 17

Added a hyphen to the word"coopted" to correct it to "co-opted" on Line 17.

* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-10-25 13:47:05 -05:00
burrowsdt
dd8168133f Added escape characters to the javascript comment curriculum (#37518) 2019-10-25 13:41:42 -05:00
gmal1
94635dcc0b Fix incorrect spelling of BCrypt (#37247)
* Fix incorrect spelling of BCrypt

* Fixed spelling of BCrypt in the Chinese, Portuguese, and Spanish versions of the challenge
2019-10-24 17:39:53 +09:00
Ambar Mutha
bcef08424c add comment explaining back-end challenges don't need a solution (#37111)
* add solution to a challenge

add solution to the challenge: add-a-description-to-your-package-json

* add comment to all backend challenges
The comment expllains that these challenges don't need a solution.
2019-10-24 13:38:13 +09:00
Matheus Genteluci
06ea9a5e21 feat: Add solution to Portuguese challenges (#37161)
* feat: Add solution to use the some method

* feat: Add 4 solutions

* fix: remove broken messages from asserts
2019-10-24 12:38:10 +09:00
mrugesh
9612c5ba74 fix: HSTS test in Infosec curriculum (#37469)
Co-authored-by: Wocanilo <daniel.sese@wuolah.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-10-23 21:35:34 +05:30
Randell Dawson
76b9525a54 fix: added forumTopicId to recently added Rosetta Code challen… (#37479) 2019-10-23 21:34:34 +05:30
Chayanon Tonsai
8b082995b5 Change test method from string.test(regex) to regex.test(string) (#37458) 2019-10-23 09:32:17 -05:00
Bhanu Pratap Singh Rathore
ca63f90070 feat(interview-prep): Converting and transfering Rosetta problems (#35770)
* feat(interview-prep): Converting and transfering Rosetta problems
2019-10-23 23:23:50 +09:00
Tom
69d4d4fe2f fix: recursion test (#37419)
* fix(challenge): recursion test

* fix(challenge): replace regex s flag with g
2019-10-23 00:18:40 +05:30
shrobbins
a13bb1b96f fix: missing semi-colon (#37454) 2019-10-21 20:50:51 -04:00
gmal1
174c6f5c68 Make corrections in the Tests section, fix inconsistent spelling (#37246) 2019-10-20 09:27:01 +05:30
jasonranney
f0c1d3a759 change "therefor" to "therefore" to be grammatically correct (#37297) 2019-10-16 11:41:11 -04:00
Kris Koishigawa
26eacf6f47 fix: Change project URL to a working fCC example project 2019-10-15 00:45:50 +09:00
Ambar Mutha
5dce06fccb add comment explaining no need for solutions (#37227) 2019-10-14 11:30:42 -04:00
Kristofer Koishigawa
71fbf2b658 fix(challenges): Update stock price checker sample project URL and add proxy info (#36801)
* fix(challenges): Updated sample project URL, added information about a proxy for stock price information, and tweaked the English test text slightly
2019-10-15 00:04:32 +09:00
mariorguez
372cba1c4c docs: fix unnecessary translation of strong tag (#37223)
When translating to Spanish, the tag itself doesn't have to be translated, to avoid confusion. So, strong should be kept "strong" and not "fuerte".
2019-10-11 16:38:32 -07:00
mrugesh
06b950fdae chore: cleanup old assets from curriculum (#37164) 2019-10-10 00:06:21 -07:00
Luis Ignacio Collantes
99c86be86b Fixed error in traduction of "Node" (#37120) 2019-10-09 21:04:00 +01:00
Johnny Zabala
e9bbcc55cd test rendered output instead of state in react write a simple counter challenge (#36791) 2019-10-09 09:52:41 -05:00
Irina Serdiuk
ac1d0a6f78 translation fix (#37073) 2019-10-09 07:51:36 -07:00
Kris Koishigawa
74778c1af8 fix: Updated all Glitch URLs used to import/remix a GitHub repo 2019-10-08 11:04:30 -07:00
nemogoc
23a3287d8f update test wording for undefined fn returns (#36804)
* update test wording for undefined fn returns, bring code out of after test section and check that the function does what it says it does (rather than just checking the result), update seed, example, and solution
2019-10-08 19:16:36 +09:00
Oliver Eyton-Williams
2066ed674b fix: make challenge test errors more informative (#37020) 2019-10-04 03:16:30 -07:00
CubeSky
7128eb0211 Added solution to "01-Responsive Web design" challenge (#36972) 2019-10-04 12:12:27 +07:00
CubeSky
16e72aa393 Added solution to "Responsive Web design" challenge (#36970) 2019-10-04 11:36:11 +07:00
CubeSky
40e6ddca31 Added solution to "01-Responsive Web design" challenge (#36971) 2019-10-03 22:38:49 +07:00
CubeSky
3099f303ed Added solution to "01-Responsive Web design" challenge (#36968) 2019-10-03 21:11:38 +07:00
Randell Dawson
8225ce7572 fix: added 3 new tests to mutations challenge (#36857) 2019-09-30 16:33:57 -04:00
Oliver Eyton-Williams
9c2f1ffd82 refactor: combine slug utils into one module 2019-09-26 22:15:27 +05:30
Tom
52bd3a65de fix: balanced-brackets-tests (#36807) 2019-09-25 11:39:11 +02:00
SomeDer
5de58ad98d fix(curriculum): use function form of this.setState (#36623)
* Fix solution

* Update description

* Add test for this.setState function syntax

* Update toggle element instructions

* Fix simple-counter solutions

* Fix bind-this challenge seed and solution

* Fix && challenge seed and solution

* Fix ternary challenge seed and solution

* Use the function form -> Pass a function

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Mention "passing a function" instead of "alternative form"

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Rephrase explanation

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify why functions should be used

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Improve tests

* Fix \s escaping in []

* Improve regex

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add test for `this`

* Use block code

* Update bind-this challenge

* Fix last part of instructions

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-09-24 08:12:50 -07:00
Ent Wickler
d08f009bd1 fix(curriculum): Add tests for setter, getter and setting a temperature (es6 tests) (#36620)
* add testing for setter, getter and setting a temperature according to some of feedbacks into the issues 17403

* bugfix: temperature is not a function
2019-09-23 17:13:32 +02:00
Oliver Eyton-Williams
3a0cd56ad3 fix(curriculum): Add and modify tests to catch bad code. (#36429) 2019-09-20 09:28:50 -07:00
sybiljasmine
5d946f3d77 valid factorial number update under the tests (#36792)
* valid factorial number update under the tests

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Update curriculum/challenges/english/08-coding-interview-prep/rosetta-code/factorial.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

* Removed redundant array in the tests
2019-09-19 08:52:09 -07:00