gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,266 Commits 9 Branches 0 Tags
b5ed2619eb09cd9c0f18fc6ab59f46e5fd1cc79e
Commit Graph

95 Commits

Author SHA1 Message Date
gikf
8cc172d9e8 fix(learn): rework Rosetta Code Harshad or Niven series (#41554) 
* fix: rework challenge to use argument in function

* fix: remove unnecessary link

* fix: improve wording

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-26 02:28:09 +05:30
Laurent Labine
8e22962523 fix(curriculum) replace single-line blocks with multi-line blocks for… (#41526) 
* fix(curriculum) replace single-line blocks with multi-line blocks for issue 51418

Data visualization and Coding Interview Prep portions.

* Update execute-a-markov-algorithm.md

Implemented as inline code blocks as discussed

* Adding missed blocks

* Last file added
 2021-03-25 07:43:13 -07:00
gikf
b8ddfc08b3 fix(learn): rework Project Euler 63 (#41425) 
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct function call in seed code

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: improve instructions wording

* fix: correct typo

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
 2021-03-16 18:41:47 -05:00
Randell Dawson
d2f4b70ea6 fix: remove end of line chars after code blocks (#41498) 2021-03-16 07:49:43 -07:00
gikf
9669e39b85 fix(learn): make tests and test descriptions more explicit (#41281) 
* fix: make tests and descriptions more explicit

* fix: add example to description

* fix: replace pre tags with markdown

* fix: move test data to seed code for convenience

* fix: correct grammar from review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Revert "fix: move test data to seed code for convenience"

This reverts commit 7a9c4723d6.

* fix: small corrections

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
 2021-03-12 07:29:03 -08:00
Luca
5589c37804 fix(learn): remove wrong spaces and make quotes consistent (#41434) 
* Remove spaces that are not meant to be there (L37, L134, L156) Makes quotes consistent (L61)

Remove spaces that are not meant to be there (L37, L134, L156)
Makes quotes consistent (L61)

* Consistent spacing after commas

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-03-11 07:19:07 -08:00
Caden Parker
6b9aeff09e fix(learn): Rework Euler Problem 461 (#41333) 
* Made instructions more clear + Corrected test cases

* Added highlight for return values

* Adjusted challenge description

* Rework

* Fixed minor linting error

* Address PR Comments

* Adjusted wording in description
 2021-03-10 08:14:27 -07:00
Caden Parker
d8e6d8dc46 fix(learn): Rework Euler Problem 182 (#41337) 
* Rework Euler Problem 182

* Reordered tests

* Fixes for formatting
 2021-03-10 15:55:52 +01:00
Caden Parker
256e7f416d fix(learn): Added more robust logic for the remove test case in Create A Hash Table (#41283) 
* Added extra test cases for hashtable.remove

* Minor Change

* Adjusted tests to use user created add function / Modified description

* Made test case description much more clear

* Changed instructions to be more clear

* Minor change to instructions

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-09 12:45:20 -06:00
Nicholas Carrigan (he/him)
c5bcebc724 fix(learn): revert backslash change (#41382) 
* fix(learn): revert backslash change

Crowdin resolved the issue with backslashes escaping backtics in
the markdown parser, so this reverts the workaround we implemented
for that bug.

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/s-expressions.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-09 10:13:27 -06:00
gikf
bd02249a23 fix(learn): rework Rosetta Code Count the Coins (#41282) 
* fix: rework challenge to use argument in function

* fix: use better wording

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-03-09 08:34:10 -06:00
gikf
93495ef6db fix(learn): correct tests description (#41280) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-09 11:48:12 +05:30
gikf
5332628e6d fix(learn): rework Rosetta Code Hailstone Sequence (#41279) 
* fix: rework challenge to use argument in function

* fix: change leftover html to markdown

* Apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* remove leftovers

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-03-04 13:28:47 -08:00
lusc
8a5711dda7 Fix: remove a colon in rosetta-code/happy-numbers (#41349) 
* Fix: remove a colon in rosetta-code/happy-numbers

Removed a colon that shouldn't be there

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/happy-numbers.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Add inline code tags around all true and falses

https://github.com/freeCodeCamp/freeCodeCamp/pull/41349#discussion_r586700058

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-03-04 09:25:55 -07:00
Andrew Cen
65cc800689 fix: add blank lines on empty seeds (#41348) 2021-03-03 13:14:28 -08:00
Randell Dawson
57f3c80345 fix(learn): Clarify date format expectations for the Date Format challenge (#41327) 
* fix: clarify date format expectations

* chore: apply suggestions from code review

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2021-03-02 15:46:30 -08:00
gikf
219339b2ce fix(learn): rework Project Euler - Problem 58 (#41188) 2021-02-20 12:06:32 +05:30
gikf
f5a905b7c2 fix(learn): unmangle challenge description (#41182) 2021-02-20 12:04:38 +05:30
gikf
70c4d82068 fix(learn): correct test result (#41068) 2021-02-20 12:04:12 +05:30
gikf
c8db838754 fix: correct function call in test description (#40949) 2021-02-20 12:03:54 +05:30
gikf
a91444d3d4 fix: correct function call in test description (#40944) 2021-02-20 12:03:33 +05:30
gikf
762775889e fix: rework Project Euler - Problem 57 (#40926) 
* fix: rework challenge to use argument in function

* fix: add solution

* fix: correct variable name
 2021-02-17 11:58:18 -08:00
gikf
6ae3735979 fix: correct tests descriptions (#40945) 2021-02-10 17:12:12 +05:30
Kim Leung
082b269dce fix(learn): backslashes in description & hint text (#40801) 
Correct example code in description and last hints text to match the last assertion test's actual and expected inputs.  The string input with a single backslash throws an unterminated string constant error (single backslash starts a regex).  No change to last assertion test as it was written correctly with a double backslash and passing as expected.
 2021-02-10 17:10:51 +05:30
gikf
313b345611 fix: correct Rosetta Code Knight's tour solution (#40830) 
* fix: correct answers in tests and descriptions

* fix: replace sample solution for correct one

* fix: missing space

* fix: improve sample solution performance
 2021-02-03 12:43:29 -06:00
Kim Leung
a37d5f5817 fix(learn): add output type verbiage (#40589) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-01 19:41:15 +05:30
Kai-Chin Huang
5503b54f85 fix(learn): update the return Object.values & solution (#40451) 2021-02-01 13:12:54 +05:30
Mainak Debnath
d5ad87d915 fix(learn): put test cases under --seed-- and remove them from the solution (#40755) 
* fix: put test cases under --seed--

* fix: put test cases under --seed--
 2021-01-21 18:26:06 -08:00
Nicholas Carrigan (he/him)
8e62a243bb fix(learn): Update demo links (#40575) 
* fix(learn): Replace demo projects

Replaces the Heroku demo project links with the
.rocks demo projects that @moT01 provided.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(learn): Use correct endpoint

Corrects the API endpoint for the image search
project.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: user stories to align with project + backticks

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2021-01-21 11:09:35 -06:00
Nicholas Carrigan (he/him)
062b1cd424 fix: replace h tags (#40750) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-01-21 13:41:46 +05:30
Kim Leung
e57f32438c fix(learn): correct LCG equation in description (#40615) 
* fix(learn): correct LCG equation in description

* Update curriculum/challenges/english/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/chinese/10-coding-interview-prep/rosetta-code/linear-congruential-generator.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Revert LCG equation in Chinese file

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
 2021-01-20 22:05:37 -08:00
Randell Dawson
dd4c7e0097 fix(learn): Update text as code for vector-dot-product (#40460) 
* fix: implemented suggestted changes

* fix: correct last test expected return value

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: remove slash

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: add test to return null if more than 2 vectors

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: added correct solution

* fix: removed extra brackets

Co-authored-by: Yuval Levental <yhl3051@rit.edu>

Co-authored-by: Lakshya Baghel <lakshyab.1999@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Yuval Levental <yhl3051@rit.edu>
 2021-01-20 21:23:10 -08:00
Ian Turner
fb2e5d81f3 Add line breaks to instructions (#40425) (#40428) 
* feat: add line breaks to instructions  (#40425)

* feat: add punctuation to instructions (#40425)
 2021-01-20 22:19:21 -07:00
Nicholas Carrigan (he/him)
8d8d25e9f2 fix(learn): address escaped backticks (#40717) 
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-01-20 19:01:00 -07:00
Sergey Rufanov
5379b04387 fix(learn): Removed note about commented array from sorting algorithm challenges (#40652) 2021-01-16 12:00:10 -08:00
Jeremy L Thompson
a5840f57a4 Update Description of Stern-Brocot Challenge (#40686) 
* fix: update description of target function

* fix: include note about 1 based indexing
 2021-01-16 12:57:38 -07:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683) 
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
 2021-01-12 19:31:00 -07:00
miyaliu666
9770cd0f81 translated some Chinese curriculum files (#40531) 
* translate task #1 - #4

* add translation of zhang-suen-thinning and markov algorithm

Co-authored-by: S1ngS1ng <liuxing0514@gmail.com>
 2021-01-08 11:59:18 -07:00
Kai-Chin Huang
a1928ba272 Update the return value of values method in create a set class challenge (#40450) 
* fix #40443

* Fix the solution add method
 2020-12-15 18:15:33 -07:00
Oliver Eyton-Williams
0bd52f8bd1 Feat: add new Markdown parser (#39800) 
and change all the challenges to new `md` format.
 2020-11-27 10:02:05 -08:00
ngschaider
6c5304980d fix(learn): type checking and additional test for isBalanced binary search tree (#40323) 
* Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.md

* fixed binary search tree values for balanced tree test

* Apply suggestions from code review

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
 2020-11-26 22:33:45 -06:00
Randell Dawson
b47487b8b2 fix(learn): Change Node project descriptions to all use same template (#40266) 
* fix/change-node-project-descriptions-to-all-use-same-template

* fix: use correct boilerplate

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add url to link text

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add _blank for target attribute

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: add missing single quote

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* fix: remove extra lines

* fix: improved wording of description

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: move sentence to previous paragraph

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* fix: move sentence to previous paragraph

* fix: move sentence to previous paragraph

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-11-20 12:02:31 -08:00
Farhan Ullah
9ba94e38b4 fix(learn): isSorted returning true on empty arrays which passes the test (#40192) 
* bug-fix: isSorted returning true on empty arrays

* sorted order test improvements
 2020-11-20 09:51:59 -08:00
Randell Dawson
2c9a900353 fix: added more values to list to improve tests (#40256) 2020-11-18 09:38:26 +00:00
Ty Mick
f2236983a2 Strengthen test for reassigning node reference (#40133) 2020-11-04 09:46:18 -08:00
Ty Mick
5f956e9a16 Strengthen isBinarySearchTree test (#39982) 2020-10-26 13:30:46 -05:00
Adrian Muntean
0ae1df30c7 fix: add info for problem 54 - project Euler (#40057) 
* fix: add info for problem 54 - project Euler

* update text
 2020-10-22 11:59:49 -07:00
sreekumar menon
dec4b2180f Scalar addition issue on Element-wise operations (#40013) 
* Scalar addition issue on Element-wise operations

* remove chinese from PR

Co-authored-by: Sreekumar Menon <sreekumar@roofstock.com>
 2020-10-19 11:29:23 -07:00
Bobby BuffaloBoy
71659b7c94 fix(learn): Date corrected the example description from Sunday, to Friday, in the date-format Rosetta Code Challenge (English) (#39998) 2020-10-17 23:01:18 +02:00
Ke Cleveland
13e7251ed9 fix(learn): Update findXmasSunday function arguments from (2008,2121) to (1970, 2017) to match expected return. (#39996) 
Co-authored-by: keiveland <keivelanddev@gmail.com>
 2020-10-17 22:46:03 +02:00