Commit Graph

16 Commits

Author SHA1 Message Date
Nicholas Carrigan (he/him)
b9d08f2fea feat: locale specific help posts (#43290) 2021-08-25 21:43:40 +05:30
Shaun Hamilton
59f17f237b refactor: files{} -> challengeFiles[], and key -> fileKey (#43023)
* fix(client): fix client

* fix propType and add comment

* revert user.json prettification

* slight type refactor and payload correction

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* update ChallengeFile type imports

* add cypress test for code-storage

* update test and storage epic

* fix Shaun's tired brain's logic

* refactor with suggestions

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* update codeReset

* increate cypress timeout because firefox is slow

* remove unused import to make linter happy

* use focus on editor

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* use more specific seletor for cypress editor test

* account for silly null challengeFiles

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-08-12 20:48:28 +02:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Nicholas Carrigan (he/him)
821aee9687 feat: i18n for help text (#42235)
Add internationalisation capabilities for the pre-filled text in
the Ask for Help forum post.
2021-05-24 19:59:35 +02:00
renovate[bot]
21dd80c47a chore(deps): update dependency prettier to v2.3.0 (#42074)
* chore(deps): update dependency prettier to v2.3.0

* chore: apply formating per prettier

* fix: correctly disable import/no-unresolved

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Mrugesh Mohapatra <hi@mrugesh.dev>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-05-10 08:48:49 -07:00
Shaun Hamilton
fd955635e5 feat(client): transform app url to editor (#41858) 2021-04-20 14:47:42 -07:00
gracewest333
90fe009374 feat(client): add placeholder text to forum posts (#41849) 2021-04-18 19:40:26 +03:00
Mrugesh Mohapatra
ad9b1f89d8 fix(api, client): update Gatsby, webpack & related things (#41452)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-03-25 12:13:43 -07:00
Mrugesh Mohapatra
6c91f81b0e chore(deps): upgrade eslint, prettier & related packages 2021-03-11 12:19:42 +05:30
Shaun Hamilton
0bdff7c2ed fix(client): undent dents caused by dedent (#41052)
* fix(client): undent dents caused by dedent

* remove one more unnecessary indent caused by dedent

* remove dedent

* add: dedent with no indentation

* correct line breaks
2021-02-11 12:12:51 +05:30
Shaun Hamilton
98ff6823e2 feat(learn): add backend solution url to help post (#40950)
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2021-02-09 11:23:10 +05:30
Oliver Eyton-Williams
e4a9b2988c feat: update Ask for help (#40114)
* feat: get helpCategory from frontmatter

* DEBUG: sets all the projects to JavaScript

This is just so the tests pass, it'll need to go.

* fix: updated helpCategoryMap categories

* fix: added Python to helpCategory frontmatter key

Co-authored-by: Randell Dawson <rdawson@onepathtech.com>
2020-10-30 14:10:34 -05:00
Tom
5ca2d2467a fix: make help button use subforum topics (#37741)
* fix: make help button use subforum topics

* fix: add test to check that block exists

Co-authored-by: ojeytonwilliams <ojeytonwilliams@gmail.com>

* fix: improve error message

* Update curriculum/test/test-challenges.js

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-11-15 23:03:08 +05:30
mrugesh
a53a4ac303 fix(client): forum help and hints (#36625)
* fix(client): add warning on exceeding forum post length limit

Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>

* fix: corrected guide url for backend challenges and projects

* fix: moved  getGuideUrl to  utils

* fix: added forumTopicId to ChallengeNode PropTypes

* fix: conolidated helpers and add base url to env.json

* fix: made use template literals

* tests: created unit tests for getGuideUrl

* fix: add characters which will be encoded

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: use encoded version of title

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: encode title

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-08-28 21:55:56 +05:30
lionel-rowe
b6a68d8bdf fix: swap out raw HTML syntax for semantic/idiomatic markdown (#35917)
Per this: https://www.freecodecamp.org/forum/t/forum-suggestion-unformatted-code-warning/134857/24

`<code>` tags are not the semantically/idiomatically correct way to format code on Discourse. For example, `<code><span></span></code>` renders as that exact HTML, when the intention was almost certainly to render `<code>&lt;span&gt;&lt;/span&gt;</code>` instead.
2019-06-09 05:41:40 +05:30
Bouncey
5b254f3ad6 chore(learn): Merge learn in to the client app 2018-09-30 12:42:40 +01:00