77 Commits

Author SHA1 Message Date
Nathan Hannig
2adc516d96 fix(challenges): adding negative integer to challenge to improve tests (#211) 2018-08-22 19:58:23 +09:00
Josh Alling
1a4f6a8d83 fix(challenges): fix confusing destructuring es6 challenge
ISSUES CLOSED: #213
2018-08-21 20:02:30 +09:00
Hadrien Allemon
7707b180bb fix(challenges): insufficient objectives for javascript_algorithm/es6/19
The user was able to pass the challenge without building a proper constructor for the class. The new
objective ensure a constructor was built.
2018-08-02 11:29:12 +09:00
John Kennedy
fd8c9e469c fix(challenges): fixes escaping of
and test error message
2018-07-31 09:23:04 +09:00
John Kennedy
b8d004e3f2 fix(challenges): fix third test for template literals
replaced the overly long and complex regex which tests for use of template literals with a much
simpler one that has the same effect

ISSUES CLOSED: #135
2018-07-31 09:23:04 +09:00
John Kennedy
57dab6d81f fix(challenges): allows single quotes 2018-07-25 18:47:49 +09:00
John Kennedy
99f4b9f1ff fix(challenges): improve template literal challenge instructions 2018-07-20 08:17:26 +09:00
Pushpender Maan
667dba93b4 fix(challenges): fix broken tests - es6_declarative_function 2018-07-16 17:48:07 +09:00
Pushpender Maan
8b99b8b56f fix(challenges): fix regex to allow redundant space characters 2018-07-13 15:53:58 +09:00
Pushpender Maan
f4d598f060 fix(challenges): fix regex (es6 : import vs require)
ISSUES CLOSED: #108
2018-07-08 21:44:13 +09:00
Ankit Tiwari
857b3e9a88 fix(challenges): update RegEx for testcase in es6 challenge 2018-07-01 19:59:32 +09:00
CharmedSatyr
9e9bc276aa fix(challenges): add comments to getter/setter instructions codeblock
ISSUES CLOSED: #92
2018-07-01 19:50:47 +09:00
Guy Even
66d84631ca fix(challenges): fixed RegEx for template literals javascript challenge
ISSUES CLOSED: #65
2018-06-30 19:31:01 +09:00
mrugesh mohapatra
1d3e0764fb fix(challenge): syntax error in sample code snippet 2018-06-30 06:55:40 +05:30
Rob Anthony
46fcf434cd fix(challenges): change comment to make it clearer (#72) 2018-06-30 01:03:16 +05:30
Kristofer Koishigawa
4b1c5ebc7a fix(challenges): change test for template literals challenge (#37)
The original test was too rigid, and many users were forced to use one solution, usually map, to
complete the challenge. The test is changed here to allow for multiple solutions to the problem,
including the use of either single or double quotes when naming a class.

BREAKING CHANGE:
None
2018-06-29 23:47:58 +05:30
Thomas Lombart
cf9336a3b1 fix(challenges): Correct a regex in ES6 read-only challenge (#41)
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
2018-06-24 14:41:31 +01:00
Niraj Nandish
16ff132f44 fix: typo errors (#23)
* Typo errors

Unnecessary break

Grammatical error

* remove an unnecessary <br>
2018-06-21 18:48:04 +05:30
Tom
d31e0a3a24 fix: blockquote-formatting-in-challenges (#17590) 2018-06-19 17:53:24 +05:30
Vimal Raghubir
9e84a54d72 fix: rename incorrect variable name (#17538)
* fix: rename incorrect variable name

* Fix: Bad variable naming
2018-06-13 13:02:11 +05:30
Todd Bradshaw
8d57e1607f fixed line breaks in 'Prevent Object Mutation' challenge (#17547)
* fix(seed):line breaks in 'Prevent Object Mutation' challenge #17541

* Update es6.json
2018-06-13 13:02:11 +05:30
Vimal Raghubir
0874eca77c fix: added new test and fixed incorrect variable (#17471)
* Added new test and fixed incorrect variable

* Fix: Incorrect sentences and descriptions

* Update es6.json
2018-06-11 18:22:32 +05:30
Stuart Taylor
4e645a5ff6 Package: Validate challenges on test (#17216)
This PR allows us to validate the schema during test.

It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
2018-05-22 18:13:14 +05:30
Stuart Taylor
ee66d84ccb feat(package): Initial Curriculum separation (#17174)
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30
Nicholas Nadeau, P.Eng., AVS
a8efeb50d7 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Alex Chaffee
52ca2b9ad6 feat(seed): reformat seed/challenges JSON via repack script 2018-04-03 19:53:44 +05:30
Paul Rail
181949b2c7 fix(seed): Correct typos in es6.json (#16972) 2018-03-28 20:01:52 +05:30
Nguyen Quoc Bao
0b9b67169c fix(seed): Make element naming optional (#16926)
Closes #16905
Closes #15224
2018-03-23 14:12:28 -04:00
Ahmad Abdolsaheb
d987ce416d fix(seed): Chall seed and test are modified to allow better t (#16928)
es6.json seed file changed

Closes #16356
2018-03-23 13:41:44 -04:00
Murat Doğan
0fa5296f87 fix(challange): Redundant note has been removed (#16895) 2018-03-14 17:14:14 +05:30
Jason Kao
102a233e69 feat(seed): Added ES6's strict mode to a lesson and made verbiage clearer (#16652) 2018-02-08 18:16:18 +05:30
Neenad Ingole
b36ba2cc99 fix(seed): Typo correction to es6.json in javascript challeng (#16589)
Closes #16584
2018-01-28 13:18:09 +05:30
Sagar Jha
6307c0f04b fix(seed): Change variable name from array to args (#16472)
Changed variable name from array to args. It will validate the last validation. Particular variable name is required but it is not mentioned in description.

Closes #16351
2018-01-18 00:45:19 +05:30
Dylan
5ba1da5e2c fix(challenges): Clarified instructions on es6 let challenge (#15983) 2018-01-04 10:58:30 +00:00
Nick Karnik
ab08420ec2 fix(challenges): Fixed import export related challenges
Closes #16235
2017-12-29 18:38:22 -08:00
Ethan Arrowood
524918fc84 Refactor ES6 Challenges (#16262)
* fix(challenges): Add function scope of use strict

Refactored first 13 challenges with function scope `"use strict";`
syntax

Closes #16254

fix(challenges): Refactor ES6 challenges

Refactored ES6 challenges up to 22 to use function scope `"use strict";`

test(challenges): QA ES6 Challenges

Refactored es6 challenges getting tested and QA'd

fix(challenges): QA remaining ES6 challenges

* refactor(challenges): Quick edit for ES6 challenges

More changes to come. This commit solves issues addressed by Quincy

* refactor(challenges): ES6 Textual refactor

Textual refactor. Improved challenge test messages to be more
explanatory
2017-12-22 22:17:05 -06:00
Ethan Arrowood
ef9e2f498e test(challenges): Test ES6 challenge (#16201)
* test(challenges): Test ES6 challenge

Added tests to 3rd ES6 challenge

* test(challenges): ES6 challenges

* test(challenges): ES6 chall c11-c15

* test(challenges): ES6 chall c16-c20

* test(challenges): ES6 chall c21-c27

* test(challenges): Refactor ES6 challenges

Update tests to use getUserInput. Remove test for arrow function use

Closes #16207

* test(challenges): Fix falsey case

Add proper getUserInput syntax for !code.match tests

Closes #16207

* test(challenges): QA ES6 Challenges

QA and edit for ES6 challenges 1 - 18

Closes #16207
2017-12-21 14:38:28 -06:00
Dylan
3bf076bed8 fix test on es6 export default (#15627) 2017-09-04 10:16:50 +02:00
Beau Carnes
a9bbfec4d4 fix(seed): Fix typos 2017-09-01 19:15:29 -07:00
Darth Skywalker
fd42d1eb5a feat(challenge): Added Object.freeze challenge wrt #15746 2017-08-13 00:19:13 +05:30
Eric Leung
5522c64172 fix: Clarify mutate array with const challenge (#15745)
Instructions for Mutate an Array Declared with const was unclear and
included unnecessary learning materials. This commit aims to clarify the
instructions for what the challenge requires, and also add in missing
challenge tests.

Closes #14832
2017-08-11 15:06:35 -05:00
Dylan
190fa94c54 Merge pull request #15098 from charlesBak/fix/arrow-function-with-param
Add test to Arrow functions with input parameters
2017-07-16 21:21:27 -05:00
Eric Leung
72deeb0ae5 Merge pull request #14958 from huyenltnguyen/fix/challenge-description-typo
fix challenge description typo
2017-05-29 19:04:04 -07:00
Milo Hartsoe
98d75156f4 Add tests to es6 challenge Write Higher Order Arrow Functions. Doesn't have es6 syntax tests.
Comments out function and arrow tests that didn't work and fixes formatting issues.
2017-05-29 16:30:11 -04:00
Charles Bakar
f53e759e23 Add test to Arrow functions with input parameters 2017-05-28 18:50:29 +02:00
Huyen Nguyen
573777d652 fix challenge description typo 2017-05-20 04:24:20 +07:00
David Flick
47c0a826f6 fix(seed) Typo in Use export to Reuse a Code Block (#14857) 2017-05-14 22:49:40 +05:30
Jia Kim
09604b58a7 Fixed instructions for ES6: Set Default Parameters 2017-05-11 20:49:45 -04:00
Siddhant Chadha
bf558c4a4f fix typo in Mutate an Array Declared with const 2017-04-22 19:57:18 +05:30
techstonia
2ed17bde15 Add tests for mutate const array 2017-04-16 12:51:24 +03:00