Oliver Eyton-Williams
f834a9899a
fix(challenges): reword test text and improve test accuracy
2018-09-02 19:35:00 +09:00
Lallo Vigil
68daaf73d9
fix(challenges): replaced em tags with code tags
...
Em tags were showing in console, so I replaced them.
ISSUES CLOSED : #18048
2018-08-30 19:21:52 +09:00
HadrienAllemon
72c2407190
fix(challenges): allow user to comment out undesired code
2018-08-30 18:06:13 +09:00
Niraj Nandish
c50cc4eb1d
fix(challenges): missing space in code example
2018-08-26 13:47:59 +09:00
Strahinja Mitrovic
cb21e59f7a
fix(challenges): fix #17155
...
i've added a test for if else statements curly braces to ensure that every condition has to have
both opening and closing curly braces.
I've also made changes that were by scissorsneedfood.
ISSUES CLOSED : #17155
2018-08-25 16:41:52 +09:00
pom421
6058da3725
fix(challenges): fix regex in a JS challenge ( #257 )
2018-08-25 16:29:12 +09:00
Nathan Hannig
2adc516d96
fix(challenges): adding negative integer to challenge to improve tests ( #211 )
2018-08-22 19:58:23 +09:00
Josh Alling
1a4f6a8d83
fix(challenges): fix confusing destructuring es6 challenge
...
ISSUES CLOSED : #213
2018-08-21 20:02:30 +09:00
Niraj Nandish
0bf8d3218f
fix(challenges): check for shorthand character in regex ( #238 )
2018-08-21 19:48:49 +09:00
Niraj Nandish
ded4705fac
fix(challenges): fixed tests to check for pre operators
...
Increment and decrement a number challenge
will now check for post-increment
ISSUES CLOSED : #199
2018-08-18 19:19:44 +02:00
Josh Alling
e044de4230
fix(challenges): add test to lookahead regex challenge
...
ISSUES CLOSED : #209
2018-08-17 08:15:38 +02:00
Tomer Ben Rachel
31957a45e2
fix(challenges): fixed typo in algorithms and ds
2018-08-14 18:51:30 -07:00
Rob Anthony
296cf44f57
fix(challenges): add test to check user is using \W in Regex
...
Add test to make sure user is using \W and not ^\w
2018-08-14 10:53:17 -07:00
Hadrien Allemon
7707b180bb
fix(challenges): insufficient objectives for javascript_algorithm/es6/19
...
The user was able to pass the challenge without building a proper constructor for the class. The new
objective ensure a constructor was built.
2018-08-02 11:29:12 +09:00
John Kennedy
fd8c9e469c
fix(challenges): fixes escaping of
...
and test error message
2018-07-31 09:23:04 +09:00
John Kennedy
b8d004e3f2
fix(challenges): fix third test for template literals
...
replaced the overly long and complex regex which tests for use of template literals with a much
simpler one that has the same effect
ISSUES CLOSED : #135
2018-07-31 09:23:04 +09:00
John Kennedy
57dab6d81f
fix(challenges): allows single quotes
2018-07-25 18:47:49 +09:00
Hadrien Allemon
8286ff9c46
fix(challenges): typo in javascript algorithms/debugging/2
...
In the objectives, the user was asked to log the variable "outputTwice" whereas in the code editor,
no such variable existed. I changed the objectif so that it states to change the variable
"outputTwo" which is the variable found in the content.
2018-07-25 18:45:27 +09:00
Pushpender Maan
5b27dfdeff
fix(challenges): fix typo in "split string into array using split"
2018-07-20 19:40:56 +09:00
John Kennedy
99f4b9f1ff
fix(challenges): improve template literal challenge instructions
2018-07-20 08:17:26 +09:00
Pushpender Maan
667dba93b4
fix(challenges): fix broken tests - es6_declarative_function
2018-07-16 17:48:07 +09:00
Pushpender Maan
8b99b8b56f
fix(challenges): fix regex to allow redundant space characters
2018-07-13 15:53:58 +09:00
Niraj Nandish
de30ac869c
fix(challenges): broken link
...
ISSUES CLOSED : #17823
2018-07-09 18:35:32 +09:00
Pushpender Maan
f4d598f060
fix(challenges): fix regex (es6 : import vs require)
...
ISSUES CLOSED : #108
2018-07-08 21:44:13 +09:00
Ankit Tiwari
857b3e9a88
fix(challenges): update RegEx for testcase in es6 challenge
2018-07-01 19:59:32 +09:00
CharmedSatyr
9e9bc276aa
fix(challenges): add comments to getter/setter instructions codeblock
...
ISSUES CLOSED : #92
2018-07-01 19:50:47 +09:00
Guy Even
66d84631ca
fix(challenges): fixed RegEx for template literals javascript challenge
...
ISSUES CLOSED : #65
2018-06-30 19:31:01 +09:00
mrugesh mohapatra
1d3e0764fb
fix(challenge): syntax error in sample code snippet
2018-06-30 06:55:40 +05:30
Rob Anthony
46fcf434cd
fix(challenges): change comment to make it clearer ( #72 )
2018-06-30 01:03:16 +05:30
Guy Even
ff266972e5
fix(challenges): removed a test in basic javascript challenge ( #76 )
...
removed a test looking for timesFive call and it is not clear from the instrucitons to do so
ISSUES CLOSED : #73
2018-06-30 00:19:47 +05:30
Niraj Nandish
0c0702d6c0
fix(challenges): Typo errors ( #39 )
2018-06-29 23:47:58 +05:30
Matthew Smith
9fa5907da0
fix(challenges): update regular expression that fails ( #56 )
...
* fix(challenges): update regular expression that fails
Changes regular expression in testString to remove negative look behind that is not implemented
across all browsers.
ISSUES CLOSED : #55
* Fixed line spacing
It is definitely something to do with a linter. I re-ran the `npm run commit` in my own environment and watched the line spacing jump. Should probably be checked if it ends up happening to others. However, this should fix it all for this PR!
* Back to `prettier` formatting
Reverting back to pretty formatting from commit.
2018-06-29 23:47:58 +05:30
Guy Even
2375d0c98d
fix(challenges): cherry pick pr 17664 & 17672 from main repo ( #52 )
2018-06-29 23:47:58 +05:30
Guy Even
2b034e267b
fix(challenges): fixed telephone number validator project ( #53 )
...
fixed telephone number validator projects to show example telephone numbers on new lines
ISSUES CLOSED : #47
2018-06-29 23:47:58 +05:30
Kristofer Koishigawa
4b1c5ebc7a
fix(challenges): change test for template literals challenge ( #37 )
...
The original test was too rigid, and many users were forced to use one solution, usually map, to
complete the challenge. The test is changed here to allow for multiple solutions to the problem,
including the use of either single or double quotes when naming a class.
BREAKING CHANGE:
None
2018-06-29 23:47:58 +05:30
Thomas Lombart
cf9336a3b1
fix(challenges): Correct a regex in ES6 read-only challenge ( #41 )
...
The regex testing if the user has entered console.log(SENTENCE); was broken. It has been modified.
2018-06-24 14:41:31 +01:00
John Kennedy
d4cf9deee6
fix: sample code in intro to currying
...
Corrected the code sample that didnt work
Amended uncurried example to better tie in with rest of code making the lesson more cohesive
2018-06-21 18:48:04 +05:30
Niraj Nandish
16ff132f44
fix: typo errors ( #23 )
...
* Typo errors
Unnecessary break
Grammatical error
* remove an unnecessary <br>
2018-06-21 18:48:04 +05:30
Michael Silverman
999c6af639
fix: changes text to bold in the JS Algo and DS ( #20 )
2018-06-21 18:48:04 +05:30
Ankit Tiwari
e1dfe8f43c
fix: Remove an unnecessary line from basic javascript challenge ( #19 )
2018-06-21 18:48:04 +05:30
Tom
d31e0a3a24
fix: blockquote-formatting-in-challenges ( #17590 )
2018-06-19 17:53:24 +05:30
Kristofer Koishigawa
20fac4e2c3
revert: "test(challenges): Corrected expected average value" ( #17568 )
2018-06-14 03:30:04 +05:30
Vimal Raghubir
9e84a54d72
fix: rename incorrect variable name ( #17538 )
...
* fix: rename incorrect variable name
* Fix: Bad variable naming
2018-06-13 13:02:11 +05:30
Matthew Smith
ed5e02d7ae
test(challenges): Corrected expected average value ( #17562 )
...
Modified 8.675 to 8.52 in three places for correct average value
BREAKING CHANGE: n/a
Closes #17561
2018-06-13 13:02:11 +05:30
Todd Bradshaw
8d57e1607f
fixed line breaks in 'Prevent Object Mutation' challenge ( #17547 )
...
* fix(seed):line breaks in 'Prevent Object Mutation' challenge #17541
* Update es6.json
2018-06-13 13:02:11 +05:30
bogadodiegoh
c9f572d271
fix(seed): updated basic javascript URLs for hints ( #17445 )
...
* Updated json file with right url values
* Updated url links after review
* Updated another broken url link after review
2018-06-11 18:22:32 +05:30
Vimal Raghubir
0874eca77c
fix: added new test and fixed incorrect variable ( #17471 )
...
* Added new test and fixed incorrect variable
* Fix: Incorrect sentences and descriptions
* Update es6.json
2018-06-11 18:22:32 +05:30
Rajat Kanti Nandi
2a3369aa6b
Updated basic-javascript.json file for challenge Manipulate arrays with shift; issue: #17235
2018-05-25 19:28:17 +00:00
Stuart Taylor
4e645a5ff6
Package: Validate challenges on test ( #17216 )
...
This PR allows us to validate the schema during test.
It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
2018-05-22 18:13:14 +05:30
Stuart Taylor
ee66d84ccb
feat(package): Initial Curriculum separation ( #17174 )
...
* feat(package): Initial Curriculum separation
* feat(package): Add org scope to package
* chore(ooops): Remove development file
* feat(npm): Add .npmignore
* fix(paths): Fix curriculum paths
* feat(build): Add a build step
* chore(seed): Move package file back to seed
* fix(ignore): Fix .npmIgnore file
* chore(docs): Update README
* chore(seed): Rename coding interview blocks
* fix(seed): Challenge files now fit into learn
* chore(seed): Update seed files for use in learn
* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30