Bhanu Pratap Singh Rathore
79394d141f
feat(interview-prep): Converting and transferring Rosetta problems ( #35487 )
...
* feat(interview-prep): Converting and transferring Rosetta problems
* feat(interview-prep): Fixing challenges
* fix(challenges): Added code tags
* Update knight's-tour.md
Moved text to instructions section and fixed a small typo.
* feat(interview-prep): Update description of Knight's tour
Co-Authored-By: NitronR <bhanur05@gmail.com >
* feat(interview-prep): Update description of Kaprekar numbers
Co-Authored-By: NitronR <bhanur05@gmail.com >
* feat(inteview-prep): Kaprekar numbers description
Added <code> tags.
* fix(interview-prep): Update description Kaprekar Numbers
Co-Authored-By: NitronR <bhanur05@gmail.com >
* fix(interview-prep): Added code tags Kaprekar numbers
Co-Authored-By: NitronR <bhanur05@gmail.com >
2019-03-21 11:52:35 +05:30
Timur
cab064a183
Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions ( #34345 )
...
* Fix tests
- fix original log() method restoration
- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md
allow function calling without semicolon
Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com >
2019-03-21 11:50:23 +05:30
Chuck Adams
4b2219b01d
close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions ( #35537 )
2019-03-20 22:02:21 +01:00
grets311
2219a9a8dd
Update positive-and-negative-lookahead.english.md ( #34582 )
...
Update solution from w{5} to w{6} as exercise is to match at greater than 5 characters long.
2019-03-20 15:58:09 +01:00
Shashank Bairy R
f313c094cb
fix: clarify how to create multiple box shadows (Issue: #35534 ) ( #35555 )
...
* fix: clarify how to create multiple box shadows
* Update curriculum/challenges/english/01-responsive-web-design/applied-visual-design/add-a-box-shadow-to-a-card-like-element.english.md
<code> tags added to 'color' property in order to make it look more consistent with the other propertes of 'box-shadow'.
Co-Authored-By: BA1RY <shashank.bairy04@gmail.com >
2019-03-20 15:32:53 +01:00
Edwin van Meerendonk
5f894a3231
A solution was missing ( #35552 )
...
My solution
2019-03-20 15:17:00 +01:00
Jade Michael Thornton
d5861edc84
add more specific tests for username regex challenge ( #34655 )
...
* add more specific tests for username regex challenge
* fix: removed unnecessary test
2019-03-19 15:21:30 -07:00
lasjorg
88a5d46ccb
fix(challenge): add support for IIFE arrow function ( #35573 )
...
* fix(challenge): add support for IIFE arrow function
* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
Yuran Pereira
39b597f1c2
Corrected grammatical mistake ( #35631 )
...
From: "The version numbers themselves not should be changed"
To: "The version numbers themselves should not be changed"
2019-03-19 11:24:48 -04:00
NITIN BISHT
228d873dd3
Fix: remove quote from challenge where not needed [english] ( #35493 )
2019-03-19 15:04:03 +05:30
Randell Dawson
4d1d89b1c7
fix(curriculum) Fixed test to only allow valid JSX comments for Add Comments In JSX challenge ( #35320 )
...
* fix: only allow valid jsx comments in div elem
* fix: allow blank comment and removed assert msgs
2019-03-19 01:00:12 -04:00
Oliver Eyton-Williams
e7bc4bd014
fix: Allow trailing commas to be used in challenge ( #35585 )
...
* fix: Allow trailing commas to be used in challenge
* fix: use regex to simplify challenge tests
* Update curriculum/challenges/english/03-front-end-libraries/react/review-using-props-with-stateless-functional-components.english.md
Co-Authored-By: ojeytonwilliams <ojeytonwilliams@gmail.com >
2019-03-18 09:56:46 -07:00
The Coding Aviator
17715a795e
fix(formatting): Zhang-Suen | Rosetta Code ( #35472 )
...
* fix(formatting): Move challenge instructions to instruction section
* Fix table and list
* fix(curriculum): Zhangsuen
* fix(curriculum): add bold tags
* Fix typo in instructions
2019-03-18 17:19:02 +09:00
Randell Dawson
9051ad2eb5
Fixed bug allowing versions of Object.keys method and hard coding of ownProps array ( #35021 )
...
* fix: disallow variants of Object.keys method
* fix: added new test to help prevent hardcoding array
* fix: refactored regex
2019-03-17 18:47:41 -04:00
Roberto Beltran
fb8dcd4dbc
Make link text more descriptive ( #35218 )
...
* Make link text more descriptive
Make link text more descriptive for improved accessibility.
* Add mention of MDN to link description
As suggested by Sidak Singh Aulakh, added reference to MDN web docs which is the link's destination.
* Update curriculum/challenges/english/03-front-end-libraries/jquery/change-text-inside-an-element-using-jquery.english.md
Adjust link wording
Co-Authored-By: RobertoJBeltran <45843750+RobertoJBeltran@users.noreply.github.com >
2019-03-17 16:47:30 -04:00
kevindelsh
64faca718b
Changed the definition of stateful components ( #34837 )
...
A stateful component is always a class component because functional components can't maintain state by definition. Changed a line to better reflect that.
2019-03-16 19:25:46 +01:00
Gökhan Gurbetoğlu
3b0a75e648
Add default value for justify-content ( #34419 )
...
According to the standard, the default value for justify-content if it is not specified is flex-start.
Source: https://www.w3schools.com/cssref/css3_pr_justify-content.asp
2019-03-14 07:14:21 -07:00
Nathan Lakritz
c31d1e2de9
Add semicolon to inline CSS ( #34737 )
2019-03-14 01:08:25 +05:30
Greg Brewton
0b3415b2fa
Clarifies definitions and adds missing definition ( #28591 )
...
Corrects incomplete definitions of space-between space-around values and adds definition of space-evenly value
2019-03-13 11:10:37 -07:00
Ron Sogueco
748212f99c
fix: Test fails with comments ( #35079 )
...
* fix: Test fails with comments
* fix: Account for last line of code
* fix: false positive for padding clockwise notation
* fix: false positive for commented blue-box class
* fix: use same assertion as #35342
* fix: update Solution section
* fix: update last test for margin/padding challenges
2019-03-13 13:54:59 -04:00
Sumer Patel
4f22235cc6
fix: broken tests in add-axes-to-a-visualization-challenge-in-d3 (Issue: #35554 ) ( #35577 )
2019-03-13 13:53:02 +05:30
Lauren Van Sloun
ef86d7bd61
Fixed typo in JavaScript curriculum ( #34820 )
...
* Fixed typo in JavaScript curriculum
* Added missing period at end of sentence
2019-03-12 15:05:22 -07:00
Vedrana_R
0ffdae1093
Fixed interpunction in the introduction paragraph ( #32157 )
...
* Fixed interpunction in the introduction paragraph
* fix: made suggested change
2019-03-12 14:53:17 -07:00
lasjorg
494687f75e
fix: correct inconsistency in formatting ( #34721 )
...
* fix: correct inconsistency in formatting
* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
Dana Ottaviani
0a2aa3dcfa
feat: add solution to accessibility challenge ( #35553 )
...
* feat: add solution to accessibility challenge
* Remove space before closing `time` tag
Co-Authored-By: Dana94 <dana.ottaviani@gmail.com >
2019-03-10 11:09:57 -07:00
Jonathan Neidel
95aacb6c02
Update challenge descriptions with code tags ( #35539 )
...
* Update challenge descriptions with code tags
Updates multiple challanges in the category: Information Security with
HelmetJS
* Fix(wording): security with helmetjs
Co-Authored-By: jneidel <github@jneidel.com >
2019-03-10 08:21:12 -07:00
Randell Dawson
49db42ba2b
fix(curriculum) Replace <code> with <blockquote>for code sections ( #35442 )
...
* fix: reformatted code and moved instructions
* fix: replaced code with blockquotes
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/install-and-set-up-mongoose.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* fix: made a few recommended changes of text
* fix: moved </blockquote> to new line
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* fix: removed extra space
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/chain-search-query-helpers-to-narrow-search-results.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/mongodb-and-mongoose/create-a-model.english.md
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
* fix: added the word The before code tag section
2019-03-09 08:49:19 -06:00
Randell Dawson
f6d07f37d7
fix: created more flexible test ( #35325 )
2019-03-08 11:07:50 -06:00
Bannon Tanner
9ebaa10eea
added clarification in test text ( #26458 )
...
* added clarification in test text
fix to issue #17490
* moved the note from the test text to description
* fix: updated note sytnax
2019-03-08 14:01:47 +05:30
The Coding Aviator
8069923feb
24 Game: Move instruction to instructions section
2019-03-08 15:53:02 +09:00
The Coding Aviator
084ba9c782
fix(formatting): Minor changes in 24 Game challenge
2019-03-08 15:53:02 +09:00
The Coding Aviator
f8061bcb56
Fixed formatting of the 24 Game | Rosetta challenge
2019-03-08 15:53:02 +09:00
Lewis Horwood
38c99d7ff5
Simplify challenge wording ( #25120 )
...
* Simplify challenge wording
* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price
27a59c5418
fix: reworded text messages ( #27072 )
2019-03-06 18:30:58 -05:00
Tom
dce5bceb85
fix/reformat-basic-node-express-challenges ( #35424 )
...
* fix/reformat-basic-node-express-challenges
* add semi-colon
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-json-on-a-specific-route.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-json-on-a-specific-route.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/get-query-parameter-input-from-the-client.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/get-route-parameter-input-from-the-client.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/implement-a-root-level-request-logger-middleware.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-an-html-file.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/serve-static-assets.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/start-a-working-express-server.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/start-a-working-express-server.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
* Update curriculum/challenges/english/05-apis-and-microservices/basic-node-and-express/use-body-parser-to-parse-post-requests.english.md
Co-Authored-By: moT01 <20648924+moT01@users.noreply.github.com >
2019-03-06 18:20:17 -05:00
Oliver Eyton-Williams
51fcc8e509
fix: Improve formatting for Pascal's triangle challenge ( #35531 )
2019-03-07 01:55:37 +05:30
Akshay Tiwari
6d24b879f2
Update catch-mixed-usage-of-single-and-double-quotes.english.md ( #35532 )
2019-03-07 01:04:12 +05:30
Randell Dawson
92208f7c23
[Fix] Modified regex to allow spaces in one of the tests for challenge Apply a Style Until a Condition is Met with @while ( #35100 )
...
* fix: modified regex to allow spaces
* fix: added additional \s* after 1
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
2019-03-06 03:05:52 -05:00
Aashis kumar
960811e31f
Solution to specify-exact-number-of-matches.english JavaScript Challenge ( #34757 )
...
* Update specify-exact-number-of-matches.english.md
Added an explanation to the working code too
* fix: removed i flag and comments
2019-03-05 13:12:55 -05:00
nik
304d36ab47
fix(challenge): decrease opacity testString ( #34711 )
2019-03-05 12:11:27 -05:00
Dan B
73e6e13243
Update find-the-minimum-and-maximum-value-in-a-binary-search-tree.english.md ( #35057 )
...
Added solution which has been tested and confirmed to pass all tests
2019-03-05 08:44:59 -06:00
Dan B
8bb76a4eb6
Update insert-an-element-into-a-max-heap.english.md ( #34989 )
...
Added solution to problem
2019-03-05 08:41:56 -06:00
Dan B
28aecb41f8
Update find-the-minimum-and-maximum-height-of-a-binary-search-tree.english.md ( #35006 )
...
Added working solution to the problem
2019-03-05 08:37:57 -06:00
Randell Dawson
8e5b99b8ca
fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge ( #35367 )
...
* fix: prevent 5th test from allowing invalid code
* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
The Coding Aviator
081284c2d3
fix: Formatting for Zig Zag Matrix challenge ( #35403 )
...
* fix: Formatting for Zig Zag Matrix challenge
* Remove non-breaking spaces and replace them with normal spaces
* Update zig-zag-matrix.english.md
* Move instructions to instructions section from description
* Update zig-zag-matrix.english.md
2019-03-05 11:57:57 +05:30
The Coding Aviator
8bac073687
fix(formatting): Zeckendorf challenge | Rosetta code ( #35474 )
...
* fix(formatting): Zeckendorf challenge | Rosetta code
* Update zeckendorf-number-representation.english.md
2019-03-05 11:51:56 +05:30
Randell Dawson
b7fee2848c
fix(curriculum): Corrected test which allowed wrong solution to pass ( #35394 )
...
* fix: corret-wrong-checks-in-test
* fix: improved robustness of test
* fix: added a full working solution for challenge
* fix: added && to asssert
2019-03-04 12:33:02 -06:00
kevindelsh
259eec5ab5
Sass import doesn't need file extension ( #34802 )
...
Added that the Sass import statement doesn't need the file extension like it doesn't need the underscore.
This helps beginners to better understand the concept and avoid confusion.
2019-03-04 09:35:07 -06:00
Ihor Allin
6222b86133
Update understand-the-hazards-of-using-imperative-code.english.md ( #35052 )
...
Moved instructions into correct section.
2019-03-04 09:24:54 -06:00
Randell Dawson
99c7f28530
fix: remove <code> tags around word queue ( #35393 )
2019-03-04 09:12:29 -06:00