Commit Graph

34 Commits

Author SHA1 Message Date
c31d1e2de9 Add semicolon to inline CSS (#34737) 2019-03-14 01:08:25 +05:30
748212f99c fix: Test fails with comments (#35079)
* fix: Test fails with comments

* fix: Account for last line of code

* fix: false positive for padding clockwise notation

* fix: false positive for commented blue-box class

* fix: use same assertion as #35342

* fix: update Solution section

* fix: update last test for margin/padding challenges
2019-03-13 13:54:59 -04:00
9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342)
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
2019-02-25 02:07:11 -05:00
aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
2f27b6e687 Fix typo in description (#34413)
Change "giving" in the Description section to "given"
2019-02-18 00:53:36 +05:30
6128976cc5 Added a solution to fix stub (#34813)
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
2019-02-17 11:41:48 -05:00
ba9e45023d fix: make border radius challenge Firefox compatible (#35009)
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
2019-02-16 17:17:11 +00:00
63c5a94321 Expected solution for the challenge seed code (#32532)
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
2019-02-15 12:48:30 -05:00
ba0d4fb15f Improved grammar and message (#28795)
* Improved grammar and message

* Update import-a-google-font.english.md
2019-02-14 13:38:58 -08:00
7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
9e4583b1f3 fix: change video url for clockwise-notation challenge (#35013) 2019-02-04 16:29:26 +03:00
a284b296fc fix: Capitalize test text for Cascading CSS variables (#34910) 2019-01-27 18:11:49 -07:00
2fea28aca8 add solution (#28406)
LGTM!
2019-01-24 15:57:09 -05:00
cffe1be295 Grammar consistency fix. (#24228)
Entire article is using "isn't" so the "wasn't" seems out of place. I'm just following https://english.stackexchange.com/questions/283758/proper-use-of-was-vs-is
2018-12-04 16:12:48 +00:00
786cda2627 Add challenge solution
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.

<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX
2018-12-03 23:10:41 +00:00
bdbf83e5a2 added 01-responsive-web-design/basic-css/ (#22531)
I have added use rgb-to-mix-color
2018-11-25 10:20:27 -07:00
b2328e96db Update import-a-google-font.english.md (#19717) 2018-11-18 08:45:03 -06:00
9c44af828d added missing word 'like' to the Instructions (#34215) 2018-11-05 19:20:22 +00:00
6ce41d6203 fixed a typo (#34170) 2018-11-03 01:24:58 +05:30
c54896273b Added a missing space and period in basic-css challenge files (#20480)
* Added missing space

* Added missing period in add-borders-around-your-elements.md

* Added missing space in adjust-the-padding-of-an-element.english.md
2018-10-29 22:13:45 +07:00
dc7bb257b9 fix(curriculum): correct test 2018-10-28 03:16:22 +05:30
022a2fce8a Add solution using all code (#25669) 2018-10-25 08:22:13 -04:00
843f6bff66 Added solution using all of the code. (#25671) 2018-10-25 08:17:44 -04:00
b8bdfef6d4 Added the solution while using all of the code. (#25675) 2018-10-23 15:04:19 -04:00
e099d6486d fix: test curriculum challenges (#24180) 2018-10-23 18:51:53 +05:30
79d9012432 fix(curriculum): quotes in tests (#18828)
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
2018-10-20 23:32:47 +05:30
0bae15e8c3 Clarification of the declaration order overriding (#19046)
* Clarification of the declaration order overriding

Previous text was talking about an override but it may also confuse readers that the override was done in the order of the listing of class names inside the h1.
I also added an extra case to better clarify the situation.

* Small change mentioning the order of declaration

Missed an order of declaration emphasis on my previous commit, adding it on this one.
2018-10-15 22:23:15 -05:00
ee9f6b2d72 chore(meta): Move challenge meta to challenges root 2018-10-11 02:15:05 +05:30
0b4f4c2aef fixed typo 2018-10-10 09:29:39 +01:00
d23ca70e21 fixed typo 2018-10-10 09:29:39 +01:00
46d8d61776 docs: update guide url 2018-10-08 11:02:25 -04:00
ac1ea780fc fix(challenge-md): Fix formatting errors 2018-10-08 12:54:03 +01:00
a859035023 fix(challenge-md): Fix quotes that failed in the transform 2018-10-08 11:38:26 +05:30
8f39bc1288 chore(curriculum): Remove files in wrong format 2018-10-05 15:58:12 +01:00