Commit Graph

544 Commits

Author SHA1 Message Date
Shaun Hamilton
c620077a7b fix(client): use iframe document element for transform (#45155) 2022-02-18 10:52:15 +01:00
Naomi Carrigan
1681cf262a fix: translatable "code saved" message (#45130) 2022-02-17 21:33:02 +05:30
Bruce B
7abb89326b fix(a11y): make breadcrumb nav more accessible (#45021)
* fix: make breadcrumb nav more accessible

* refactor: cypress test and jest snapshot

* slight adjustment to left breadcrumb focus outline

* feat: translate aria for nav

* chore(tools): update snapshot

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-15 21:44:18 +03:00
Oliver Eyton-Williams
cde1407f58 feat(client): make all sources available in tests (#44725)
* feat: make all sources available in tests

The original contents of all files (index.html, script.js etc.) will be
accessible in tests.  For example __sources['index.html'] gets the
original html file and nothing else.

* feat: use __file to get user code
2022-02-15 23:29:31 +05:30
Krzysztof G
f644c239c1 chore(client): tsmigrate getTargetEditor.js (#45090) 2022-02-14 06:12:04 +07:00
Bruce B
a5e4596db7 fix(a11y): remove tab role from buttons in beta rwd challenges (#45032)
* fix: remove tab role from buttons in beta rwd challenges

* remove sr-only text

* remove whitespace
2022-02-11 16:00:36 -08:00
Oliver Eyton-Williams
7fe4695794 refactor: ignore eslint less (#45082)
* refactor: remove and fix some eslint disables

* refactor: drop max-line disables
2022-02-11 10:28:13 -08:00
Tom
57cf47dad4 feat: split rdbms into individual blocks and two challengeTypes (#44978)
* feat: split english rdbms into individual blocks

fix: stuff

fix: remove from partiallyComplete array on submit

fix: add suggestion

Update client/i18n/locales/english/translations.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/i18n/locales/english/intro.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/i18n/locales/english/intro.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/i18n/locales/english/intro.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Update client/src/templates/Challenges/codeally/show.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: prettier

* fix: style suggestion

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-02-11 15:39:27 +00:00
Oliver Eyton-Williams
5f06b7805c test: titles in project previews (#45051)
* fix: trim titles before injecting into iframes

Surrounding whitespace isn't useful

* test: check preview iframe has correct title
2022-02-11 00:57:50 +07:00
Oliver Eyton-Williams
44e2bce920 refactor: clean up ref types (#45070)
The react-hotkeys innerRef type is incorrect (it accepts both callback
and object refs), but the lib is unmaintained at this point.
2022-02-10 11:31:55 -06:00
Bruce B
2c8b9f7815 fix: beta rwd - make step heading h1 (#45036) 2022-02-10 11:14:58 +01:00
Naomi Carrigan
a430aa42ef feat(client): styling for project cards (#44771)
* feat: project -> certification project

* feat: add certification icon

* feat: cert project banner

* feat: combine new cert detection methods

* feat: add a dynamic tag

* feat: replace blocks with grid bloks for new RWD

* feat: adjust individual progress bar

* feat: add dropdown icon

* feat: add conditional rendering

* feat: add local and fix cert card link

Co-authored-by: ahmad abdolsaheb <ahmad.abdolsaheb@gmail.com>
2022-02-08 19:49:00 -06:00
Shaun Hamilton
7d1677fc86 fix(client): show description when above line 1 2022-02-09 03:56:13 +03:00
Shaun Hamilton
765e72e702 feat(client): enable scrollBeyondLastLine in editor 2022-02-09 03:56:13 +03:00
Bruce B
6b2f2dbf77 fix(a11y): remove complementary role from instructions panel (#45030) 2022-02-08 17:46:24 +00:00
Bruce B
03d9239eb5 fix(a11y): add h1 heading to classic challenges (#45031) 2022-02-08 21:21:19 +05:30
Bruce B
7d817cb237 fix(a11y): add title attribute to iframes (#45014)
* fix:add title attribute to iframes
2022-02-08 11:22:54 +01:00
Oliver Eyton-Williams
c541baf179 fix(client): update invalid stored code (#44437)
* fix: repair invalid stored code
2022-02-01 10:09:08 -06:00
Sem Bauke
7ab1e98a7f fix(editor): remove reference tool-tips (#44949)
* fix(editor): remove MDN refrence tooltips

* fix: init in constructor
2022-01-28 15:11:05 +00:00
Krzysztof G
6db9bbbd6e fix: include labels in editor tabs buttons (#44918) 2022-01-25 13:57:17 -08:00
Oliver Eyton-Williams
cacc4eacd7 fix: handle the sorting of transformed files (#44724)
* fix: handle the sorting of transformed files

We can't use the ext property, since that is transformed, but the
history is maintained.

* test: make solutions polyVinyls for sorting

* refactor: inline prepareChallenge

* refactor: make solutions polys in getChallenges

* fix: convert each solution to a poly

* fix: skip empty solutions

* fix: get challenge file history in client

* refactor: stop calling isPoly from the client

* fix: remove debug console.log

* refactor: remove unnecessary sorting step
2022-01-24 10:42:27 -08:00
Oliver Eyton-Williams
b1fb6adc39 fix: insert user html more consistently (#42195)
* fix: use an iframe to preserve head and body

* fix: remove unnecessary parsing of html

The contents gets inserted into the DOM during transformHtml, which
is always part of the build pipeline

* fix: pipe contents through iframe

* refactor: use the same code for both transforms

* fix: try to handle test errors better

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2022-01-24 18:02:25 +00:00
Bruce B
76529a17ba feat(client): JAWS 2022 bugfix for monaco editor (#44784)
* feat: JAWS 2021 bugfix for monaco editor

* update menu label and toggle announcement

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* clarify visibility hack for live region

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-01-24 17:45:01 +00:00
Oliver Eyton-Williams
f88473f994 fix(client): handle missing document in preview frame (#44833) 2022-01-20 13:22:25 +00:00
Oliver Eyton-Williams
d091bd3b8f fix: make sure a11y help widget is not obscured (#44822) 2022-01-20 10:06:22 +05:30
Shaun Hamilton
9cb87d0257 chore: remove verify-can-claim-cert logic (#44574)
* chore: remove verify-can-claim-cert logic

* remove extraneous

* remove console log before Nich wakes up

* add api route back with flash

* remove unnecessary logic in completion-epic

* change tests for new layout

* dynamically use api location

* rename file

* fix Cypress api location

* fix(test): anchor does not have disabled class

* fix(tests): change js test to claim from /settings

* chore: change status to 410 (gone)

* update testing again

* oliver is nitpicky

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* make oliver happy

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-01-18 08:52:49 -06:00
Mrugesh Mohapatra
685344ae45 refactor: apply fixed from codefactor (#3) (#44780)
Co-authored-by: codefactor-io <support@codefactor.io>

Co-authored-by: codefactor-io <support@codefactor.io>
2022-01-14 08:53:34 -08:00
Oliver Eyton-Williams
a00788417a fix(client): stop injecting extra comments into preview (#44723) 2022-01-13 13:25:55 -08:00
Oliver Eyton-Williams
2952f9399d fix(client): keep challengeFile order on update (#44722)
* fix: keep challengeFile order on update

* refactor: name variable challengeFile, not file

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: prettify

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-01-10 14:02:30 -08:00
Jacob O'Reilly
0009100f71 fix(client): show error messages instead of timeout (#43744)
* Fixed Error message update not displaying when timeout happens when there was an error in the code. Working on fixing the timeout it self.

* refactor: remove comment + log changes

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-01-08 07:25:38 -08:00
Oliver Eyton-Williams
01a03f2961 fix: prevent timeout errors (#44714) 2022-01-08 11:42:16 +05:30
Oliver Eyton-Williams
87f5cff3cd fix(client): get jquery from cdn (#44421)
* fix: ensures jquery exists for those challenges

For tests frame-runner.js imports jquery, but jquery challenges always
need it

* Revert "Revert "fix: only include frame-runner when running tests (#44337)" (#44419)"

This reverts commit c19bf504b8.
2022-01-07 10:42:27 +00:00
Tom
b061a760c1 feat: add framework for rwd cert projects (#44505)
* feat: add rwd cert projects

feat: save projects with flag

revert: not needed things

revert: empty line

revert: empty line

fix: it

fix: remove log

* fix: snapshot tests

* fix: show bread crumbs by default

* revert: snapshot fix

* Update curriculum/challenges/_meta/responsive-web-design-projects/meta.json

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: manuallyApproved -> isManuallyApproved

* fix: add review suggestions

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2022-01-06 13:26:54 +00:00
Nicholas Carrigan (he/him)
ff09b2ee43 fix: lint error (#44695) 2022-01-06 11:42:14 +05:30
Oliver Eyton-Williams
60258d40c9 fix: order import (again) (#44670)
* refactor: reenable import ordering

* refactor: require alphabetic ordered imports
2022-01-05 16:05:50 -06:00
Aleksa Kis
34a76659c1 chore(client): ts-migrate Challenges/utils test (#44672)
* chore(challenges-utils): Change test util file extension

* chore(challenges-utils): typescript migration of Challenges util test
2022-01-04 16:59:50 +01:00
Aleksa Kis
cc86654048 chore(challenges-utils): Typescript migration of Challenges util (#44663) 2022-01-04 16:49:31 +05:30
Oliver Eyton-Williams
795316b1d4 fix(client): always render bottom jaw in correct position (#44657) 2022-01-03 17:27:58 +05:30
Ahmad Abdolsaheb
cb201a8e8b feat: add grid map (#44557)
* feat: add map grid

* fix: lint/prettier/ts

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-12-23 10:29:52 -06:00
Tom
bd9065fdfe fix: sideways checkmarks on blocks (#44575) 2021-12-23 17:17:11 +01:00
Oliver Eyton-Williams
05089c535a fix(client): enlarges console pane for project steps (#44567) 2021-12-23 17:39:06 +03:00
Oliver Eyton-Williams
85b9daedb8 fix(client): handle challenge resets with hidden preview (#44570) 2021-12-23 17:34:26 +03:00
Tom
dfd3fd452d fix: make beta go to RWD superblock instead of learn (#44563) 2021-12-23 19:18:12 +05:30
Tom
075bc04a2b fix: step-1 crashing (#44561) 2021-12-23 06:51:03 +00:00
Oliver Eyton-Williams
fd63bb6f85 feat: mvp features for soft launch (#44539)
* refactor: use enum

* feat: create links between legacy and new

* refactor: pull out legacy-links component

* fix: import order

* fix: provide icon for new superblock

* feat: only show the copy on the new superblock

* fix: use the proper i18n keys correctly

* feat: put the new superblock at the end of the map

* feat: update the new superblock title

* test: update for soft launch order

* fix: show original project links on /settings

Soft launch only.

* test: use SHOW_NEW_CURRICULUM in tests

* fix: rename the remaining rwd-22s

* feat: make the messge prettier

* fix: message copy

* refactor: make comment make sense

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-12-22 16:53:40 +00:00
Tom
b0872abd86 fix: hide editor tabs on desktop (#44534) 2021-12-20 15:11:09 -08:00
Nicholas Carrigan (he/him)
8614db7a32 feat: enable new curriculum (#44183)
* feat: use legacy flag

chore: reorder challenges

fix: linter

revert: server change

feat: unblock new editor

fix: proper order

fix: 0-based order

fix: broke the order

feat: move tribute certification to its own block

feat: split the old projects block into 4

fix: put all blocks in order

chore: add intro text

refactor: use block, not blockName in query

fix: project progress indicator

* fix: reorder new challenges/certs

* fix: reorder legacy challenges

* fix: reintroduce legacy certs

* feat: add showNewCurriculum flag to env

* chore: forgot sample.env

* feat: use feature flag for display

* fix: rename meta + dirs to match new blocks

* fix: add new blocks to help-category-map

* fix: update completion-modal for new GQL schema

* test: duplicate title/id errors ->  warnings

* fix: update completion-modal to new GQL schema Mk2

* chore: re-order metas (again)

* fix: revert super-block-intro changes

The intro needs to show both legacy and new content.  We need to decide
which pages are created, rather than than what a page shows when
rendered.

* feat: move upcoming curriculum into own superblock

* fix: handle one certification with two superBlocks

* fix: remove duplicated intros

* fix: remove duplicate projects from /settings

* fix: drop 'two' from Responsive Web Design Two

* chore: rename slug suffix from two to v2

* feat: control display of new curriculum

* feat: control project paths shown on /settings

* fix: use new project order for /settings

This does mean that /settings will change before the release, but I
don't think it's serious.  All the projects are there, just not in the
legacy order.

* fix: claim/show cert button

* chore: remove isLegacy

Since we have legacy superblocks, we don't currently need individual
blocks to be legacy

* test: fix utils.test

* fix: verifyCanClaim needs certification

If Shaun removes the cert claim cards, maybe we can remove this entirely

* fix: add hasEditableBoundaries flags where needed

* chore: remove isUpcomingChange

* chore: v2 -> 22

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-12-20 12:36:31 -06:00
Prashant
304773d62b fix(i18n): Expand/Collapse Courses Button text (#44528)
* fix(i18n): Expand/Collapse Courses Button text

* Update client/i18n/locales/english/intro.json

Co-authored-by: Ilenia <nethleen@gmail.com>

* Update client/i18n/locales/english/intro.json

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-12-20 18:24:09 +01:00
Ahmad Abdolsaheb
ee73042c84 feat(client): add background animation for description of first challenge (#44519)
* initial

* Apply suggestions from code review

* Update client/src/templates/Challenges/classic/editor.css
2021-12-17 21:21:17 +01:00
Tom
c2aa8ce3e5 fix: make completion modal a little more accessible (#44508)
* fix: make completion modal a little more accessible

* remove: unneeded aria attribute

* fix: update snapshots
2021-12-16 11:17:12 +01:00