Commit Graph

778 Commits

Author SHA1 Message Date
Quincy Larson
3c077561fa fix(linting): Fix linting issue 2017-12-16 20:11:03 +05:30
Quincy Larson
cda82d68fe feat(navigation): Fix vertical bar in navbar and change "side panel" 2017-12-16 20:11:03 +05:30
Quincy Larson
7a110aaf55 fix(navbar): Fix a mistake I left in the CSS 2017-12-16 20:11:03 +05:30
Quincy Larson
59dc80a621 feat(navbar): Adds vertical line between normal navigation and p 2017-12-16 20:11:03 +05:30
Berkeley Martinez
b1e9a172a2 Feat: anon navbar (#16189)
* chore(React): %s/react-pure-render/React.PureComponent/gc

* fix(Settings): Should redirect to signup when unauthen

* feat(Development): Use SES for mail if defined

* feat(Nav): Show anon navbar when logged in

* fix(server/datasources): Make sure mailhog works if no ses keys are found

LB will use both mail settings if using both local and dev

* fix(Nav): Use text instead of icons

* fix(Nav): Make donate page open in new tab
2017-12-15 15:53:32 -06:00
Mrugesh Mohapatra
6852814e11 fix(rechallenge): Use includes instead 2017-12-15 12:17:30 +05:30
Berkeley Martinez
d3bbf27dab Fix(Challenges): get user code (#16187)
* fix(Challenges.): Prevent source from being overwritten

* fix(Challenges): Tests should use name

* fix(seed/react): Namespace tests for now
2017-12-13 17:24:36 -06:00
Berkeley Martinez
375442d365 fix(Modern): Editor should update not create (#16183) 2017-12-13 17:15:57 -06:00
Anh Tran
127fae59f4 fix(UX): Change the Available/Unavailable to Yes/No label o (#16176) 2017-12-11 09:45:58 +05:30
Berkeley Martinez
2e410330f1 Feat(Challenges): no js preview (#16149)
* fix(files): Decouple files from challenges

* feat(server/react): Remove action logger

use redux remote devtools instead!

* feat(Challenges): Disable js on edit, enable on execute

* feat(Challenge/Preview): Show message when js is disabled

* refactor(frameEpic): Reduce code by using lodash

* feat(frameEpic): Disable js in preview by state

* feat(frameEpic): Colocate epic in Challenges/redux

* refactor(ExecuteChallengeEpic): CoLocated with Challenges

* refactor(executeChallengesEpic): Separate tests from main logic

* feat(Challenge/Preview): Update main on edit

* feat(frameEpuc): Replace frame on edit/execute

This allows for sandbox to work properly

* fix(Challenges/Utils): Require utisl

* revert(frameEpic): Hoist function to mount code in frame

* fix(frameEpic): Ensure new frame is given classname

* feat(executeChallenge): Update main on code unlocked

* fix(frameEpic): Filter out empty test message

* fix(Challenge/Preview): Remove unnessary quote in classname

* feat(codeStorageEpic): Separate localstorage from solutions loading

* fix(fetchUser): Merge user actions into one

prefer many effects from one action over one action to one effect

* fix(themes): Centralize theme utils and defs

* fix(entities.user): Fix user reducer namespacing

* feat(frame): Refactor frameEpic to util

* feat(Challenges.redux): Should not attempt to update main from storage

* fix(loadPreviousChallengeEpic): Refactor for RFR

* fix(Challenges.Modern): Show preview plane
2017-12-07 18:13:19 -06:00
Mrugesh Mohapatra
885d5916c0 fix: Update email action should hit API 2017-12-07 00:00:02 +05:30
Berkeley Martinez
7b6f774e9b fix(Settings): Actually change state when nav to update email 2017-12-04 13:50:49 -08:00
Berkeley Martinez
bf706e9bf2 fix(Router): Link should use reselect 2017-12-03 13:38:52 -08:00
Berkeley Martinez
63875316d9 fix(Router): Add lang to payload if payload doesn't exist
closes #16134
2017-12-03 13:21:47 -08:00
Berkeley Martinez
dced96da8e feat: react challenges (#16099)
* chore(packages): Update redux utils

* feat(Panes): Invert control of panes map creation

* feat(Modern): Add view

* feat(Panes): Decouple panes from Challenges

* fix(Challenges): Decouple challenge views from panes map

* fix(Challenge/views): PanesMap => mapStateToPanesMap

This clarifies what these functions are doing

* fix(Challenges): Add view type

* fix(Panes): Remove unneeded panes container

* feat(Panes): Invert control of pane content render

This decouples the Panes from the content they render, allowing for
greater flexibility.

* feat(Modern): Add side panel

This is common between modern and classic

* feat(seed): Array to string file content

* fix(files): Modern files should be polyvinyls

* feat(Modern): Create editors per file

* fix(seed/React): Incorrect keyfile name

* feat(Modern): Highligh jsx correctly

This adds highlighting for jsx. Unfortunately, this disables linting for
non-javascript files as jshint will only work for those

* feat(rechallenge): Add jsx ext to babel transformer

* feat(seed): Normalize challenge files head/tail/content

* refactor(rechallenge/build): Rename function

* fix(code-storage): Pull in files from localStorage

* feat(Modern/React): Add Enzyme to test runner

This enables testing of React challenges

* feat(Modern): Add submission type

* refactor(Panes): Rename panes map update action
2017-11-29 17:44:51 -06:00
Quincy Larson
52c99823b8 feat(UI): Add new congratulations messages and remove confus (#16110) 2017-11-26 01:18:58 +05:30
Berkeley Martinez
dbecdc5618 feat: prep for modern challenges (#15781)
* feat(seed): Add modern challenge

* chore(react): Use prop-types package

* feat: Initial refactor to redux-first-router

BREAKING CHANGE: Everything is different!

* feat: First rendering

* feat(routes): Challenges view render but failing

* fix(Challenges): Remove contain HOC

* fix(RFR): Add params selector

* fix(RFR): :en should be :lang

* fix: Update berks utils for redux

* fix(Map): Challenge link to arg

* fix(Map): Add trailing slash to map page

* fix(RFR): Use FCC Link

Use fcc Link to get around issue of lang being undefined

* fix(Router): Link to is required

* fix(app): Rely on RFR state for app lang

* chore(RFR): Remove unused RFR Link

* fix(RFR): Hydrate initial challenge using RFR and RO

* fix: Casing issue

* fix(RFR): Undefined links

* fix(RFR): Use onRoute<name> convention for route types

* feat(server/react): Add helpful redux logging/throwing

* fix(server/react): Strip out nonjson from state

This prevents thunks in routesMap from breaking serialization

* fix(RFR/Link): Should accept any renderable

* fix(RFR): Get redirects working

* fix(RFR): Redirects and not found's

* fix(Map): Move challenge onClick handler

* fix(Map): Allow Router.link to handle clicks after onClick

* fix(routes): Remove react-router-redux

* feat(Router): Add lang to all route actions by default

* fix(entities): Only fetch challenge if not already loaded

* fix(Files): Move files to own feature

* chore(Challenges): Remove vestigial hints logic

* fix(RFR): Update challenges on route challenges

* fix(code-storage): Should use events instead of commands

* fix(Map): ClickOnMap should not hold on to event

* chore(lint): Use eslint-config-freecodecamp

Closes #15938

* feat(Panes): Update panes on route instead of render

* fix(Panes): Store panesmap and update on fetchchallenges

* fix(Panes): Normalize panesmaps

* fix(Panes): Remove filter from createpanemap

* fix(Panes): Middleware on location meta object

* feat(Panes): Filter preview on nonhtml challenges

* build(babel): Add lodash babel plugin

* chore(lint): Lint js files

* fix(server/user-stats): Remove use of lodash chain

this interferes with babel-plugin-lodash

* feat(dev): Add remote redux devtools for ssr

* fix(Panes): Dispatch mount action

this is needed to trigger window/divider epics

* fix(Panes): Getpane to use new panesmap format

* fix(Panes): Always update panes after state

this lets the panes logic be affected by changes in state
2017-11-09 19:10:30 -06:00
Berkeley Martinez
1ca383a5ff Merge pull request #15803 from vivek28111992/fix/text-change
fix(challenges): Change of text in Introduction to the basic node a
2017-11-02 15:21:12 -07:00
JustusFT
4ba3e64786 fix(nav): Navbar breaks at 768px to 786px 2017-11-03 01:04:38 +05:30
mrugesh mohapatra
326e10feff Merge pull request #16003 from aaronang/fix/shift-tab
fix(editor): Unindent line when nothing is selected
2017-10-24 01:22:43 +05:30
Aaron Ang
50d1b8aae8 fix(editor): Unindent line when nothing is selected
Pressing SHIFT + TAB while no text is selected would indent the text
which is uncommon behavior. This change will always unindent the code
regardless of whether text is selected or not.
2017-10-21 14:12:33 +02:00
Marc Rendl Ignacio
ed68463738 fix: remove random compliment without gender-neutral alternative 2017-10-21 08:18:58 +08:00
Peter Weinberg
f868862c0f fix(editor): restore syntax highlighting for light theme 2017-10-13 20:26:51 -04:00
Berkeley Martinez
509613f5d7 Merge pull request #15889 from ltegman/fix/navbar-props
fix(Navbar): stop using removed onClose prop of react-bootstraop Navbar
2017-09-25 21:15:59 -07:00
Logan Tegman
e0c4e53be3 fix(Navbar): stop using removed onClose prop of react-bootstraop Navbar 2017-09-16 19:12:30 -07:00
dhcodes
63a147257b fix(main): static page links and constantStrings 2017-09-16 17:16:48 -05:00
Quincy Larson
564e76b2bf fix(merge): Fix merge conflicts 2017-09-11 17:43:18 -05:00
Markus Englund
3206d8c549 fix(map): Change styling of map in night mode (#15780)
Previously the map had white background color and white color, making it
impossible to see the text. I changed the colors to the standard
night-mode color variables. I also deleted a css class that was not
doing anything.

Closes #15702
2017-09-11 09:53:16 +02:00
Berkeley Martinez
3be6775245 Merge pull request #15758 from xnt/fix/testResults-a11y
fix(challenges): Provide accessible test description and status
2017-09-04 14:22:05 -07:00
Darth Skywalker
64806f2a3b fix: submit button is not clickable on challenge completion modal 2017-09-02 12:13:07 +05:30
Stuart Taylor
1126bf7004 Protect the global name space from the code editor 2017-09-01 20:24:51 -07:00
Berkeley Martinez
e50fbc05ca fix(redux.utils): Fix test plan 2017-09-01 20:01:57 -07:00
systimotic
01291162ef Fix isBeta challenges displaying without title when they should be hidden 2017-09-01 20:01:57 -07:00
Berkeley Martinez
7dd9d31e54 Merge pull request #15760 from xnt/fix/main-landmark
fix(accessibility): Add main and complementary landmarks
2017-09-01 18:31:23 -07:00
Dylan
900617613f fix(challenges): Added bug modal to classic ch (#15828)
Closes #15740
2017-09-01 11:16:19 -07:00
Timo
dcfe18d5d5 refactor: Replace .com with .org 2017-08-26 00:07:44 +02:00
Vivek
ad20c9724d fix(challenges): Change of text in Introduction to the basic node a
Text was not getting changed going from step 1 to step 2 because ul
cannot be child node of p tag so I changed p tag to div in Introduction
to the basic node and express challenges. For ref.
https://stackoverflow.com/questions/10601345/ul-element-can-never-be-a-child-of-p-element

BREAKING CHANGE: Changed p tag to div tag in Step.jsx

Closes #15796
2017-08-25 16:42:24 +05:30
Zachary Kearns
a5c330de4d fix(settings): Improve email settings buttons
Closes #15772
2017-08-23 23:36:44 -04:00
Vicente Plata
cd9af163f6 fix(challenges): Provide accessible test description and status
Closes #13013

fix(challenges): Fix undefined initial variable status
2017-08-22 22:08:20 -07:00
Vicente Plata
d449c3cdd0 fix(accessibility): Add main and complimentary landmarks
Screen readers and other assistive technologies use it for navigation

Closes #15658
2017-08-12 22:02:01 -07:00
Berkeley Martinez
0d70db5d98 Merge pull request #15022 from no-stack-dub-sack/feat/challenge-desc
feat(views): create global challenge-description component
2017-08-08 18:22:10 -07:00
Marius Espejo
34d512ffeb fix: don't render challange if isBeta (#15741) 2017-08-08 14:44:59 -05:00
Cody Seibert
9f875e1d11 feat(quiz): initial quiz view which can be used for multiple choice (#15743)
quizes
2017-08-08 14:31:26 -05:00
Dylan
f9e925b03e Merge pull request #15734 from anawebdev/fix/hours-display
Correct misalignment between challenge names and hour estimates
2017-08-05 21:17:14 -05:00
Ana
9adbd5fb56 fix: hours-display 2017-08-05 11:06:03 +03:00
Berkeley Martinez
c547c26bba Fix: map should redirect to current challenge (#15723)
* fix(routes): /map redirects to current challenge

* fix(map): Normalize server map building

Localize all server code dealing with the map

* refactor(server): Remove unused services

* feat(Nav): Show Map button when no panes

This gives user the ability to quickly return to their challenge using a
known feature

* fix(server.map): Add caching to nameIdMap

Add caching to nameIdMap on the server

* fix(services.map): Fix map service

Move map building utils to map util. Fix bad import. Normalize challenge
lookup
2017-08-03 22:45:36 -05:00
Berkeley Martinez
42bfa2e64d feat(app): new layout (#14707)
* feat(app): Restructure app to be more flexible and redux idiomatic

BREAKING CHANGE: Lots of breaking changes

* refactor(challenges): Redux to started file structure

* fix(app): lint issues due to refactor

* fix(settings): Refactor settings to use folder structure

* refactor(challenges): Move step redux stuff into step folder

* fix(challenges): Remove fetchchallenges actions

* refactor(challenges): Move project redux logic into project view subdirectory

* refactor(app): %s/sagas/epics/g

* refactor(redux): Use new redux-epic with combineEpic and ofType

* refactor(app): Move challenge selector to app level

* fix(app): Move loading challenge info into challenge route

This moves a lot of the logic needed to load challenge info into the challenge app. This decouples
the main app from the challenge route

* refactor(map): Map is now decoupled from challenges

* refactor(challenges): Use selectors everywhere instead of guessing state shape

* refactor(client): refactor client epics to use selectors

* refactor(app): Refactor userSelector to return user object instead of object.user

* refactor(entities): Move entities logic into it's own file

* fix(redux): combineTypes should be combineActions

* fix(app): reducer namespacing and import

* fix(Map): Fix undefined type and update redux-action

* fix(redux): Refactor fetchUser to be more declarative

Use rxjs methods instead of imperative if/else. Also prevent non-actions from being emitted

* fix(redux): toString multi phase action types

* fix(redux): typecast multiphase type, fix typo in reducer

toString multiphase types in fetch challenge epic. Add epic to epics lists. Fix type in fetch
challenge complete handler

* fix(redux): updateCurrentChallengelogic should be centerlized

Move route changes to one location.

* fix(Nav): Prevent event object from hanging around

closeDropDown/openDropDown where handing on to the event object. This was causing issues with react
since event objects are recycled in React.

* fix(Map.Challenge): decouple map selector

* fix(Map): Decouple panel selectors from props

Panel Selectors no longer need to know the shape of a components props. Refactored component
selectors to decouple them entities state shape

* fix(Map.redux): Add select challenge epic and connect map epics

* fix(redux.analytics): Fix meta creator and nav/map events

* fix(redux): Update current challenge ajax

* fix(challenges): ssr fetch challenge should update challenge ui

Was using an epic to update challenge ui on fetch complete, but this was not working on ssr due to
the way ssr disables epics to wait for completion. This commit fixes this by causing the complete to
directly update state in the challenge ui

* fix(challenges): wrong import of types, refactor epic name

* fix(redux): Prevent fetch challenge epic from emitting null to dispatch

* fix(redux): prevent executechallenge from emitting null

* fix(challenges.redux): testsSelector returns just tests

* fix(challenges.redux): Prevent completion challenge from emitting null

* refactor(Challenges.Step): Refactor step challenge to release event object

* fix(redux): wrap reducers in factories
reducers exported from features need to be factories
this helps avoid cyclic requires messing up reducer creation
We end up with exports from files being undefined as node tries
to resolve cyclic dependencies.
This prevents that by wrapping the `handleActions` call so that the ref
to types imported from parent features are closures and can be resolved
by node before we need them.

* fix(Map): createUi not working correctly

map utils should receive just map ui state, createMapUi needs to add title to challenge

* feat(Challenges): Adds Panes and panes backend challenge

* fix: Create child container to wrap children

Create a ChildContainer comp' to wrap all children that represent the view for the current route.
This let's the child route define if they want a full width view or if they want the standard
max-width view.

* feat(Panes): panes now render dividers

* feat(Panes): Get divider to move currectly

* fix(Nav): Add top margin to contained childs

Move margin-bottom from nav to child container as margin top. This let's the jsbin style views fit
snug with navbar

* fix(Panes): Should be contained within their borders

* feat(Panes): Update navbar height of pane on app mount

* feat(Panes): Toggle map on map nav btn click

* fix(gulpfile): Ensure nodemon exits on restart

On process exit, wait for nodemon to shutdown before process.exit

* feat(Panes): Make Panes redux first

* fix(Panes): Fix divider positioning

* fix(Panes): Update divider moved handler

dividerMoved action now uses new panesByName structure

* feat(Panes): Pane nav button will hide panes

* chore(package-lock): Update package lock

* feat(Panes.redux): Recaculate dividers on pane toggle

* fix(Challenges): Update challenge on dashedName change

This fixes backwards navigation not updating the redux state current
challenge

* feat(Panes.redux): Clear panes on unmount

Clearing panes on unmount will clear bin buttons in nav

* refactor(Map): Colocate styles

* feat(Map): New map layout

* fix(Map): No longer has it's own page

* fix: FetchChallenges on appMounted

* feat: Normalize fetchChallenge(s) results

This allows superblocks to be sent with both fetchChallenge and
fetchChallenges so the map is always populated on first load

* feat(Map): Show blocks on first load

* fix(less): Remove old css

* feat(Nav): Reduce nav height

* fix(Nav): Render nav after content

Render nav after content and use css to reverse again on screen. We do
this so the panes can render first and update redux panes state which
will then update the nav ui state before nav has a chance to render

* fix(Panes): Add container

This adds a Panes Container that will allow it to udpate redux state so
Panes Component will have redux state ready to actually render panes

* feat(Challenges.Classic): Add panes

* fix(Challenge.Classic): Editor onchange should not need to know about file

* fix(Panes): Index on panes hide should account for hidden pane

* fix(Challanges.Classic): Fix panes types

* fix(Challenges): Add completion modal to all challenges

Change classic modal to completion modal

* fix(Panes): Dividers live on top of planes

* fix(Challenges): Remove codemirror theme

Remove codemirror theme and remove borders from preview frame

* fix(Challenges.Classic): Remove old component

* feat(Challenges.Step): Add panes to step challenge

* feat(Challenges.Project): Add panes to projects

* fix(Challenges.Projects): Remove row

* fix(Modals): Move modal text color to challenge less

This text color is dependent on the actual header color

* fix(Map): Use Superblock title for ui

* fix(Map): Reduce panel header height

* fix(app): Capitalize Toasts folder

Feature folders should be campitalized

* chore(Map): Remove unused epic file

* fix(Step): Fix tests

* test(Map): Update createMapUi tests input
2017-07-31 22:04:01 -05:00
Mrugesh Mohapatra
91105bdf12 fix(frontend-projects): replace video with image thumbnail 2017-07-13 21:50:47 +05:30
Dylan
6608f82d5a reset to top on new challenge (#15607) 2017-07-09 12:58:25 -05:00
Luke Bousfield
121f53a20b Replaced 'startsWith' with RegExp.test() 2017-07-02 15:15:23 +01:00