Commit Graph

522 Commits

Author SHA1 Message Date
Kai Wei Mo
ce5b9b8aba fix(curriculum): augment test for adding tracks property (#45424)
* Only English

* Consitent quotation marks
2022-03-17 19:13:16 +00:00
Naomi Carrigan
dab600b4b1 chore: refactor the everything be true challenge (#45433) 2022-03-16 08:29:46 -07:00
HenMoshe
d3304276ca fix(curriculum) : Make tests stricter for challenge "Decrement a number with javascript" (#45242)
* Make tests stricter for challenge "Decrement a number with javascript" #44648

* Update decrement-a-number-with-javascript.md
2022-03-09 22:47:02 -06:00
Naomi Carrigan
1c65d5d34a fix(curriculum): remove callback thereby stripping js comments (#45133)
* fix: strip js comments

* fix: revert helper export, better test approach

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2022-02-24 16:29:56 +05:30
HenMoshe
ea416b6dc2 fix(curriculum): add result of comparison expression evaluation to the inline comment (#45224)
* Add result of comparison expression evaluation in the inline comment #45183

* Apply suggestions from code review

thanks!

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>

Co-authored-by: Naomi Carrigan <nhcarrigan@gmail.com>
2022-02-23 18:58:42 +01:00
zelf0
3668422083 fix: add divider to stand in line challenge in basic javascript section (#45180)
* Fix: Update grammar in PR documnetation

* fix: add divider to stand in line challenge in basic javascript section

* Undo change outside of scope
2022-02-21 22:44:27 +05:30
Poonkuzhali
6f628e6133 fix(curriculum): add test case to check country code (#45100)
* Added new test case to argument optional challenge

* Added new test case to telephone num js challenge
2022-02-18 10:09:51 -08:00
Jagruti Tiwari
9b7d7ba716 fix(curriculum): inconsistancy on const Naming cases (#45149) 2022-02-17 11:35:16 -08:00
Madhu Sudhan Reddy Vinta
92778f1b2f Bugfix in typeof lesson in Javascript debugging (#45118)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Fix bug in typeof lesson in debugging javascript

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/use-typeof-to-check-the-type-of-a-variable.md

Co-authored-by: Ilenia <nethleen@gmail.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
Co-authored-by: Ilenia <nethleen@gmail.com>
2022-02-16 20:14:12 +01:00
Madhu Sudhan Reddy Vinta
0a895dad47 fix(curriculum): make example less confusing (#45088)
* Local scope and functions: Make the example less confusing

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/local-scope-and-functions.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-02-11 12:08:46 -08:00
Poonkuzhali
f4077cab7f feat: added new test case to argument optional challenge (#45076) 2022-02-10 17:17:07 -06:00
Vaibhav
9ffc7b4711 fix(curriculum): add two edge test cases to the sorted union problem (#44860)
* fix: fixed solution of sorted union

* fix: improved solution of sorted union problem
2022-02-02 19:28:31 +01:00
Aakash Pal
1c56d4cdda fix: remove double space (#44837)
* fix: typo in javascript-algorithms-and-data-structures > object-oriented-programming > understand-own-properties

* revert all the files with translations

* fix last commit error and remove changes from translated files
2022-01-19 22:19:43 +00:00
Nicholas Carrigan (he/him)
8954449625 feat: refactor the refactor challenge (#44770) 2022-01-17 09:57:15 +01:00
Thomas Albertini
b2a251fff0 fix: small lint fix in challenges functions (#44728)
* fix: small lint fix in challenges functions

* Revert "fix: small lint fix in challenges functions"

This reverts commit cde43d4d86.
2022-01-10 15:57:22 -08:00
HiddenOgre28
aa0ae1ae67 fix(curriculum): add a function call to seed contents (#44512) 2022-01-07 16:34:59 +05:30
HiddenOgre28
5ffcd0f284 feat(curriculum): add log with function call to challenge (#44195)
* fix (Curriculum) Added a log statement

Added a log statement to the seed's content, referencing the function countOnline with a sample object as argument.
The user should be able to see the result of the function printed out on the console as soon as it is ran, and it should be easier to understand what is being outputed by the function in this challenge.

* Added examper users object
2022-01-07 14:37:02 +05:30
sanberkzulfikar
50b554470d fix(curriculum): wording consistency in counting-cards.md (#44390) 2021-12-08 07:32:56 -08:00
HiddenOgre28
a0d3f22dfc fix(curriculum): correct grammar in description (#44194) 2021-11-18 16:07:12 +00:00
Michał Urbanek
9920b7c83c fix(curriculum): point to all lines requiring change (#44056)
* fix comments for which place to edit

 solution should be placed in this line, previous comments was missleading.
as discussed in https://github.com/freeCodeCamp/freeCodeCamp/issues/44049

* shorter comments

clear of not needed ward Only

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

letter fixes

Co-authored-by: Ilenia <nethleen@gmail.com>

* fix for spelling of Change

only letter change

* fix for italian language

all other languages

* revert

revert of changes that will be done in other place

* revert

Co-authored-by: Ilenia <nethleen@gmail.com>
2021-10-29 12:37:01 +02:00
Oliver Eyton-Williams
da9e6ad0c1 fix(curriculum): consts must be initialized 2021-10-27 19:42:45 +05:30
Kristofer Koishigawa
bcc9beff1f feat(curriculum): introduce let and const earlier (#43133)
* fix: move "Explore Differences Between..." to basic JS, update seed and tests

* fix: resequence "Declare String Variables"

* fix: move "Declare a Read-Only Variable..." to basic JS, update seed and tests

* fix: revert changes to non-English "Explore Differences Between..." test text

* fix: revert test strings, solutions, and seeds for non-English challenges

* fix: update "Declare String Variables" description

* fix: sync quotation marks in description and seed

* fix: modify note in "Declare a Read-Only..." challenge

* fix: update operator and compound assignment challenges

* fix: update string challenges

* fix: update array and array method challenges

* fix: update function and scope challenges, resequence slightly

* fix: "Word Blanks" solution

* fix: add spacing to seed

* fix: concatenating += challenge spacing

* fix: appending variables to strings spacing

* fix: find the length of a string spacing

* fix: removed instances of removedFromMyArray = 0

* fix: switch challenges

* fix: function argument and param spacing

* fix: update counting cards, object challenges, and record collection

* fix: finish rest of Basic JS section

* fix: introducing else statements solution

* fix: update spacing and wording

* fix: update wording for const challenge

* fix: update functional programming challenges

* fix: intermediate algorithms and cert challenges

* fix: revert some spacing and remove comments for fp challenge solutions

* feat: add notes with links to moved let and const challenges in first two es6 challenges

* fix: update es6 intro text

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/concatenating-strings-with-the-plus-equals-operator.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/finding-a-remainder-in-javascript.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/global-scope-and-functions.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/implement-map-on-a-prototype.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/declare-a-read-only-variable-with-the-const-keyword.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: concatenating strings with plus operator seed

* fix: add comments back to Declare a Read-Only Variable... seed

* feat: add es6 to basic javascript redirect tests for let and const challenges

* fix: revert "Concatenating Strings with Plus Operator" seed

* fix: move test file to cypress/integration/learn/redirects, separate redirect tests

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-10-25 17:55:58 +01:00
Nicholas Carrigan (he/him)
b36cdbafd1 chore: rename "part" to "step" (#43934)
* chore: rename part to step

* chore: update metas

* chore: more renaming

* chore: update tooling

* chore: update frontmatter

* chore(tools): title testing
2021-10-21 18:07:52 +01:00
Jeremy L Thompson
b8b86a65b8 fix issue #42850, test for setters adding properties (#43813) 2021-10-14 15:58:13 +02:00
Prathamesh Gawas
d3708422dd fix(curriculum): add test to check if the original variable is edited (#43791)
* fix: add test to check if variable is edited

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/regular-expressions/remove-whitespace-from-start-and-end.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2021-10-09 19:45:10 +02:00
Ilenia
78e28e2bd3 fix: reset regex.lastIndex when tests use test method (#43695)
* added regex.lastIndex = 0 to tests

* typo
2021-10-06 16:14:50 +09:00
Riadh Laabidi
304f245cd2 fix(curriculum): Remove outdated video (#43685)
* Remove outdated video from testing objects for properties challenge

* Remove outdated video from testing objects for properties challenge
2021-10-02 18:51:15 +02:00
prashantaghoshal
e4e74aa4f2 fix(curriculum): strip comments from code when testing (#43597)
* fix: update ES6-Compare Scopes of var and let

Fixes Issue: Adding a comment causes a valid answer to be wrong in ES6 > Compare Scopes of the var and let keywords

Fixes: #43578

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/compare-scopes-of-the-var-and-let-keywords.md

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof <60067306+gikf@users.noreply.github.com>
2021-09-29 11:13:41 +02:00
Kristofer Koishigawa
8c9ca6a2fa fix: replace JS algorithms and data structures bitly links (#41813) 2021-09-21 16:46:25 +01:00
Aaron McCollum
badeb6e2df fix(curriculum): reworded grammar to do without hyphen (#43487)
Suggesting the removal of "-" on line 29 in the description, as the comma before "such" is sufficient to separate the examples from the rest of the sentence.
2021-09-18 13:13:05 +01:00
vama
6996d54fe7 fix(curriculum): specify array is returned from the function (#43425)
* (fix)Sort an array alphabetically using the sort Method - Array is returned from the function #43417

* (mod)Curriculum - Adding explicit instructions so that function will return a sorted array #43417

* (fix)Curriculum - Correcting grammetic error in instructions #43417

* mod: updated transaltion message #43417

* fix: Curriculum - Updated grammatical error in instructions #43417

Co-authored-by: Vama Mehta <vama.mehta@inqubit.in>
2021-09-13 17:22:55 +02:00
EhEhRon91
9aea61d0df fix: conflicting info updated (#43394) 2021-09-10 15:40:39 +05:30
Tom
cfbc7e9283 fix(curriculum): console not repsonding properly issue (#43053)
* fix(curriculum): console not repsonding properly issue

* fix: refine instructions

* fix: add a test + reword to remove seed comments

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/understanding-the-differences-between-the-freecodecamp-and-browser-console.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove comments from dictionary

* fix: remove comments from i18n dictionaries

* Revert "fix: remove comments from dictionary"

This reverts commit 7f76d5a8ec.

* Revert "fix: remove comments from i18n dictionaries"

This reverts commit 54b1c12cfc.

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-08-27 17:57:08 +02:00
Patrick Lehmann
5371af7767 fix(learn): removed space from first sentence and added instruction to basic javascript challenges (#43198)
* sheesh

* added markdown formatting to challenge

* added formatting to keep space in concatenating strings with the plus equals operator

* Delete husky.sh

* added back in italian dictionary

* removed code formatting

* updating text formatting for challenges, removed space and added instruction

Co-authored-by: Pat Lehmann <patrick.lehmann@homes.com>
2021-08-24 10:26:45 -07:00
Ilenia
5f57667c7d fix: clarify slice-and-splice (#43170) 2021-08-11 17:00:44 +02:00
Ilenia
0de2cc97db fix: remove code tags from first prototype (#43158) 2021-08-10 14:44:14 +02:00
abfipes
db1a92611a fix(curriculum): repair of a small logical underdevelopment (#43116)
* repair of a small logical underdevelopment 

a> b is false if a == b

* Apply suggestions (fix small typo )

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-05 14:54:32 +02:00
Julius Lee
a34921a5b3 fix(curriculum): add additional test case to fix hard code issue (#43086)
* fix: added additional matrix1 test case for different arguments to fix hard code issue #43050

* fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages

* Revert "fix: reduced additional test case to only 1 with zeroArray(4,3) and added to all languages"

This reverts commit bbbb1c7cbc.

* fix: only simplify and reduce to 1 test case using zeroArray(4,3), reverted internationalization

* fix: removed unused matrix1 from seed and solution

* update: for better wording of the added test case suggested

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>

Co-authored-by: gikf <60067306+gikf@users.noreply.github.com>
2021-08-02 12:37:50 -05:00
awu43
24250d278e feat(curriculum): rewrite capture groups description 2021-07-22 17:37:50 +02:00
awu43
b84e74ad42 fix(curriculum): improve lazy matching test regex (#42882) 2021-07-16 15:31:19 +01:00
Innocent V.I
ac2fe62eef fixed create-decimal-numbers-with-javascript challenge external link (#42801) 2021-07-09 09:02:47 -05:00
Braxton Excell
6631e51113 fix(curriculum): update object keys referenced in instructions to match provided object (#42613)
* Update referenced object keys for clarity

Because each movie object has both `Rated` and `imdbRating` key/value pairs, simply referencing `rating` could be confusing to campers. IMO explicitly referencing the keys by name (`Title` and `imdbRating`) removes ambiguity in the non-important part of this challenge and helps campers focus on learning about `.map()`.

* other references and tests

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

* reverse previous changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/functional-programming/use-the-map-method-to-extract-data-from-an-array.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-28 16:25:33 +02:00
dogfood654
e5505cbe7b fix(curriculum): minor indentation for readability (#42451)
* Fixed minor indentation for readability

* amended to 2 indentation
2021-06-16 14:35:34 +01:00
awu43
ae0d34359a fix(curriculum): stop false positives in test for array hard coding (#42461)
* Fixed test regex to avoid false matches

* Changed regex to only match values in globalArray

* Revert non-English changes
2021-06-15 10:35:35 -05:00
Ilenia
08fc4014c7 fix(curriculum): Removing genitive from inside backticks and backticks from word own (#42466)
* inherit-behaviors-from-a-supertype put genitive outside backticks

* override-inherited-methods genitive outside backticks

* reset-an-inherited-constructor-property genitive outside backticks

* use-prototype-properties-to-reduce-duplicate-code genitive outisde backticks

* use-prototype-properties-to-reduce-duplicate-code own without backticks

* removing genitive by rephrasing

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
2021-06-14 17:52:28 +02:00
Ilenia
ce3ccc47d4 fix(curriculum): remove unnecessary backticks (#42458) 2021-06-12 20:53:45 +02:00
zoembrown
ca2f024aec fix(curriculum): fixed typo in challenge (#42456) 2021-06-12 17:37:17 +02:00
Ilenia
28add4712a Remove backticks from around data types to ease translations (#42403) 2021-06-08 14:03:16 +05:30
Rebekah Koon
5a3d22e76b fix(curriculum): changing Charles -> Ada in JavaScript challenge descriptions (#42280)
* changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing Charles -> Ada in JavaScript challenge descriptions

* fix: changing firstName value from Ada to Augusta in javascript lesson
2021-05-29 21:33:21 +05:30
etlioglu
8b73920487 fix(curriculum): add items using splice verbiage
"The second entry of `12` is removed" is changed to "The second occurrence of `12` is removed". I believe the phrase "second entry" might create confusion as the readers might think of the second entry of the array rather than the second occurrence of the array element 12.
2021-05-24 13:33:25 -07:00