gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,542 Commits 9 Branches 0 Tags
d02e4e46ae769c8f45fd0cacbba8b373f105cbd3
Commit Graph

57 Commits

Author SHA1 Message Date
Evgeny Klimenchenko
db369fbed1 fix(client): remove JS comments from user code for tests (#41873) 
* Removes comments in js challanges by default

* fix local-scope-and-functions test regex

* fix all languages

* revert language changes

* removed unnecessary removeJSComments from challenges

* fix challanges in other languages

* removed removeJSComments from all challanges
 2021-04-28 10:18:54 -05:00
Nicholas Carrigan (he/him)
7117919d36 chore(learn): audit javascript algorithms and data structures (#41092) 
* chore(learn): audit basic algorithm scripting

* chore(learn): audit basic data structures

* chore(learn): audit basic javascript

* chore(learn): audit debugging

* chore(learn): audit es6

* chore(learn): audit functional programming

* chore(learn): audit intermidate algorithms

* chore(learn): audit js projects

* chore(learn): audit object oriented programming

* chore(learn): audit regex

* fix(learn): remove stray .

* fix(learn): string to code

* fix(learn): missed some

* fix(learn): clarify strings

Based on Randy's feedback, clarifies string instances where quotes
were removed in favour of back ticks.

* fix: apply suggestions - thanks Randy! :)

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: non-suggestion comments

* chore(learn): remove comments from codes

Removes the comments from the description and instruction code
blocks to ensure that all relevant information is translatable.

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: revert crowdin fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-algorithm-scripting/mutations.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-arrays.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* fix: Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* chore: change voice

* fix: Christopher Nolan

* fix: expressions would evaluate

* fix: will -> would

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix: to work to push

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-with-javascript-for-loops.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/object-oriented-programming/add-methods-after-inheritance.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-03-02 17:12:12 -07:00
Jagadeesh G
3061a5a0eb Text in Basic Data Structures lesson is better clarified. (#40492) 
* text_changes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-items-using-splice.md

Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>

Co-authored-by: Jagadeesh G <17941713+GJ-16@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com>
 2021-01-20 22:02:37 -07:00
Ismail Tlemçani
d6e47037de fix(learn): tests of the for in issue regarding the curly braces (#40344) 
* fix: fix the regex of the test of the challenge

* fix: fix data structure challenge

* fix: fix data structure challenge

* fix:fix the test regex of the challenge

* fix: fix the test regex
 2021-01-20 21:50:44 -07:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683) 
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
 2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams
0bd52f8bd1 Feat: add new Markdown parser (#39800) 
and change all the challenges to new `md` format.
 2020-11-27 10:02:05 -08:00
Mykyta Ivanchenko
cc464a6e56 fix(learn): Possible semantic error in explanation comment (#39813) 
* Possible semantic error

"identical" generally means that both variables are linked to exact same array which is not the case:
``` thisArray !== thatArray ```

Maybe "similar" or other word could be used instead

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/copy-an-array-with-the-spread-operator.md

Made the comment more accurate

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-10-14 19:53:49 -06:00
Oliver Eyton-Williams
2b9e38a17b fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Hassaan Pasha
80438cac3e feat(client, learn): add helper functions for common validation operations (#38605) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-09-17 19:38:01 +05:30
Oliver Eyton-Williams
bd68b70f3d Feat: hide blocks not challenges (#39504) 
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
 2020-09-03 15:07:40 -07:00
Jovani
aff56ac392 learn(fix) - fixed grammar because it was confuse to understand the sentence (#39188) 
* fix(learn): confusing grammar in copy array items using slice
 2020-07-09 01:20:08 +09:00
Nicholas Carrigan
43865fc098 fix(learn): function must return boolean, not string. (#39010) 2020-06-06 15:22:46 +05:30
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges 
This includes certificates (where it does nothing), but does not
include any translations.
 2020-05-25 16:25:19 +05:30
Ashraf Nazar
e10a046f8a fix(curriculum): use example in Modifying an Object Within a Nested Object challenge (#38468) 
* fix: use example in modifying an object within a nested object exercise to explain how to do so

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/modify-an-object-nested-within-an-object.english.md

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-05-15 16:41:40 -05:00
Ashraf Nazar
3a82e9f857 fix: add more examples on how to set key-value pairs (#38472) 
* fix(Curriculum): update examples on how to set key-value pairs

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-data-structures/add-key-value-pairs-to-javascript-objects.english.md

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* Update add-key-value-pairs-to-javascript-objects.english.md

* Update add-key-value-pairs-to-javascript-objects.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2020-04-22 11:20:30 -05:00
Shaun Hamilton
17585b63f8 added const to test string (#38583) 2020-04-21 09:12:53 +02:00
Randell Dawson
c401fc7f83 fix(curriculum): removed solution required comment from 6 challenges (#38339) 
* fix: removed solution required comments

* fix: fixed two more challenge soltuions with solution required comment

* fix: remove debugging code

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-03-09 13:58:46 +01:00
Tom
17a55c6e18 fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 1 of 4 (#38258) 
* fix: consolidate/remove comments

* fix: remove => from comment

* fix: reverted changes to add same changes to another PR

* fix: removed 'the' from sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: removed 'the' from the sentence

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2020-03-04 13:08:54 -06:00
Randell Dawson
6a7a7e6d7d fix(curriculum): Consolidated comments for JavaScript Algorithms and Data Structures challenges - part 2 of 4 (#38259) 2020-03-03 10:18:30 +03:00
Josh Soref
004b99bf8f chore: fix typos in spelling (#38100) 
* spelling: accidentally

* spelling: announce

* spelling: assembly

* spelling: avoid

* spelling: backend

* spelling: because

* spelling: claimed

* spelling: candidate

* spelling: certification

* spelling: certified

* spelling: challenge

* spelling: circular

* spelling: it isn't

* spelling: coins

* spelling: combination

* spelling: compliant

* spelling: containers

* spelling: concise

* spelling: deprecated

* spelling: development

* spelling: donor

* spelling: error

* spelling: everything

* spelling: exceed

* spelling: exist

* spelling: falsy

* spelling: faulty

* spelling: forward

* spelling: handle

* spelling: indicates

* spelling: initial

* spelling: integers

* spelling: issealed

* spelling: javascript

* spelling: length

* spelling: maximum

* spelling: minimum

* spelling: mutable

* spelling: notifier

* spelling: coordinate

* spelling: passport

* spelling: perform

* spelling: permuter

* spelling: placeholder

* spelling: progressively

* spelling: semantic

* spelling: submission

* spelling: submit

* spelling: translations

* spelling: turquoise

* spelling: visualization

* spelling: without

* spelling: registration

* spelling: representation
 2020-02-08 23:59:10 +05:30
Randell Dawson
2c15bcbb43 fix(curriculum): changed test text to use should for JavaScript Algorithms and Data Structures (#37761) 
* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>
 2019-11-27 11:57:38 +01:00
Randell Dawson
ba415184f6 fix(curriculum): simplify the Remove Items Using splice() challenge without using reduce (#37829) 
* fix: simplify challenge without using reduce

* fix: prevent user from adding new elements to sum to 10

* fix:  add from

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
 2019-11-26 15:14:44 -05:00
Sahil Bondre
335600d91c fix: change the explanation of splice function (#36721) 2019-08-30 13:59:56 +02:00
joelzehring
992fc8f1bf Update generate-an-array-of-all-object-keys-with-object.keys.english.md (#36578) 
Method should act on any passed parameter rather than the specific object named in this problem.
 2019-08-11 11:42:19 -05:00
Randell Dawson
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson
ba6ae7154c fix: removed more assert msg arguments (#36439) 2019-07-28 05:16:04 +01:00
Randell Dawson
d78168f7db fix(curriculum): Remove unnecessary assert message argument from English challenges JavaScript Algorithms and Data Structures - 03 (#36403) 
* fix: rm assert msg basic-data-structures

* fix: rm assert msg intermed-algo-scripting

* fix: rm assert msg data-structures projects
 2019-07-24 10:56:38 +02:00
Oliver Eyton-Williams
7d4dc382b4 fix(curriculum): format challenge markdown as per linting rules (#36326) 
* fix: Format challenge markdown according to linting rules

* fix: Put spaces after section tags
 2019-07-19 15:30:17 +05:30
Randell Dawson
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Randell Dawson
3fa14df925 fix: renamed folder without starting dash (#36124) 2019-06-21 18:05:33 -04:00
Randell Dawson
f53ca79890 fix: changed tests to allow other valid solutions (#36210) 2019-06-21 18:04:30 -04:00
Randell Dawson
5a06b71ac4 fix: modified tests text (#36169) 2019-06-04 16:14:52 -04:00
Matt Schlosser
08c4807b09 Added missing </code> in test text string (#36040) 2019-05-14 10:06:55 +02:00
Tom
93e5554615 fix: added semi-colon not in original code 
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>
 2019-05-07 10:43:43 -07:00
Randell Dawson
5cfff58c7b fix: added all js to end of 3 backticks 2019-05-07 10:43:43 -07:00
Randell Dawson
5cf039e5fd fix: performed first conversions 2019-05-07 10:43:43 -07:00
Randell Dawson
1cb6092dd9 fix: performed first conversions 2019-05-07 10:43:43 -07:00
Randell Dawson
3bff4151cf fix: rewrote challenge instructions and tests (#35899) 2019-04-30 20:19:06 -05:00
RIHANE ZAKARIA
6630b2be7a bug fix / test of Spread Operator javascript challenge / english (#35856) 
* bug fix test with the Spread Operator

* test of Spread Operator javascript challenge / english / change test and add a helper function
 2019-04-30 18:37:26 -05:00
Randell Dawson
6a859ee7f9 fix: added 12 missing solutions to Basic Data Structure Challenges (#35744) 2019-04-10 21:03:15 +05:30
Guayo Mena
75293e649d fix(curriculum): Fix test in Javascript challenge (#35795) 
Fixes #35793

I rearranged the variables in one of the tests.
I just changed the english file. Should I change the rest of the languages as well?

Note: I did this change through github's API, because I couldn't run the project locally so I haven't actually tested it.
 2019-04-10 20:55:05 +05:30
Ruchika Sharma
25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Pete
41ffe5a7e4 Adding-missing-challenge-solution (#35025) 
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
 2019-02-26 03:44:33 -05:00
Lewis Horwood
9cf283aab9 Add tests reflecting #19390 (#19477) 
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
 2019-02-23 00:16:06 +05:30
TristanSeabrook
d8c8ee73a3 added apostrophe (#35354) 
changed "keys" to "key's"
 2019-02-22 03:12:23 -08:00
TristanSeabrook
7d9ef880c2 removed ungrammatical apostrophe (#35353) 
Changed "array's" to "arrays".
 2019-02-22 03:12:12 -08:00
Casey Bennington
d2286fc3b5 Added solution (#28907) 
LGTM!
 2019-01-25 10:17:46 -05:00
Valeriy
79d9012432 fix(curriculum): quotes in tests (#18828) 
* fix(curriculum): tests quotes

* fix(curriculum): fill seed-teardown

* fix(curriculum): fix tests and remove unneeded seed-teardown
 2018-10-20 23:32:47 +05:30
greggubarev
345dfd6dad Added </code> to test text (#19498) 2018-10-16 15:28:33 +01:00
Jonathan Grah
65d47b6eeb fix: solution for checking if an object has a property (#19390) 
Signed-off-by: Jonathan Grah <theflametrooper@gmail.com>
 2018-10-15 16:04:24 -07:00