c345bc9886
fix: removed scrimba video links that do not reflect current challenge ( #39559 )
2020-09-11 11:17:50 -05:00
b93785be5d
fix(learn): update example image URL ( #39530 )
...
Update example URL in "Add Images to Your Website" challenge to point to example image on https://freecatphotoapp.com .
2020-09-05 10:27:27 -07:00
3425dadb46
Use JQuery to solve Catastrophic Backtracking with regex ( #39112 )
...
* Use JQuery to solve Catastrophic Backtracking with regex
* fix: improve regex for last test
* fix: improved the other tests with regex
* fix: change regex to allow spaces
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-04 16:06:57 -05:00
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
2020-09-03 15:07:40 -07:00
3836ce08e3
fix(learn): add for and id attributes to label and input ( #39019 )
...
* add value and id attributes
* revert prettier format changes
* fix whitespace changes
* Revert "fix whitespace changes"
This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.
* fix typo
* fix: conflict I forgot to resolve
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-02 15:19:47 +01:00
71051fef50
fix(Curriculum): make sure the nested input element in the form is th… ( #38480 )
...
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: use backticks to avoid linting error
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
2020-08-30 22:50:46 -07:00
fe3f0b2ac4
fix: remove quotation marks from code tag text ( #38316 )
2020-08-30 22:53:09 -05:00
9c3de2df24
added test to assert h1 is before h2 ( #39040 )
2020-08-30 22:13:30 -05:00
ed6246b91a
update description of "Nest an anchor element in a paragraph" as discussed in #38507 ( #38524 )
...
* remove parenthesis from description
As discussed in #38507 , I'm removing the phrase in parenthesis
* more succint description
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2020-08-30 22:01:40 -05:00
8ebb4922d4
fix(learn): updated catphotoapp links ( #39215 )
2020-07-15 15:26:49 +05:30
db6d97142a
fix: remove whitespace to test solution ( #39210 )
2020-07-08 15:13:02 -05:00
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges ( #38339 )
...
* fix: removed solution required comments
* fix: fixed two more challenge soltuions with solution required comment
* fix: remove debugging code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-03-09 13:58:46 +01:00
66e5cf0051
fix(curriclum): modified add images to your website ( #38155 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-02-04 20:12:53 +05:30
aac1c58374
fix(curriculum): make last test more robust for Uncomment HTML challenge ( #37843 )
...
* fix: correct last test
* fix: remove forgotten console.log
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-30 23:09:48 -05:00
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-11-20 20:15:19 +05:30
bfa5c26288
fix: use dfn instead of code tag ( #36640 )
...
* Use dfn tags
* remove misused <dfn> tags
* Revert "remove misused <dfn> tags"
This reverts commit b24968a968
.
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Make "array" lowercase
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Fix dfn usage
* Address last dfn tags
2019-10-27 12:45:37 -04:00
93360f4e01
fix:Typo in uncomment-html page ( #36800 )
...
* fix:Typo in uncomment-html page
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md
removed comma
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-09-18 10:51:55 -07:00
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
cbbfc08108
fix: removed more assert msg args ( #36441 )
2019-07-24 13:13:06 +01:00
87615d2a7b
fix: removed assert msg argument ( #36406 )
2019-07-24 11:50:51 +02:00
7d4dc382b4
fix(curriculum): format challenge markdown as per linting rules ( #36326 )
...
* fix: Format challenge markdown according to linting rules
* fix: Put spaces after section tags
2019-07-19 15:30:17 +05:30
c387873640
fix(curriculum): added extra line before </section> tag - Engl… ( #36278 )
2019-07-19 15:30:17 +05:30
a32f719d3a
Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge ( #36186 )
...
* fix: add test for input closing tag
* fix: add condintion to final syntax test
This wil test if there's any character after the input tag that isn't a white space
* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
2a18b1a308
Consistency Update for label and input elements for last lessons ( #36192 )
...
* Updated to reflect the relationship between label and input elements
* Updated to reflect the relationship between label and input elements
2019-06-09 20:47:50 +01:00
df8659ab8c
fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design ( #35993 )
...
* fix: converted blockquotes to code fences
2019-05-14 10:11:58 +02:00
a40451feaa
Define the Head and Body of an HTML Document for challenge solution ( #35826 )
...
* Define the Head and Body of an HTML Document for challenge solution
* edit on check the body tag contain h1 and p tags
2019-05-06 16:44:57 +02:00
722b65d80f
fix(curriculum): Add solutions to HTML challenges ( #35766 )
...
* fix(curriculum): Add solutions to HTML challenges
* Remove extra anchor element
2019-04-22 11:37:05 +05:30
63fc21f702
Update videoURL for HTML5 Elements challenge ( #35802 )
2019-04-14 09:20:36 -07:00
42bc9fa9b6
fix(curriculum): Made tests not accept invalid HTML ( #35774 )
...
* fix: made tests stricter
* fix: simplify text
Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com >
2019-04-10 19:21:52 +05:30
f91dea9b5c
fix(challenge): update text to give an explanation of wrapping ( #34811 )
...
* fix(challenge): update text to give an explanation of wrapping
* fix(challenge): simplify challenge text
* fix(challenge): update challenge text add solution
* fix(challenge): remove line breaks
* fix(challenge): make second instruction more clear
2019-04-04 22:49:21 -04:00
be687977cf
fix(challenge): add .english to file name ( #35687 )
2019-03-27 06:38:25 -07:00
d9213b38cd
fix(challenge): remove child selector from name attribute test ( #35423 )
2019-03-27 11:33:41 +05:30
33edc072b9
Use the correct element name in <code> blocks, gloss it seperately ( #35616 )
...
* Update link-to-external-pages-with-anchor-elements.english.md
If you write "`anchor` element" instead of "`a` element", you should also write "`hyperreference` attribute", instead of "`href` attribute".
Suggestion: write "`a` (_anchor_) element", or "anchor (`a`) element", to communicate the element name explicitly and gloss it at the same time.
The `<code>` sections should be valid code as far as possible.
* Change md to html
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
* Revert "Don't mark up 'anchor' as code"
This reverts commit 50c6a3a7c9
.
* Don't mark up 'anchor' as code
The tag is `a`, the name is _anchor_.
2019-03-25 10:50:33 -05:00
98e68d04be
feat(curriculum): Add challenge on using the value attribute ( #35301 )
...
* feat(curriculum): Add challenge on using the value attribute
fix(challenge): update file name and add comma
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/use-the-value-attribute-with-radio-buttons-and-checkboxes.md
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
Apply suggestions from code review
Co-Authored-By: lasjorg <28780271+lasjorg@users.noreply.github.com >
* fix(challenge): update tests
2019-03-24 18:43:05 -05:00
bc72c86dc6
fix: updated the note sections for responsive web design english ( #35528 )
2019-03-22 15:02:12 +01:00
228d873dd3
Fix: remove quote from challenge where not needed [english] ( #35493 )
2019-03-19 15:04:03 +05:30
0ffdae1093
Fixed interpunction in the introduction paragraph ( #32157 )
...
* Fixed interpunction in the introduction paragraph
* fix: made suggested change
2019-03-12 14:53:17 -07:00
9ebaa10eea
added clarification in test text ( #26458 )
...
* added clarification in test text
fix to issue #17490
* moved the note from the test text to description
* fix: updated note sytnax
2019-03-08 14:01:47 +05:30
1957b1f636
fix: added test case and working solution for empty li elements in the 'Create an ordered list' challenge. ( #35177 )
...
* fix: added test case for empty li elements
* fix: added error message in test case of empty li elements.
* fix: corrected error in test case.
* fix: added valid working solution
* fix: migrated test case to challenge: create-an-ordered-list (working solution included)
* fix: adjusted condition for empty li elements and fixed typo.
2019-03-01 23:50:09 +05:30
ab456a9a94
fix: changed js to html in solution section ( #35414 )
2019-02-25 22:50:58 -05:00
0c652e3ace
feat: curriculum-basic-html-form-element-solution ( #34956 )
2019-02-25 22:23:08 -05:00
aa621a20b5
fix: removed unecessary guideUrl from frontmatter
2019-02-19 11:34:27 +03:00
2e388035ca
Fix/update challenges for basic html and html5 ( #35234 )
...
* fix: challenge for basic html and html5 - test
* Delete use-if-and-else-to-add-logic-to-your-styles.english.md
* fix: Resolving merge conflict
* fix: basic-html-and html5 challenge - test
2019-02-18 01:49:21 +05:30
4734ff4154
nest anchor within paragraph instructions modification ( #26441 )
...
* modified wording to be more clear
wording on challenge instructions may have been unclear to some campers
changes "your" to "the" existing <code>a</code> element to make it more clear
* fix: removed change not needed
2019-02-17 23:54:13 +05:30
ec9fffb222
solution to Challenge ID:bad87fee1348bd9aedd08835 ( #33391 )
...
* solution to Challenge ID:bad87fee1348bd9aedd08835
solution to Challenge ID:bad87fee1348bd9aedd08835 - Check Radio Buttons and Checkboxes by Default
* fix: solution
2019-02-15 11:19:03 -08:00
2b91676e72
Expected solution for the challenge seed code ( #32523 )
...
* Expected solution for the challenge seed code
I have updated the expected output for the challenge seed code.
* fix: corrected solution section syntax
2019-02-14 14:35:21 -05:00
08b9c3c7fb
I have updated the solution for this file. ( #31749 )
...
* I have updated the solution for this file.
I have added the expected output of the challenge seed code.
* Update add-a-submit-button-to-a-form.english.md
Placed solution in ```html tags
* Update add-a-submit-button-to-a-form.english.md
2019-02-14 11:28:40 -08:00