Joseph Mawa
d5000b5d0f
Removed note about promise chaining as suggested in issue #39487 ( #39609 )
2020-09-18 10:30:37 -05:00
Gaurav Khairnar
a338d4b79d
fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson ( #39587 )
2020-09-17 13:00:58 -05:00
Hassaan Pasha
80438cac3e
feat(client, learn): add helper functions for common validation operations ( #38605 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-17 19:38:01 +05:30
Randell Dawson
30c61b808b
fix: consolidate misc comments ( #39583 )
2020-09-16 13:29:50 -05:00
Randell Dawson
b9c9a95223
chore(learn): Renamed all project-based curriculum project step filenames to use 3-digit format of part-ddd.md ( #39463 )
...
* fix: renamed basic html cat photo app steps
* fix: renamed css-variables project steps
* fix: renamed d3-dashboard filenames
* fix: renamed rpg-game filenames
* fix: renamed functional-progamming-spreadsheet filenames
* fix: renamed calorie-counter project filenames
2020-09-16 11:54:12 +05:30
Kris Koishigawa
4f1be63055
feat(learn): sync master and next-curriculum branches
2020-09-16 11:54:01 +05:30
Tom
dae411d408
fix: failing test ( #38253 )
2020-09-16 11:54:00 +05:30
lmilliken
9ba1f1f6d0
feat: tests for calorie counter
...
split up calorie counter lesson
2020-09-16 11:54:00 +05:30
Kris Koishigawa
b99d78858b
fix: basic js rpg spacing and tests
...
Replaced tabs with spaces so spacing is consistent in the monaco editor. Also adjust some tests to account for the new loop protection.
2020-09-16 11:54:00 +05:30
lmilliken
39b0afd5f0
feat: tests for calorie counter
2020-09-16 11:54:00 +05:30
Kristofer Koishigawa
d3d5147c1f
fix: renamed files and titles in the frontmatter for consitency ( #37792 )
2020-09-16 11:53:59 +05:30
SomeDer
2fbafda167
feat: functional programming spreadsheet ( #36873 )
...
* Add meta.json for spreadsheet
* Add spreadsheet files
* Close code tags for tests in 2 files
* Add solution section
* Add index file
* Add javascript-spreadsheet to stringifier
* Move index to step
* Rename steps in meta.json
* Rename step numbers in files
* Add index file to proper location
* Remove inappropriate files from spreadsheet dir
* Fix typo in first step
* Fix test sections
* Rename files to correct step
* Fix broken tests
* Add newline between sections
* Change challengeType from 1 to 0
* Add missng ) in step-079.md
* test -> tests in step-079
* Simplify test in step-103
* Fix step-137 test
* Remove last step
* Added solutions and adjusted some tests
* Fix some challenges
* Remove wrong spaces
* Fix more tests
* Add missing semicolon
* Fix more tests
* Fix type: lastttwo
* Fix all remaining tests
2020-09-16 11:53:59 +05:30
Kristofer Koishigawa
529f2596d9
feat: JS RPG game tests ( #37678 )
...
* feat: Add JavaScript RPG Game for testing
2020-09-16 11:53:58 +05:30
Aleksa S. Stevic
5cb609dc5c
Changed "statement" to "expression" ( #39564 )
...
The ternary operator doesn't allow statements, just expressions.
2020-09-12 10:37:59 +02:00
Randell Dawson
c345bc9886
fix: removed scrimba video links that do not reflect current challenge ( #39559 )
2020-09-11 11:17:50 -05:00
Lasse Jørgensen
2743ac2e84
fix(challenge): update variable names, assign empty array, update solution code, remove "use strict" ( #39525 )
...
* fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"
* fix(challenge): update solution code
* fix:(challenge) update instructions and variable name
* fix:(challenge) update instructions
2020-09-09 19:58:27 -05:00
Siddharth Pathak
5418307936
fix(learn): add whitespace check to else-if test ( #39555 )
2020-09-09 20:30:33 +01:00
Tom
b79a332984
fix: remove scrimba link for inaccurate video ( #39545 )
2020-09-08 13:09:53 -07:00
Mrugesh Mohapatra
c23c4ef8e4
fix: negative sentiment → neutral language ( #39522 )
...
The existing terminology carries negative sentiment that can be
interpreted in a racial or sense. Updating the name to have no
potential for such a connection.
Co-authored-by: Justin Rogers <justrog@gmail.com>
2020-09-07 11:04:44 +05:30
Oliver Eyton-Williams
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
2020-09-03 15:07:40 -07:00
Ishu Singhal
56469d1c5c
fix(learn): update tests to allow more valid solutions ( #39054 )
...
* fix(curriculum): updated tests: fixed #39049
It won't pass something like this now:
const myConcat = () => {};
console.log(3);
* fix: add suggested change
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 15:28:35 +01:00
skaparate
f97c847e29
fix(learn): formatting bug preventing tests to pass ( #39045 )
...
* implemented object validation
* fix: formatting bug preventing tests to pass
* implemented object validation
* fix: formatting bug preventing tests to pass
* integrated changes again
* added suggested changes
* fix: refine instructions
* fix: revert some bad instructions and change album to albumTitle
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-09-03 12:34:12 +01:00
bhagerty
046137891e
fix(learn): clarify how object names are associated with destructured fields ( #39485 )
...
* Clarify how object names are associated with destructured fields
* fix: make description more concise
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-pass-an-object-as-a-functions-parameters.english.md
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-09-02 19:06:27 +01:00
bhagerty
db15a44160
fix(learn): clarify instructions to remove confusion ( #39479 )
...
* Clarify instructions to remove confusion
* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2020-09-02 18:41:59 +01:00
Tom
9cd4b93601
fix(learn): getter setter instructions ( #39512 )
...
* Update use-getters-and-setters-to-control-access-to-an-object.english.md
* fix: revert changes, keep example
Co-authored-by: Daniel Sing <danielsingsong@gmail.com>
2020-09-02 18:07:17 +01:00
Joshua Pelealu
a050de56bb
Fix: Running Test with a comment fails test on Understand The immediately invoked function expression iife ( #39347 )
...
* Update Regex to test if it's an IIFE instead of checking for a parenthases at the end.
* Second Test will now pass the test
* Escape One Parenthese
* Update Regex to be more structured
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
* Missing regex ending literal
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2020-09-01 18:48:32 -05:00
Mayank Chauhan
e7718e5c3f
fix(learn): improved tests for validating incrementer function ( #39385 )
...
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md
* Update avoid-mutations-and-side-effects-using-functional-programming.english.md
* fix typo in avoid-mutations-and-side-effects-using-functional-programming.english.md
2020-09-01 08:44:24 -07:00
Beau Carnes
f334734e98
feat: split JS challenge into two ( #39044 )
...
* feat: split JS challenge into two
* fix/change-to-not-use-untaught-assignments
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-08-31 19:44:56 +01:00
Yasmin Yazdi
cf82a2b33e
fix global flag fail in Regex by resetting last Index ( #39457 )
...
* fixing global flag fail by resetting last index. Issue #37890
* fixed syntax error
* making requested changes
2020-08-31 16:59:42 +05:30
Ryan-Chu
bd02c989df
fix(curriculum): rename variable to avoid conflict ( #39428 )
2020-08-19 16:47:30 +02:00
Mike Robinson
e7d2028bba
fix(learn): change test order to test for the value after execution has finished ( #39363 )
...
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2020-08-05 01:18:50 +05:30
dyneskye
f52baa51be
fix(learn): Added test for Capitalized -> uncapitalized variants
...
* myReplace("I think we should look up there", "up", "Down")
* Checks for previously unchecked scanarios of the 'after' input being capitalized and 'before' word being uncapitalized.
2020-08-03 14:52:40 +03:00
Nakul Nambiar
e4960e38ef
fix(curriculum): Removed global variable and updated test for "Functional Programming: Apply Functional Programming to Convert Strings to URL Slugs" ( #39359 )
...
* Fixed Some Typos
* Removed global variable and updated tests
Co-authored-by: nakulnambiar <nakul.nambiar@demandfarm.com>
2020-08-02 16:24:16 -07:00
anthony
20d397f719
remove MDN links from English challenges ( #39337 )
...
* remove MDN links from English challenges
* add push challenge reference to record-collection
* refactor truthy falsy verbiage
* replace MDN link with news link
* remove unnecessary whitespace
2020-07-31 15:19:49 +09:00
dyneskye
4b7ad8447b
fix(learn): Added test for edge case ( #39323 )
...
* fix(learn): Added test for edge case
* Test checks edge cases for incorrect spelling in middle characters.
* fix: removed 'pen' sageTest
* the 'pen' points out that it is not the end of the first word to be tested for, but the end of the string.
However, this is explained clearly in the 'mountain' test below just as well.
2020-07-27 07:43:59 -07:00
Kushagra
0b700b5f78
fix(learn): clarify description for finders keepers ( #39068 )
...
* fix(learn): clarify description for finders keepers
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-07-14 09:29:53 +02:00
Bianca Zanardi
35f24c6085
Fix text inconsistency ( #39203 )
...
* Fix text inconsistency
To match the eight ECMAScript Language Types on the previous paragraph.
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
2020-07-09 16:18:11 +02:00
Jovani
aff56ac392
learn(fix) - fixed grammar because it was confuse to understand the sentence ( #39188 )
...
* fix(learn): confusing grammar in copy array items using slice
2020-07-09 01:20:08 +09:00
PeterF521
511238d36e
challenges: description improvement ( #39197 )
...
Co-authored-by: PeterF521 <peterf521@gmail.com>
2020-07-07 06:10:04 -07:00
Nicholas Carrigan
2aee480c46
Remove example code from challenge seed ( #39083 )
...
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-06-22 16:13:21 +05:30
Kushagra
be4070a73d
fix(curriculum): improve test robustness ( #39004 )
...
* Add: // Only change code...comments
* Allow user to modify bob
2020-06-13 11:47:06 +02:00
Nicholas Carrigan
43865fc098
fix(learn): function must return boolean, not string. ( #39010 )
2020-06-06 15:22:46 +05:30
Nicholas Carrigan
62dcb1f3fa
fix(curriculum): remove whitespace typo ( #39009 )
2020-06-05 16:08:38 +02:00
jasnkwcz
95371f92b3
fix(learn): clarify formatting requirements for multiple ternary operators challenge ( #38993 )
...
* fix(learn): clarify formatting requirements for multiple ternary operators challenge
Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
2020-06-03 18:33:03 +02:00
JapneetSingh5
87ef15befa
Fixes a broken link to 'undefined is a keyword' ( #38897 )
...
Fixes a broken link to 'undefined is a keyword' by replacing the wrong link with the correct one.
2020-06-02 16:22:59 +09:00
Aditya Nagla
a6c2b5ee1d
fix(curriculum) remove unnecessary */
from description ( #38969 )
2020-05-31 10:49:10 -05:00
John Montgomery
5cd850f666
Update wording of what multiplyAll
should do in "Nesting For Loops" ( #38852 )
2020-05-31 08:16:00 -05:00
DaVicki
2e819b2e0a
fix(curriculum): update instructions ( #38865 )
...
* fix(learn): update instructions
edited text - change "returns a random number" to "returns a random whole number" to be more clear on the problem statement.
Address review comments : add the keyword "whole" to description, to make it consistent with challenge title and Instructions.
2020-05-29 10:56:17 +02:00
PRAKASH
3c3ceaa3f5
Update declare-javascript-variables.english.md ( #38884 )
2020-05-27 09:37:34 +02:00
Oliver Eyton-Williams
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30