Commit Graph

34 Commits

Author SHA1 Message Date
mdSrq
d53a457fc2 Fix typo mentioned in issue #44761 (#44768) 2022-01-12 21:35:28 -08:00
Shaun Hamilton
ef417c95f9 fix(curriculum): make english to i18n easier (#44711) 2022-01-12 10:03:26 -06:00
Juan Alberto González
9655cd26a1 fix(curriculum): typo in cat photo app (#44757) 2022-01-12 11:08:37 +01:00
Etkesmeci
43f970aa3f fix(curriculum): Additional clarification in hint (#44746) 2022-01-11 15:32:37 +01:00
Jim Kernicky
09a41ccd38 fix(curriculum): typos in building-a-piano (#44729)
* fix(curriculum): typos in BETA  Piano Build section

* Added back the id and class characters

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-10 13:35:59 +01:00
Reuben Menezes
72d989c681 fix(curriculum): correct spelling error (#44727)
Changed the incorrect spelling (rbg) to the correct spelling (rgb)
2022-01-09 07:11:18 +01:00
Jim Kernicky
3416a4adef fix(curriculum): typos in balance-sheet (#44693)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-08 15:53:47 +00:00
Etkesmeci
9cbd7f3b28 fix(curriculum): "locaton" changed to "location" (#44717) 2022-01-07 19:15:11 +01:00
Etkesmeci
82c4bf9556 fix(curriculum): possible typo and simplification (#44704)
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-07 16:36:49 +05:30
Darshan Vaishya
9b6dc9ee34 fix(curriculum): clarify instruction regarding color (#44688)
* Added instruction to clarify color should be red

* Added comma before "and" for punctuation

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
2022-01-06 20:26:43 +01:00
Jim Kernicky
340581e888 fix(curriculum): typos in accessibility-quiz (#44681)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-05 09:36:58 -08:00
Krzysztof G
75f64d1728 fix(curriculum): change tests to make them pass on firefox (#44685) 2022-01-05 09:12:10 -08:00
Etkesmeci
ddbe5f3fc0 fix(curriculum): typo in cat-photo app (#44678)
There was a typo in tenth line. I changed it from "withing" to "within".
2022-01-05 09:02:16 -08:00
Jim Kernicky
f04ec72c44 fix(curriculum): typos in rothko-painting (#44644)
* fix(curriculum): typos in Rothko Painting section

* Set step 36 back to original wording

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-04 21:09:41 +01:00
Jim Kernicky
c704895614 fix(curriculum): typos in camper-cafe-menu (#44629)
* Fixed typos in Beta CamperCafe lessons

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-basic-css-by-building-a-cafe-menu/step-060.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2022-01-04 16:48:27 +00:00
Jim Kernicky
7af4a564c0 fix(curriculum): fix typo in registration-form (#44641)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-04 12:18:45 +00:00
Bruce B
418480782a fix(curriculum): convert to placeholder attr (#44661) 2022-01-03 22:50:54 +01:00
Eric Cheng
3e797480ed fix: allow usage of gray in css (#44633) 2022-01-03 13:16:37 +01:00
Jim Kernicky
386d897671 fix(curriculum): typos in Nutrition Label section (#44652)
* fix(curriculum): typos in Nutrition Label section

* Deleted tream file from last commit

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-03 08:29:07 +01:00
Bruce B
070ef7bb09 fix: rwd beta - ferris wheel step 1 html test (#44625)
* fix: rwd beta - ferris wheel step 1 html test

* fix: update regex to require new line/remove caret
2022-01-01 18:35:27 -08:00
Jim Kernicky
a9852c7180 fix(curriculum): typos in Beta Colored Markers section (#44631)
Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2022-01-01 18:27:47 -08:00
Jack Howard
2a3e344d13 fix(curriculum): remove extra "\" from description (#44615)
Noticed an extra "/" in the text file on
2022-01-01 18:18:13 -08:00
Karalee Conover
a72326cea1 fix(curriculum): spelling of cinnamon in RWD Camper Cafe Menu (#44635)
* Change Sp from Cinammon to Cinnamon Steps 54-92

* Step 53 Changed sp of Cinammon to Cinnamon

* Fix spelling of Cinnamon Step 92 L250
2022-01-01 18:13:11 -08:00
Buntu Redempter
1a9a48911f fix(curriculum): remove "is" in the description (#44592) 2021-12-30 07:03:18 +01:00
Jim Kernicky
d29a09ebbb fix(curriculum): improve wording (#44605)
* Fix: Removed words from steps 42 & 58, made changes to steps 41 & 45 (Beta)

* Made the suggested change by removing the word 'Note'

* Changed 'last' to 'previous' in step 58

Co-authored-by: “Jim” <“jimkernicky@gmail.com”>
2021-12-30 06:54:43 +01:00
Bruce B
46ba5f5cbd fix(curriculum): css tests for firefox in beta rwd (#44598)
* fix: css tests for firefox in beta rwd

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-059.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-025.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-accessibility-by-building-a-quiz/step-061.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2021-12-29 00:05:58 -08:00
Najmieh Sadat Safarabadi
73e3565707 fix(curriculum): add missing word in instructions - step 31 (#44607)
* Edited Missing Word in instructions- Step 31

Learn HTML Forms by Building a Registration Form - Step 31 - missing word in instructions

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-html-forms-by-building-a-registration-form/step-031.md

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>

Co-authored-by: Krzysztof G. <60067306+gikf@users.noreply.github.com>
2021-12-28 19:06:55 -08:00
Buntu Redempter
b4acccbde9 Added "be" in the first paragraph (#44610)
Added "be" in the first paragraph of the description.
2021-12-28 19:05:28 -08:00
Bruce B
58aea70c9e fix: remove extraneous word from instructions (#44601) 2021-12-28 19:03:20 -08:00
Oliver Eyton-Williams
36363f277d test: enable tests for steps (#44550)
* fix: handle missing solutions correctly

Rather than creating an [[]] the parser now creates [] which isEmpty().
This makes the test suite check the next challenge for a solution.

In addition, the logic for testing solutions was fixed.

* chore: update snapshots

* test: build new superblock in node.js-tests CI

* test: allow forward slash in superblock slug

* fix: borked tests oops

* test: ignore duplicated projects

* fix: i did not break these shaun did :)

* fix: idIndex is index of id not id

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2021-12-22 12:18:06 -08:00
Shaun Hamilton
10f0d3c07a fix: new practice project tests (#44554)
* fix accessibility-quiz and reg-form tests

(cherry picked from commit 467f0b3e78)

* fix: registration-form tests

* fix: ferris wheel tests

* fix: photo-gallery tests

* fix: magazine tests

(cherry picked from commit 5831c2345d)

* fix: picasso tests

* fix: piano tests

* fix: magazine and nutrition tests

* fix: again magazine...I am doing this in sill order

* chore: resolve discrepancies with tests

(cherry picked from commit a7b5e031df)

* fix: the stuffs...I am tired

* fix: oops

(cherry picked from commit 05ff55a036)

* fix: add missing solutions

(cherry picked from commit 61fa23fc70)

Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
2021-12-22 08:16:59 -08:00
Tom
e52990eb1c fix(curriculum): add missing solutions to last step of practice projects (#44544) 2021-12-21 23:03:09 +00:00
Kristofer Koishigawa
e878b3ee57 feat: add CSS Color Markers project (#44459)
* feat: first draft of CSS Color Markers project

* Update client/i18n/locales/english/intro.json

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-007.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-046.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-079.md

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>

* feat: begin adding tests

* feat: add more tests, fix wording and some CSS values

* feat: add more steps, fix wording

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* feat: add more tests, simplify some regex tests, fix wording

* fix: preformatted block names and help category map

* feat: finish first draft of color marker tests

* fix: simplify text involving classes

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-004.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-008.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-009.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-010.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-011.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-013.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-014.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-054.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-089.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/learn-css-colors-by-building-a-color-markers-set/step-094.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: add outro message to final CSS color markers step

* fix: make most regex tests case insensitive, add note about casing for filename

* correct double key from rebase

* remove jQuery for betterness

* move project to new superblock

* adjust meta to match others

* fix: add new to helper call

* regex-ise funny lessons

* unnecessary: add -22 superblock

* fix: make linter happy

* regex-ise missed challenges...oops

* Revert "fix: make linter happy"

This reverts commit 6e6e3cf503.

* Revert "unnecessary: add -22 superblock"

This reverts commit a58045607e.

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-005.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-010.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-052.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-053.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-054.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-055.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-056.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-057.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-058.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-059.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-062.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-063.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-064.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-065.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-068.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-069.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-color-markers-set/step-082.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>

* fix: rename project to "Learn CSS Colors by Building a Set of Colored Markers"

* Update curriculum/challenges/english/14-responsive-web-design-22/learn-css-colors-by-building-a-set-of-colored-markers/step-010.md

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* adjust superblock to include `2022/`

Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com>
Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-12-21 11:45:08 -08:00
Nicholas Carrigan (he/him)
8614db7a32 feat: enable new curriculum (#44183)
* feat: use legacy flag

chore: reorder challenges

fix: linter

revert: server change

feat: unblock new editor

fix: proper order

fix: 0-based order

fix: broke the order

feat: move tribute certification to its own block

feat: split the old projects block into 4

fix: put all blocks in order

chore: add intro text

refactor: use block, not blockName in query

fix: project progress indicator

* fix: reorder new challenges/certs

* fix: reorder legacy challenges

* fix: reintroduce legacy certs

* feat: add showNewCurriculum flag to env

* chore: forgot sample.env

* feat: use feature flag for display

* fix: rename meta + dirs to match new blocks

* fix: add new blocks to help-category-map

* fix: update completion-modal for new GQL schema

* test: duplicate title/id errors ->  warnings

* fix: update completion-modal to new GQL schema Mk2

* chore: re-order metas (again)

* fix: revert super-block-intro changes

The intro needs to show both legacy and new content.  We need to decide
which pages are created, rather than than what a page shows when
rendered.

* feat: move upcoming curriculum into own superblock

* fix: handle one certification with two superBlocks

* fix: remove duplicated intros

* fix: remove duplicate projects from /settings

* fix: drop 'two' from Responsive Web Design Two

* chore: rename slug suffix from two to v2

* feat: control display of new curriculum

* feat: control project paths shown on /settings

* fix: use new project order for /settings

This does mean that /settings will change before the release, but I
don't think it's serious.  All the projects are there, just not in the
legacy order.

* fix: claim/show cert button

* chore: remove isLegacy

Since we have legacy superblocks, we don't currently need individual
blocks to be legacy

* test: fix utils.test

* fix: verifyCanClaim needs certification

If Shaun removes the cert claim cards, maybe we can remove this entirely

* fix: add hasEditableBoundaries flags where needed

* chore: remove isUpcomingChange

* chore: v2 -> 22

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-12-20 12:36:31 -06:00