Stephan Düsterhöft
d6491a9902
fix(curriculum): Period added to the end of the sentence. ( #42480 )
...
Dot added to the end of the sentence.
2021-06-14 20:44:23 +05:30
Sem Bauke
607b1c3dbf
fix(curriculum): look for possible www link in regex ( #41955 )
...
* fix(curriculum): look for possible www. link in regex
* Add suggestions from Nick
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
Co-authored-by: Nicholas Carrigan (he/him) <nhcarrigan@gmail.com >
2021-05-06 10:06:33 +05:30
EboranBokaj
e45689d495
fix(curriculum): HTML-challenges: links are inconsistent. ( #41900 )
...
Co-authored-by: Ilenia <nethleen@gmail.com >
2021-04-26 22:34:53 +05:30
GDAD3
3fbe1ebc05
fix(curriculum): remove stale video from nest anchor element ( #41914 )
2021-04-24 02:47:35 +07:00
Ritesh Arora
ec761dbdfa
fix(curriculum): add target in challeges link ( #41876 )
2021-04-22 11:34:23 +07:00
Glitchy-Tozier
dbdc704271
fix(curriculum): give better instructions on alignment p-tags ( #41859 )
...
* Improve instructions
* Remove unneccessary line break
* Move empty line
2021-04-19 19:42:59 +02:00
Hassaan Pasha
d51460dba8
fix (curriculum): added top level label-input pair to challenge ( #41717 )
...
* fix (curriculum): added top level label-input pair to challenge
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-set-of-radio-buttons.md
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
Co-authored-by: Shaun Hamilton <51722130+ShaunSHamilton@users.noreply.github.com >
2021-04-05 08:41:31 +02:00
Sem Bauke
b064991667
fix(curriculum): Replace single-line blocks with multi-line blocks for Responsive Web Design ( #41519 )
...
* fix(curriculum) replace single-line block with multi-line blocks
* fix(curriculum) replace single-line block with multi-line blocks (missed blocks)
2021-03-18 17:24:09 -06:00
Randell Dawson
d2f4b70ea6
fix: remove end of line chars after code blocks ( #41498 )
2021-03-16 07:49:43 -07:00
Randell Dawson
c198d508be
fix(learn): Improve tests for the Nest an Anchor Element within a Paragraph challenge ( #41456 )
2021-03-12 10:09:22 -07:00
pandacoder7
53d372c298
fix: update challenge for crowdin in anchor page ( #41450 )
2021-03-11 13:35:34 -07:00
Ilenia
051a010798
fix(learn): disallow www link from challenge ( #41275 )
...
This commit disallows www link from "Nest an anchor in a paragraph" challenge.
2021-02-27 02:47:47 +05:30
Ilenia
aa615763af
fixed tests for link to external pages challenge ( #41191 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-21 11:46:00 +05:30
Nicholas Carrigan (he/him)
12658d33fc
fix(i18n, learn): more crowdin fixes ( #40905 )
2021-02-04 13:34:44 +05:30
Nicholas Carrigan (he/him)
b0bd3f5549
fix(learn): abstract comments from code ( #40869 )
2021-02-03 22:28:33 +05:30
Nicholas Carrigan (he/him)
4d48fb5ce7
fix(learn, i18n): crowdin issues ( #40884 )
...
Resolves a couple of issues with Crowdin parsing.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
2021-02-02 14:08:32 -07:00
Nicholas Carrigan (he/him)
427444c757
chore(learn): audit files for crowdin ( #40838 )
...
* chore(learn): audit files for crowdin
Audits the challenge text in the Responsive Web Design superblock to
account for words/phrases that should not be translated because they
refer to code.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove quotes from code
Removes instances of quoted code blocks, or code blocked quotes.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: additional uncaught quote-codes
Thanks Oliver :)
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: so many quotes
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
* fix: missing punctuation
Noted in a Crowdin comment.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
* fix: remove more quotes
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2021-02-01 12:56:07 -07:00
Evan Boehs
8c22432b17
fix(learn): add period for readability ( #40836 )
2021-01-31 13:57:46 +05:30
Randell Dawson
83e3d93953
fix(learn): Remove strong syntax around code inline code ( #40754 )
2021-01-21 13:40:19 +05:30
majkelmichel
3ecdfe87d7
Update create-a-form-element.md ( #40720 )
...
Improved wording in Description and Instructions sections
2021-01-16 12:25:13 -07:00
Thomas
fc976aba74
fix(learn): Change example text in create-a-form-element.md ( #40542 )
...
* Update create-a-form-element.md
Update example. For issue 40523
* Clearer formatting of example
2021-01-16 01:11:47 -08:00
Oliver Eyton-Williams
ee1e8abd87
feat(curriculum): restore seed + solution to Chinese ( #40683 )
...
* feat(tools): add seed/solution restore script
* chore(curriculum): remove empty sections' markers
* chore(curriculum): add seed + solution to Chinese
* chore: remove old formatter
* fix: update getChallenges
parse translated challenges separately, without reference to the source
* chore(curriculum): add dashedName to English
* chore(curriculum): add dashedName to Chinese
* refactor: remove unused challenge property 'name'
* fix: relax dashedName requirement
* fix: stray tag
Remove stray `pre` tag from challenge file.
Signed-off-by: nhcarrigan <nhcarrigan@gmail.com >
Co-authored-by: nhcarrigan <nhcarrigan@gmail.com >
2021-01-12 19:31:00 -07:00
Oliver Eyton-Williams
0bd52f8bd1
Feat: add new Markdown parser ( #39800 )
...
and change all the challenges to new `md` format.
2020-11-27 10:02:05 -08:00
Oliver Eyton-Williams
2b9e38a17b
fix: replace .english.md extension with .md
2020-09-29 22:09:04 +02:00
Hassaan Pasha
80438cac3e
feat(client, learn): add helper functions for common validation operations ( #38605 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
2020-09-17 19:38:01 +05:30
Ajeeth thangarasu
8db3fc2df4
removed videoUrl ( #39600 )
2020-09-16 19:01:47 -07:00
Oliver Eyton-Williams
d7dc1acb4a
chore: update lang tags on code blocks
2020-09-16 11:54:08 +05:30
Randell Dawson
c345bc9886
fix: removed scrimba video links that do not reflect current challenge ( #39559 )
2020-09-11 11:17:50 -05:00
Kristofer Koishigawa
b93785be5d
fix(learn): update example image URL ( #39530 )
...
Update example URL in "Add Images to Your Website" challenge to point to example image on https://freecatphotoapp.com .
2020-09-05 10:27:27 -07:00
PSN221B
3425dadb46
Use JQuery to solve Catastrophic Backtracking with regex ( #39112 )
...
* Use JQuery to solve Catastrophic Backtracking with regex
* fix: improve regex for last test
* fix: improved the other tests with regex
* fix: change regex to allow spaces
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-04 16:06:57 -05:00
Oliver Eyton-Williams
bd68b70f3d
Feat: hide blocks not challenges ( #39504 )
...
* fix: remove isHidden flag from frontmatter
* fix: add isUpcomingChange
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
* feat: hide blocks not challenges
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com >
2020-09-03 15:07:40 -07:00
Ashlee Crusco
3836ce08e3
fix(learn): add for and id attributes to label and input ( #39019 )
...
* add value and id attributes
* revert prettier format changes
* fix whitespace changes
* Revert "fix whitespace changes"
This reverts commit 9da78e58ce474b0f4a7cf076574e23961a6d3734.
* fix typo
* fix: conflict I forgot to resolve
Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com >
2020-09-02 15:19:47 +01:00
Ashraf Nazar
71051fef50
fix(Curriculum): make sure the nested input element in the form is th… ( #38480 )
...
* fix(Curriculum): make sure the nested input element in the form is the existing element given in the editor
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/create-a-form-element.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* fix: use backticks to avoid linting error
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Randell Dawson <rdawson@onepathtech.com >
2020-08-30 22:50:46 -07:00
Shaun Hamilton
fe3f0b2ac4
fix: remove quotation marks from code tag text ( #38316 )
2020-08-30 22:53:09 -05:00
tomki1
9c3de2df24
added test to assert h1 is before h2 ( #39040 )
2020-08-30 22:13:30 -05:00
Ieahleen
ed6246b91a
update description of "Nest an anchor element in a paragraph" as discussed in #38507 ( #38524 )
...
* remove parenthesis from description
As discussed in #38507 , I'm removing the phrase in parenthesis
* more succint description
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2020-08-30 22:01:40 -05:00
Randell Dawson
8ebb4922d4
fix(learn): updated catphotoapp links ( #39215 )
2020-07-15 15:26:49 +05:30
Oliver Eyton-Williams
db6d97142a
fix: remove whitespace to test solution ( #39210 )
2020-07-08 15:13:02 -05:00
Oliver Eyton-Williams
f1c9b08cf3
fix(curriculum): add isHidden: false to challenges
...
This includes certificates (where it does nothing), but does not
include any translations.
2020-05-25 16:25:19 +05:30
Randell Dawson
c401fc7f83
fix(curriculum): removed solution required comment from 6 challenges ( #38339 )
...
* fix: removed solution required comments
* fix: fixed two more challenge soltuions with solution required comment
* fix: remove debugging code
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com >
2020-03-09 13:58:46 +01:00
PHILIP OBIORAH
66e5cf0051
fix(curriclum): modified add images to your website ( #38155 )
...
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
Co-authored-by: Manish Giri <manish.giri.me@gmail.com >
2020-02-04 20:12:53 +05:30
Randell Dawson
aac1c58374
fix(curriculum): make last test more robust for Uncomment HTML challenge ( #37843 )
...
* fix: correct last test
* fix: remove forgotten console.log
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
2019-11-30 23:09:48 -05:00
Randell Dawson
9bf3fdbf38
fix(curriculum): changed challenge test text to use the word should for Responsive Web Design ( #36860 )
...
* fix: changed challenge test text to use should
* fix: changed have to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: reworded test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: improved test verbiage
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected typo
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: changed have the to be used in
Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com >
* fix: corrected verbiage
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-11-20 20:15:19 +05:30
SomeDer
bfa5c26288
fix: use dfn instead of code tag ( #36640 )
...
* Use dfn tags
* remove misused <dfn> tags
* Revert "remove misused <dfn> tags"
This reverts commit b24968a968
.
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Make "array" lowercase
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com >
* Fix dfn usage
* Address last dfn tags
2019-10-27 12:45:37 -04:00
Ezgi Kaysı Kesler
93360f4e01
fix:Typo in uncomment-html page ( #36800 )
...
* fix:Typo in uncomment-html page
* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/uncomment-html.english.md
removed comma
Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com >
2019-09-18 10:51:55 -07:00
Randell Dawson
568f00e02a
fix(curriculum): Added forumTopicId to remaining 1200 challeng… ( #36558 )
2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7
feat: add forumTopicId to challenge frontmatter [pre-existing]
...
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
2019-08-05 22:14:37 +05:30
Randell Dawson
ba6ae7154c
fix: removed more assert msg arguments ( #36439 )
2019-07-28 05:16:04 +01:00
Randell Dawson
cbbfc08108
fix: removed more assert msg args ( #36441 )
2019-07-24 13:13:06 +01:00
Randell Dawson
87615d2a7b
fix: removed assert msg argument ( #36406 )
2019-07-24 11:50:51 +02:00