Commit Graph

99 Commits

Author SHA1 Message Date
Jarek Wojciechowski
8f4e8bb3dd fix(challenges): add info about ReactDOM.render in an early react challenge (#17186) (#17473) 2018-06-11 09:02:32 +09:00
Quincy Larson
20f5db58bd fix(challenges): Add new cdn links (#17376)
Closes #17375
2018-06-02 02:22:47 +05:30
manjeet5
7bde8f266e fix(challenges): Corrected a test case for challenge (#17162)
For the last test case in 'Access Props using this.props' challenge, I
updated the test condition to check that the value of the tempPassword
prop is the same as the content within the <strong/> tags. This test
case will ensure that there is text present in the strong tag and its
value is as expected.

BREAKING CHANGE: none

Closes #17134
2018-05-30 01:47:52 +08:00
Stuart Taylor
0bb4fbfcea Fix/react versions (#17236)
<!-- freeCodeCamp Pull Request Template -->

<!-- IMPORTANT Please review https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/CONTRIBUTING.md for detailed contributing guidelines -->
<!-- Help with PRs can be found at https://gitter.im/FreeCodeCamp/Contributors -->
<!-- Make sure that your PR is not a duplicate -->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply. -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] Your pull request targets the `staging` branch of freeCodeCamp.
- [x] Branch starts with either `fix/`, `feature/`, or `translate/` (e.g. `fix/signin-issue`)
- [ ] You have only one commit (if not, [squash](http://forum.freecodecamp.org/t/how-to-squash-multiple-commits-into-one-with-git/13231) them into one commit).
- [x] All new and existing tests pass the command `npm test`. Use `git commit --amend` to amend any fixes.

#### Type of Change
<!-- What type of change does your code introduce? After creating the PR, tick the checkboxes that apply. -->
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
- [ ] Add new translation (feature adding new translations)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask in the Contributors room linked above. We're here to help! -->
- [x] Tested changes locally.
- [x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #17215

#### Description
<!-- Describe your changes in detail -->
2018-05-25 17:27:15 +05:30
Stuart Taylor
8535669ea4 Package: Validate challenges on test (#17216)
This PR allows us to validate the schema during test.

It also removes some cruft from the seed files and ensures only the required data is packaged and consumable, reducing the package weight somewhat.
2018-05-22 18:13:14 +05:30
Stuart Taylor
c428b2c197 feat(package): Initial Curriculum separation (#17174)
* feat(package): Initial Curriculum separation

* feat(package): Add org scope to package

* chore(ooops): Remove development file

* feat(npm): Add .npmignore

* fix(paths): Fix curriculum paths

* feat(build): Add a build step

* chore(seed): Move package file back to seed

* fix(ignore): Fix .npmIgnore file

* chore(docs): Update README

* chore(seed): Rename coding interview blocks

* fix(seed): Challenge files now fit into learn

* chore(seed): Update seed files for use in learn

* chore(escapes): Unescape script tags of jQuery
2018-05-21 19:26:49 +05:30
Aditya Rohilla
47bb4ca5e3 fix(seed): removed typo from task description (#17166) 2018-05-15 10:16:33 +05:30
Marcin Procyk
f031b82a70 fix(seed): Bootstrap default button fix (#17082)
added btn-default class to lessons with basic Bootstrap buttons, which
add proper styles for default button

Closes #17075
2018-05-03 10:07:00 -04:00
Nicholas Nadeau, P.Eng., AVS
e5d52afad8 chore: fixed typos via client9/misspell (#17081) 2018-04-25 10:37:27 +05:30
Ahmad Abdolsaheb
b5864279fa fix(seed): Fixes tests (#17051)
tests assert changed

Closes #17019
2018-04-17 15:53:55 -04:00
Chaitanya
ebcfb83486 Fix to tests messages (#17059)
In https://beta.freecodecamp.org/en/challenges/react/write-a-simple-counter challenge code is referring to Component Counter but messages are referring to myComponent
2018-04-17 15:02:57 -04:00
Varun
00e6d92480 fix: SASS challenge and code indentation (#17036) 2018-04-17 14:08:35 -04:00
Hakeem Davis
bcd31aa499 fix(seed): Clarify instructions (#17050)
Closes #17044
2018-04-13 09:49:01 +05:30
Edit Bazso
1dc5501b8f fix(seed): Fixed broken link in React Introducing Inline Styl (#17040)
* fix(seed): Fixed broken link in React Introducing Inline Styl

* fix(seed): Fixed broken link in React Introducing Inline Style
2018-04-07 22:06:11 -04:00
Varun
e747dbf9c4 fix: typo in challenges/react.json (#17037) 2018-04-07 21:43:22 -04:00
Ákos
754bdccb6b fix(seed): Sass Challenge:Use @each to Map Over Items in a Li (#17032)
Closes #16896
Closes #16894
2018-04-07 11:45:50 -04:00
Alex Chaffee
022f96d40d feat(seed): reformat seed/challenges JSON via repack script 2018-04-03 19:53:44 +05:30
Stuart Taylor
e5cad431b8 chore(challenges): Normalise challengeTypes 2018-04-03 19:52:01 +05:30
Gandharv Kumar Garg
85153c7f6c fix(seed): Add test for checking the length of buttons is 2 (#16921) 2018-03-27 09:02:33 -04:00
Huyen Nguyen
0cf19f5f15 fix(projects): Add user stories to projects' description (#16924)
BREAKING CHANGE: none

Closes #16810
2018-03-23 13:22:55 -04:00
Durgesh Agrawal
294f3e0453 fix(seed): Fix typo in redux.json (#16935)
Closes #16920
2018-03-23 00:32:30 -05:00
Quincy Larson
4f0f17892c Fix/copy improvements (#16859)
* fix(seed): Simplify copy of lessons and remove need for image

* rework copy for account creation and login emails

* fix: Fixup email template and lock-file
2018-03-09 19:39:44 +00:00
Stuart Taylor
0be11b108a chore(translations): Remove empty translation descriptions (#16805) 2018-03-02 11:39:29 -06:00
Neenad Ingole
0d820a95c1 fix(seed): message update to the test (#16718) 2018-02-26 12:37:43 +00:00
Quincy Larson
229a6902a5 fix(seed): Add legacy project back in and update id (#16749)
Closes #16336
2018-02-24 11:56:15 +05:30
Stuart Taylor
1a5cab57a1 feat(sass): Enable client-side sass compiling (#16747) 2018-02-19 14:41:01 -06:00
Stuart Taylor
24ef69cf7a feat(settings): Expand Settings page functionality (#16664)
* fix(layout): Fix Settings layout in firefox

* chore(availableForHire): Remove available for hire setting

* feat(helpers): Use helper components for Settings layout

* fix(map): Fix undefined lang requested

* feat(settings): Expand Settings page functionality

* chore(pledge): Remove pledge from Settings

* fix(about): Adjust AboutSettings layout

* fix(portfolio): Improve PortfolioSettings layout

* fix(email): Improve EmailSettings layout

* fix(settings): Align save buttons with form fields

* fix(AHP): Format AHP

* fix(DangerZone): Adjust DangerZone layout

* fix(projectSettings): Change Button Copy

* fix(CertSettings): Fix certificate claim logic

* chore(lint): Lint
2018-02-16 17:18:53 -06:00
Nguyen Quoc Bao
1789f9da0a fix(seed): Add length check for component find (#16678)
Closes #16677

fix(seed): Use triple equal
2018-02-14 17:50:38 +00:00
Jason Kao
09689be107 fix(seed): Removed inconsistent and unnecessary ReactDOM.rend (#16711) 2018-02-14 22:25:05 +05:30
Samuel Coe
9f63625411 fix(seed): Replaced 'include' with 'match' and RegExp for the (#16700)
Closes #16698
2018-02-14 11:24:25 +00:00
Nguyen Quoc Bao
71974d6972 fix(seed): Add default values to incompleted declarations (#16704)
Closes #16696

fix(seed): Fix undefined render
2018-02-13 11:45:12 +00:00
Jason Kao
51ce73ed2e test(seed): Tests now send string values into input, not number (#16639)
Closes #16636
2018-02-08 11:36:42 +05:30
Nguyen Quoc Bao
546e30ac3a fix(seed): Fix solution doesn't pass for challenge "React: Use Advanced JavaScript in React Render Method" (#16631)
Closes #16629
2018-02-08 11:23:20 +05:30
Tarun Singh
e1d5cb6405 fix(seed): Squashed a bug from Disable an element using Jquery 2018-02-06 15:53:07 +00:00
Jason Kao
e0b1ecec35 fix(seed): Fixed disruptive, unclosed <code> tag (#16594)
Closes #16581
2018-02-06 10:18:11 +00:00
Nguyen Quoc Bao
195653a2ef fix(seed): Add missing bindings outside comment lines (#16585) 2018-02-05 23:18:10 -05:00
Neenad Ingole
f13f0be26d fix(seed): Change Line Number & Typo (#16586)
Line number in the problem is corrected to 52 which was previously 38
and spelling mistake of 'compponent' is changed to 'component'

Closes #16567
2018-01-28 17:37:37 +05:30
mrugesh mohapatra
4346de64f3 Merge pull request #16573 from tarun7singh/fix/relative-protocol-URLs
fix(URLs): Changed protocol relative URLs to HTTPS URLs
2018-01-26 01:38:11 +05:30
Tarun Singh
90ba46f6f0 fix(URLs): Changed protocol relative URLs to Https URLs
BREAKING CHANGE: None

Closes #16522
2018-01-25 20:11:01 +05:30
Diogo Righi
bb1e0c4539 fix(challenges): Fix test on react challenge that was always passing (#16558) 2018-01-23 20:16:57 -05:00
build65
33d1e1b1e5 Turn Bootstrap relative URL into https URL (#16547) 2018-01-21 12:05:58 +05:30
A-J Roos
42025e3ad0 fix(seed): Fix invalid MongoDB ObjectID in jquery seed (#16535)
In the `Introduction to jQuery' seed challenge there is a incorrect
MongoDB ObjectId. Created a new MongoDB ObjectId.

Closes #16523
2018-01-19 19:18:00 +05:30
mrugesh mohapatra
69b47f853a fix(seed): Typos in testing code (#16515)
Just formatting issues - missing quote, unescaped quotes in strings and
fixed a typo by moving code chars out of string literals.
2018-01-17 23:10:50 -05:00
Berkeley Martinez
6e17281fda Merge pull request #16442 from iabrenne/feature/link-to-guide
Feature/link to guide
2018-01-16 12:52:03 -08:00
Stephen Mayeux
0e9706e8ab fix(seed): Eliminate regex bug for async assertions (#16341) 2018-01-16 11:25:20 +05:30
Irina Brennen
c7a898bed7 refactor(seed): Add link to guide
Partially #16388
2018-01-10 18:32:16 -06:00
Quincy Larson
7bed78c272 fix(seed): Fix label
Closes #16456
2018-01-09 16:10:27 -06:00
Berkeley Martinez
2108d45ccc Merge pull request #16217 from no-stack-dub-sack/fix/react-redux-finishing-touches
fix(challenges): put finishing touches on react & redux challenges
2017-12-21 09:22:23 -08:00
Peter Weinberg
277898afd3 fix(challenges): put finishing touches on react & redux challenges 2017-12-21 00:03:42 -05:00
Jonathan Grah
674ce83ab0 feat(cert): Certificates (#16185)
* feat(cert): finished layout and design of legacy certificates

* feat(cert): added new certs

* feat(cert): added logic for new certs

* feat(cert): updated claiming challenges

* feat(cert): fixed various small issues

* feat(cert): completed suggested changes
2017-12-20 19:15:23 -06:00