Commit Graph

1139 Commits

Author SHA1 Message Date
Saad Monem
d9cccd6d74 Fixed typos in description of challenge: "Use a Template Engine's Powers" (#36395)
* Fixed typos in template engine challenge

* Incorporated suggestions into updated description

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Incorporated new suggestion

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>
2019-07-09 14:36:47 -04:00
Tiago Salema
e561953827 Removed deprecated lifecycle methods (#35895)
Removed `componentWillReceiveProps` and `componentWillUpdate` from the list of lifecycle methods since they are now deprecated.
2019-07-03 13:56:15 +02:00
organicdude
f65eea3dd6 Increase language clarity in challenge "Basic Javascript: Iterate Through an Array with a For Loop" (#36081)
* Increase language clarity in the challenge.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/iterate-through-an-array-with-a-for-loop.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* fix/make-suggested-changes-on-behalf-of-author

* fix/add-empty-line-back-in
2019-07-03 15:13:25 +05:30
Fabricio Asfora Lira
a32f719d3a Fix/add a stricter test for the Add Placeholder Text to a Text Field challenge (#36186)
* fix: add test for input closing tag

* fix: add condintion to final syntax test

This wil test if there's any character after the input tag that isn't a white space

* fix/tests+remove-not-needed-text
2019-07-02 19:30:12 -04:00
Prashanth Ashok Ramkumar
b68f752847 Adding solution for queue class (#36319) 2019-07-02 07:45:42 -07:00
Michał Kozłowski
e05e17ce31 fix regexp to match require statement without .js extension (#36293) 2019-07-02 01:51:41 +05:30
Steven Failla
438e7d4c51 fixed testString to disallow any extra characters from passing. Also … (#35987)
* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

Co-Authored-By: Stevo99 <Sfailla1983@gmail.com>

* fixed test so it won't pass if datetime attr is left blank

* fixed test so it will not pass if datetime attribute is left empty

* fixed error in testString where test would pass if user runs test right away

* added tear-down div to make test code look cleaner

* fixed merge conflict. added tear-down div to make code look cleaner

* fixed testString to disallow any extra characters from passing. Also changed markup in testString and text

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

improvement to test case where element should have closing tag.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fixed conflict in git

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Update curriculum/challenges/english/01-responsive-web-design/applied-accessibility/standardize-times-with-the-html5-datetime-attribute.english.md

removed unnecessary test

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 18:49:00 -04:00
Tom
50b45b9379 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/create-an-export-fallback-with-export-default.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-28 16:04:59 +08:00
moT01
2e49aa02df fix/add-anonymous-function-example 2019-06-28 16:04:59 +08:00
moT01
9c1b83dd0c fix/add-tests+note-in-import-lesson 2019-06-28 16:04:59 +08:00
moT01
c133a6fbd0 fix/remove-duplicate-from-meta 2019-06-28 16:04:59 +08:00
moT01
9199319ae1 fix/build-error 2019-06-28 16:04:59 +08:00
moT01
9c249bf8be fix/build-error 2019-06-28 16:04:59 +08:00
moT01
d68475e7ea fix/build-error 2019-06-28 16:04:59 +08:00
moT01
ffc3a827c2 fix/conflicts 2019-06-28 16:04:59 +08:00
moT01
61895e05f7 fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
f14f1bf750 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
23d723a71f fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
2e6cb9181a fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
6e8bbd169b fix/final-draft-before-reviews 2019-06-28 16:04:59 +08:00
moT01
956212cdc0 fix/rename-lessons 2019-06-28 16:04:59 +08:00
moT01
8b5cc6d277 fix/add-tests 2019-06-28 16:04:59 +08:00
moT01
8a579210e3 fix/revise-es6-import-export-lessons 2019-06-28 16:04:59 +08:00
moT01
00b5ce97e3 fix/verbiage 2019-06-27 15:48:07 +08:00
Tom
72cb38a839 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
2019-06-27 15:48:07 +08:00
moT01
3b96f3e60d fix/terminology 2019-06-27 15:48:07 +08:00
Tom
81758eeea6 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
d2c5cc7ff3 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
9f4799bba1 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-nested-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
Tom
e58c512052 Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/use-destructuring-assignment-to-assign-variables-from-objects.english.md
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2019-06-27 15:48:07 +08:00
moT01
d0e5405e5c fix/make-tests-more-robust 2019-06-27 15:48:07 +08:00
moT01
21b411b855 fix/bad-solution 2019-06-27 15:48:07 +08:00
moT01
246ca16f32 fix/es6-destructuring-reword+new-lesson 2019-06-27 15:48:07 +08:00
Kris Koishigawa
1028310819 Changed bold to strong or code tags where possible 2019-06-26 17:34:03 +08:00
Kris Koishigawa
3ce97bbd81 Fixing other problems from comments 2019-06-26 17:34:03 +08:00
Kris Koishigawa
0544554b00 Fix curly quotes 2019-06-26 17:34:03 +08:00
Kris Koishigawa
a6ed1e51b7 Change links from http to https 2019-06-26 17:34:03 +08:00
Kris Koishigawa
32b24a3a20 Fixing merge conflicts 2019-06-26 17:34:03 +08:00
Kris Koishigawa
ae49dfd376 fix(challenges): Fix merge conflicts convert seconds and towers of hanoi 2019-06-26 17:34:03 +08:00
Kris Koishigawa
14bcbac669 fix(challenges): Added blockquote to department numbers and fixed fractions in fractran 2019-06-26 17:34:03 +08:00
Kris Koishigawa
aeb0dccb15 fix(challenges): Added left margin to blockquote footer in Babbage Problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa
12d84e83a8 fix(challenges): Y problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa
723ee2cfa5 W problem 2019-06-26 17:34:03 +08:00
Kris Koishigawa
a0e68a39a7 fix(challenges): V problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa
74f70c19d8 fix(challenges): T problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa
539e93d01b fix(challenges): The rest of the S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa
442c9c291d fix(challenges): More S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa
c752d57611 Added sorting algorithms 2019-06-26 17:34:03 +08:00
Kris Koishigawa
2053e99cd5 S problems 2019-06-26 17:34:03 +08:00
Kris Koishigawa
df88daa482 fix(challenges): J problems 2019-06-26 17:34:03 +08:00