Commit Graph

28941 Commits

Author SHA1 Message Date
Senipah
012e5c848b reword instruction referring to 3d array (#38272) 2020-02-29 22:35:53 -08:00
Ashraf Nazar
181ac1e8ad fix: Update test for wrapping strong tag around text to include periods at the end (#38305) 2020-02-29 01:02:39 -05:00
Oliver Eyton-Williams
2d7b1255cc fix: add missing .english extensions (#38298) 2020-02-28 07:19:22 -08:00
Kristofer Koishigawa
6cfd0fc503 fix: improve Project Euler descriptions, challenge seeds, and test cases (#38016)
* fix: improve Project Euler descriptions and test case

Improve formatting of Project Euler test descriptions. Also add poker hands array and new test case for problem 54

* feat: add typeof tests and gave functions proper names for first 100 challenges

* fix: continue fixing test descriptions and adding "before test" sections

* fix: address review comments

* fix: adjust grids in 18 and 67 and fix some text that reference files rather than the given arrays

* fix: implement bug fixes and improvements from review

* fix: remove console.log statements from seed and solution
2020-02-28 06:39:47 -06:00
Randell Dawson
41718abf76 fix(learn): consolidate comments for responsive web design cert (#38256)
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
2020-02-27 20:50:46 +05:30
LastGenius-edu
9606e27a0e docs(i18n): translating README.md into Ukrainian (#37230) 2020-02-27 19:10:59 +05:30
Fernanda Kawasaki
a4219aacd8 fix(docs, i18n): portuguese grammar mistakes (#37226) 2020-02-27 19:08:05 +05:30
Florian Hähnert
bbfbe8a0fc fix(i18n): create how-to-work-on-coding-challenges.md in german (#37133)
* Create how-to-work-on-coding-challenges.md 

Translate how-to-work-on-coding-challenges.md into german

* Update docs/i18n-languages/german/how-to-work-on-coding-challenges.md

Co-Authored-By: Squizzi3 <54278753+Squizzi3@users.noreply.github.com>

* Update docs/i18n-languages/german/how-to-work-on-coding-challenges.md

Co-Authored-By: Squizzi3 <54278753+Squizzi3@users.noreply.github.com>

* Update docs/i18n-languages/german/how-to-work-on-coding-challenges.md

Co-Authored-By: Squizzi3 <54278753+Squizzi3@users.noreply.github.com>

Co-authored-by: Martin Gnodtke <54278753+Squizzi3@users.noreply.github.com>
2020-02-27 19:06:24 +05:30
Andres Arrieta
baf2ec6c42 fix(i18n): spanish correct description of the challenge (#37132) 2020-02-27 19:05:21 +05:30
Harsh Savergaonkar
c21c9f0acb Added meaning of ones in adjacency matrices (#37048)
* Added meaning of ones in the matrix

* Apply suggestions from code review

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: add slash to avoid markdown lint error

Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-27 06:54:11 -06:00
Ahmet Anbar
e07b50aaa9 docs: Translate to Turkish (#37066)
how-to-open-a-pull-request.md is translated to Turkish language.
2020-02-27 15:39:26 +05:30
Igor Hideki Trindade
d4f8b00c84 Fix portuguese translations (#37051) 2020-02-27 15:38:11 +05:30
Igor Hideki Trindade
94712af264 Fix portuguese translations on curriculum challenge (#37050) 2020-02-27 15:37:28 +05:30
Oussama Bouchareb
882cddd800 translated how-to-open-a-pull-request.md to arabic in docs (#38274) 2020-02-27 10:47:10 +03:00
Sanket Kogekar
1a87f1f7c0 add: solution to project euler problem 20 (#38257)
* add: solution to project euler problem 20

* Update curriculum/challenges/english/08-coding-interview-prep/project-euler/problem-20-factorial-digit-sum.english.md

Accidentally added last line. Calling function is unnecessary in solution.

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* right place for starting braces

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

* moved starting brace to previous line.

Co-Authored-By: Manish Giri <manish.giri.me@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Manish Giri <manish.giri.me@gmail.com>
2020-02-26 14:22:40 -05:00
Ahmad Abdolsaheb
2c3de17c74 fix: open universal nav links on the same tab (#38273) 2020-02-27 00:39:56 +05:30
Ezekiel Oladejo
402ccb36f1 Fix typographical errors in introductory texts (#38276)
* Fix typographical errors in introductory texts
2020-02-26 18:32:21 +01:00
Prakash Kumar
c9d8c2a73c fix(learn): typo in Serialization of a User Object (#38262) 2020-02-26 15:07:32 +05:30
Vincent Shury
b49b9f3e3c Typo whitespace fix in access-multi-dimensional-arrays-with-indexes.english.md (#38247)
* Update access-multi-dimensional-arrays-with-indexes.english.md

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 17:02:53 +01:00
Randell Dawson
78156a65f0 fix(curriculum): Added test to Return a Sorted Array Without Changing the Original Array challenge to validate new array is returned (#38105)
* fix: added test to validate new array is returned

* fix: changed text to reflect changed test

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-24 15:30:48 +01:00
Oliver Eyton-Williams
5b80595fbf fix: remove useless logging (#38246) 2020-02-21 15:08:53 +05:30
Tom
a09ffadd5a fix: responsive image challenge (#37934)
* fix: responve image challenge

* fix: bad solution

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Update curriculum/challenges/english/01-responsive-web-design/responsive-web-design-principles/make-an-image-responsive.english.md

Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2020-02-20 22:53:30 +05:30
Oliver Eyton-Williams
b0f1fa4b96 fix: make recursion challenge more intuitive (#37399) 2020-02-20 21:36:33 +05:30
mrugesh
dfe2d91360 docs: remove guide specific checklist points (#38240) 2020-02-20 20:43:51 +05:30
Oliver Eyton-Williams
7cdf01276d fix: ensure Babel options exist when used
Also renamed 'config' to 'options' to be consistent with the calling
function.
2020-02-20 19:52:23 +05:30
Oliver Eyton-Williams
a27992a8b6 fix: transpile import() for testing in node 2020-02-20 19:52:23 +05:30
Oliver Eyton-Williams
ebc6197c54 fix: assume scripts inside HTML are js, not jsx 2020-02-20 19:52:23 +05:30
Oliver Eyton-Williams
d87c16e65e fix: only load preset when needed 2020-02-20 19:52:23 +05:30
Oliver Eyton-Williams
21833ab508 fix: load all Babel libs dynamically 2020-02-20 19:52:23 +05:30
Igor Snitkin
dc7092ecd1 (fix learn): Update description to accommodate tests (#38224) 2020-02-19 00:13:34 +05:30
lasjorg
9a5ae756ac fix(challenge): check inline style for color (#38211)
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
2020-02-18 23:38:16 +05:30
Oliver Eyton-Williams
f84173866a fix: make frankenSplice tests more robust (#38225) 2020-02-18 21:24:24 +05:30
Robin
493060ef07 docs: Updated french versions (#37067)
Co-authored-by: mrugesh <1884376+raisedadead@users.noreply.github.com>
2020-02-18 21:14:26 +05:30
Ilkay Tevfik Devran
f102c88a97 feat(i18n): add Turkish contribution guidelines (#37038) 2020-02-18 21:10:11 +05:30
Prakash Kumar
c730f4aef4 Update hash-and-compare-passwords-synchronously.english.md (#38226) 2020-02-18 09:28:38 +01:00
mrugesh
bb06330b63 docs: update link to coc 2020-02-16 15:08:34 +05:30
Oliver Eyton-Williams
3fff454872 fix(client): localise calendar to user's current timezone (#38217)
* fix: localise Heatmap to user's timezone

Rather than using ISO formatted date strings, this uses Date objects
for simplicity and to ensure that the heatmap is correct for the
timezone it is viewed in. It should also match the timeline which is
also localised to the viewing computer's timezone.

* test: update snapshot
2020-02-15 00:29:41 +05:30
Oliver Eyton-Williams
cc79999a31 fix: force timezone to be UTC for tests (#38215)
react-calendar-heatmap's output depends on the timezone, which means
that snapshots can fail if the timezone changes.  This sets the timezone
as UTC during client tests to avoid that problem.
2020-02-14 21:24:29 +05:30
Prayag
701bbc2ae9 added solution to d3 challenge add-labels-to-d3-elements (#38208) 2020-02-13 20:59:16 +05:30
Sofya Kholodkova
c61c8c0474 update russian localization (#37259) 2020-02-13 12:02:36 +04:00
Sofya Kholodkova
7c186f3a50 Update russian localization (#37258) 2020-02-13 12:02:03 +04:00
Sofya Kholodkova
5d4fb2a39b Update russian localization (#37257) 2020-02-13 11:55:03 +04:00
Sofya Kholodkova
3fec01a28d Update russian localization (#37256) 2020-02-13 11:52:46 +04:00
kundan kumar
971c62ab53 fix : Unclear test output use-array.map-to-dynamically-render-… (#38191) 2020-02-13 02:41:36 +05:30
Hassaan Pasha
2f951f0dff fix: edited the duplicate test guideline to mirror the actual… (#38199) 2020-02-12 20:47:24 +05:30
srdubya
3fd336d3e9 fix(learn): correcting Hash Table Lookup Efficiency (#38130)
A hash table provide a lookup of O(1), not O(n).
2020-02-12 12:27:47 +05:30
Hassaan Pasha
0498e27902 fix: added white space checks including newlines to ensure pro… (#38166)
* fix: added white space checks including newlines to ensure proper validation of trim method

* fix: Addressing comments
2020-02-12 12:17:54 +05:30
Huyen Nguyen
3d1dcbea11 fix(docs): typo 2020-02-12 15:36:55 +09:00
Ashraf Nazar
4999288912 fix: Use markdown syntax instead of HTML on exercises (#38196) 2020-02-11 23:26:09 +05:30
Ashraf Nazar
5feabd762c fix: Add tests to check lazy matching is applied and that the string "h1" is not matched (#38193) 2020-02-11 10:17:51 -06:00