131 Commits

Author SHA1 Message Date
seanlaing
e4870c472a fix/update-es6-destructor-challenge: Added test (#35455)
* fix/update-es6-destructor-challenge: Added test
- Added test incase during destructuring somebody pass and extra key

* fix/update-es6-destructor-challenge: Fixed the test case per review comments
-Cleaned up regex
- Setup two cases one where additional assignment of variables before and then after
- Did not put uppercase case CONSTANT checks because not related to question

* fix: corrected tests
2019-03-25 15:49:56 -05:00
Hrishit Prasad Biswas
4eb4afe53b Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexe… (#35666)
* Fixed bug in 2nd test for Access Multi-Dimensional Arrays With Indexes Challenge

* Fix for issue #35665

Fixed Bug In 2nd test case for Access Multi Dimensional Arrays With Indexes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes.english.md

Co-Authored-By: Artistic18 <hrishitbiswas20@gmail.com>

* fix: added missing ) for assert statement
2019-03-25 15:42:21 -05:00
Christine Gierer
6d9ce1c85c Update description of tests pig-latin.english.md where too vague (#35499)
* Update description of tests pig-latin.english.md

The last two tests "Should handle words where the first vowel comes in the end of the word." and "Should handle words without vowels." are too vague without examples of what is meant by that.

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/intermediate-algorithm-scripting/pig-latin.english.md

Co-Authored-By: beansprout <christinegierer@gmail.com>
2019-03-25 08:02:18 -07:00
Aditya
9cca21f57f [Fix] Removed unnecessary IIFEs from ES6 challenges (#34538)
* feat: removed IIFE and added solution

* feat: updated challenges seed, test and solution

* style: removed semicolon

* feat: updated seed and solution

* feat: updated challenges seed and solution

* feat: updated test, seed and solution

* fix: added seed code to solution

* fix: removed function and added solution

* fix: removed makeClass function and fixed solution

* style: removed excessive semicolons

* Fixed spacing for note in instructions section

* fix: removed assert messages and used const

* fix: regex fails correctly now
2019-03-25 09:19:34 -05:00
Vikas KM
9e36ff87bb changes to no validate comment (#34810)
* changes to no validate comment 

Added single line comment check for regex to not validate.

* fix: corrected regex

* fix: changed + to *
2019-03-23 15:27:42 -04:00
Hugo
739f4a8850 fix: Update test for ES6 challenge (#34300)
* fix: es6 challenge test

* delete console.log
2019-03-21 10:50:30 +01:00
Timur
cab064a183 Fix tests for Basic JavaScript: Write Reusable JavaScript with Functions (#34345)
* Fix tests

- fix original log() method restoration

- fix case that other userscripts(or extensions) can affect console output and therefore can ruin the test

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/write-reusable-javascript-with-functions.english.md

allow function calling without semicolon

Co-Authored-By: T1mL3arn <T1mL3arn@users.noreply.github.com>
2019-03-21 11:50:23 +05:30
Chuck Adams
4b2219b01d close #35246 - change AVG_TEMPERATURES to avgTemperatures in instructions (#35537) 2019-03-20 22:02:21 +01:00
grets311
2219a9a8dd Update positive-and-negative-lookahead.english.md (#34582)
Update solution from w{5} to w{6} as exercise is to match at greater than 5 characters long.
2019-03-20 15:58:09 +01:00
Jade Michael Thornton
d5861edc84 add more specific tests for username regex challenge (#34655)
* add more specific tests for username regex challenge

* fix: removed unnecessary test
2019-03-19 15:21:30 -07:00
lasjorg
88a5d46ccb fix(challenge): add support for IIFE arrow function (#35573)
* fix(challenge): add support for IIFE arrow function

* fix(challenge): update regex
2019-03-19 08:39:43 -07:00
NITIN BISHT
228d873dd3 Fix: remove quote from challenge where not needed [english] (#35493) 2019-03-19 15:04:03 +05:30
Randell Dawson
9051ad2eb5 Fixed bug allowing versions of Object.keys method and hard coding of ownProps array (#35021)
* fix: disallow variants of Object.keys method

* fix: added new test to help prevent hardcoding array

* fix: refactored regex
2019-03-17 18:47:41 -04:00
Lauren Van Sloun
ef86d7bd61 Fixed typo in JavaScript curriculum (#34820)
* Fixed typo in JavaScript curriculum

* Added missing period at end of sentence
2019-03-12 15:05:22 -07:00
lasjorg
494687f75e fix: correct inconsistency in formatting (#34721)
* fix: correct inconsistency in formatting

* fix: remove space before parentheses
2019-03-12 13:49:54 -07:00
Randell Dawson
f6d07f37d7 fix: created more flexible test (#35325) 2019-03-08 11:07:50 -06:00
Lewis Horwood
38c99d7ff5 Simplify challenge wording (#25120)
* Simplify challenge wording

* Update use--to-import-everything-from-a-file.english.md
2019-03-06 18:57:43 -05:00
Alan Price
27a59c5418 fix: reworded text messages (#27072) 2019-03-06 18:30:58 -05:00
Akshay Tiwari
6d24b879f2 Update catch-mixed-usage-of-single-and-double-quotes.english.md (#35532) 2019-03-07 01:04:12 +05:30
Aashis kumar
960811e31f Solution to specify-exact-number-of-matches.english JavaScript Challenge (#34757)
* Update specify-exact-number-of-matches.english.md

Added an explanation to the working code too

* fix: removed i flag and comments
2019-03-05 13:12:55 -05:00
Randell Dawson
8e5b99b8ca fix(curriculum) Prevent 5th test from allowing invalid solution in Escape Sequences in Strings challenge (#35367)
* fix: prevent 5th test from allowing invalid code

* fix: added new test to not allow extra characters
2019-03-05 07:57:48 -06:00
Ihor Allin
6222b86133 Update understand-the-hazards-of-using-imperative-code.english.md (#35052)
Moved instructions into correct section.
2019-03-04 09:24:54 -06:00
Randell Dawson
99c7f28530 fix: remove <code> tags around word queue (#35393) 2019-03-04 09:12:29 -06:00
Luane
9440cca69f Added example Input/Output to challenge (#34738)
* Added example Input/Output to challenge

Input/Output example will make it clear what the challenge is asking the camper to do.

* Formatting changes made to file

* Made minor changes in formatting

Added <code> tag to single line code.

* Formatting update

* Added requested formatting changes

* Refactored sentence and removed earlier example
2019-03-02 02:26:23 -05:00
Christopher McCormack
421c097f17 feat: cleaned up grammar and formatting (#35364) 2019-03-02 00:25:09 +05:30
hilliarj
6cd3466f0b fix(curriculum): Find Characters with Lazy Matching (#35454)
* fix(curriculum): Find Characters with Lazy Matching

* Update PR

Note is moved in the Description section and not the Instructions section
2019-02-28 13:33:07 -08:00
Ruchika Sharma
25f45ffc60 fix: Rename section in Modify array challenge (#35430) 2019-02-27 19:04:49 -05:00
Niraj Nandish
769ec3cb63 Make code consistent in challenge (#19054) 2019-02-26 16:38:46 -05:00
Pete
41ffe5a7e4 Adding-missing-challenge-solution (#35025)
* Adding-missing-challenge-solution

* updating solution as requested

added back in //solution required and removing console.log

* Adding-solution

* Update access-property-names-with-bracket-notation.english.md

* adding-solution

* Adding-solution
2019-02-26 03:44:33 -05:00
Aditya
665c9cb47f fix: Object Oriented Programming: Use Dot Notation to Access the Properties of an Object (#34675)
* fix: typos

* fix: removed unnecessary assert message
2019-02-25 22:24:06 -05:00
geeseyj
f3fd951446 fix(coding): uncomment destructuring test and add solution (#18909)
* fix(coding): uncomment destructuring test and add solution

the test that ensured destructuring was being used had been left commented out and there was no solution offered. I uncommented the test and verified it worked as well as added the solution.

* fix: corrected partial solution to full
2019-02-25 23:27:50 +05:30
Chris Del
10e9c6f340 Update Higher-Order Arrow Functions code challenge (#34414)
* fix: update text of Write Higher Order Arrow to be more instructive

* fix: update tests and code to be more simple. Edit typos in text part. Prepare for PR

* fix: further changes to PR

* fix: checkout old head. Merge later commit with older commits

* fix: add MDN links to arrow-functions guide

* fix: re-add removed log and change working in guide wording

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Yep

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/es6/write-higher-order-arrow-functions.english.md

Removing unneeded line for clarity

Co-Authored-By: chrisdel101 <arssonist@yahoo.com>
2019-02-24 13:34:53 +05:30
Randell Dawson
b83ab53047 [Fix] Corrected bug found in Shopping List challenge (#35017)
* fix: corrected bug found in issue #16044

* fix: account for empty strings

Co-Authored-By: RandellDawson <5313213+RandellDawson@users.noreply.github.com>

* fix: corrected wrong logic
2019-02-24 13:28:55 +05:30
Lewis Horwood
9cf283aab9 Add tests reflecting #19390 (#19477)
* Add test reflecting #19390

Added two tests to prevent checking only `Alan`.

* Split into 4 tests for each prop

Split previous tests with 2 props on each into 4 single-prop tests; fixed whitespace
2019-02-23 00:16:06 +05:30
TristanSeabrook
d8c8ee73a3 added apostrophe (#35354)
changed "keys" to "key's"
2019-02-22 03:12:23 -08:00
TristanSeabrook
7d9ef880c2 removed ungrammatical apostrophe (#35353)
Changed "array's" to "arrays".
2019-02-22 03:12:12 -08:00
Randell Dawson
37aa3172ea fix: added missing &amp; in text of tests (#35341) 2019-02-22 00:28:05 -05:00
Almaz Kunpeissov
4a7571492d #35176 Remove reference to "backspace" regex (#35186)
Remove reference to "backspace" regex in example #35176
2019-02-22 10:50:51 +08:00
Niraj Nandish
cb35d49a21 fix(challenges): Fix broken links in English challenges (#35125) 2019-02-21 17:58:31 -05:00
Fordco
63c5423e4a fix(curriculum): iterate with javascript do...while loops (#35214) 2019-02-21 17:25:54 -05:00
rupali317
5f6595b7dc fix: use correct variables for challenge (#34935)
Deleted the sentence which refers a.start.x as an object, as it is not an
object
2019-02-20 22:00:21 -08:00
Lee
551c97feb1 Update: Added info re uppercase and lowercase (#35094)
* Update: Added info re uppercase and lowercase

Included information to explain that lowercase and camelCase can be used for const identifiers.

* Fix: corrected mutable to immutable

I corrected the error that uppercase is used for mutable values.

* Fix: changed ** ** to <strong></strong>

I changed the markdown **  ** to <strong></strong>, as I was informed that ** didin't work.
2019-02-19 23:12:46 -05:00
Randell Dawson
aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Aashis kumar
80d66a9808 Update check-for-all-or-none.english.md (#34758)
Added Solution to the problem Change the regex favRegex to match both the American English (favorite) and the British English (favourite) version of the word.
2019-02-17 11:44:19 -05:00
Kirill Malev
bca4d896cc Added solution to reuse-patterns-using-capture-groups.english.md (#35144)
* Update reuse-patterns-using-capture-groups.english.md

* included whole solution
2019-02-16 19:10:03 -08:00
Christopher Szczechowicz
994ee89a86 fix: add a ; to the end of the example code (#34379) 2019-02-16 19:20:10 +05:30
BurnhamG
a825708e3e Correct seed code errors (#32355)
* Correct seed code errors

Corrects the problems raised in issue #13157 - campers can focus on solving the challenge rather than fixing bugs; functions have the correct return value now.

* Add single quotes to correct new assertion statements

* Fix incorrect usage of splice

Changed the parameters passed to bookList.splice in the remove function

* Remove extraneous tests
2019-02-14 13:24:38 -08:00
Beau Carnes
409c39abf1 feat(curriculum): Add Basic JS Scrimba links (#34789)
* feat(curriculum): Add Basic JS Scrimba links

* Fix: Add missing video url.

* fix: update videoUrl
2019-02-14 09:24:02 -08:00
Valeriy
99cf6090bd fix(curriculum): getUserInput is not defined 2019-02-13 22:01:38 +00:00
Kirill Malev
661d10412f Added solution to remove-whitespace-from-start-and-end.english.md (#35145)
* Update remove-whitespace-from-start-and-end.english.md

* includes whole solution now
2019-02-12 09:34:52 -08:00