Commit Graph

7 Commits

Author SHA1 Message Date
Sem Bauke
eccc642d83 fix(client): store accessibility for screenreaders (#42996)
* fix: store accessibility for screenreaders

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* fix: remove old comments

* feat: at short cut announcement when running test

* feat: announce that accesibility mode is turned on

* fix: use Redux values

* Apply suggestions from code review

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

* Apply suggestions from Oliver

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: "rip out redux stuff" and use store instead

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* Apply suggestions from code review

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: old use of props

* Update client/src/templates/Challenges/classic/editor.tsx

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>

Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
2021-08-06 14:17:17 +02:00
Oliver Eyton-Williams
e118dda13a fix: order imports and remove circular dependencies (#41824)
* fix: remove circular dependency

redux depended on templates/Challenges/redux and vice versa.  This
meant that import order mattered and confusing bugs could arise.

(cherry picked from commit 7d67a4e70922bbb3051f2f9982dcc69e240d43dc)

* feat: require imports to be in alphabetical order

Import order generally does not matter, but there are edge cases
(circular  imports and css imports, for example) where changing order
changes behaviour

(cherry picked from commit b8d1393a91ec6e068caf8e8498a5c95df68c2b2c)

* chore: order imports

* fix: lift up challenge description + title comps

This brings the classic Show closer to the others as they
now all create the description and title components

* fix: remove donation-saga/index circular import

(cherry picked from commit 51a44ca668a700786d2744feffeae4fdba5fd207)

* refactor: extract action-types from settings

(cherry picked from commit 25e26124d691c84a0d0827d41dafb761c686fadd)

* fix: lint errors

* feat: prevent useless renames
2021-08-02 08:39:40 -05:00
Shaun Hamilton
47adbde90b feat(client): add multifile editor breadcrumbs (#42907)
* feat(client): add multifile editor breadcrumbs

* adjust margin

* update snapshot

* re-remove duplicate css

* adjust arrow colours

* update that pesky snapshot

* add title to editor jaw

* remove bolding, and center

* update snapshot
2021-07-28 17:29:11 +03:00
Oliver Eyton-Williams
03913024a5 fix: various multifile editor bugs (#42855)
* refactor: use refs to hold editor and monaco

Also removed a lot of unnecessary conditionals

* refactor: get a ref to the editor directly

Previously we got a ref to react-monaco-editor, but that's an
unnecessary layer of abstraction

* fix: replace data state with ref

* fix: replace remaining useStates with useRefs

* refactor: simplify dataRef access

* fix: store correct id for output zone

* refactor: remove unused parts of MultifileEditor

* fix: use separate models per fileKey

Temp fix, I think the data should store one version per fileKey

* fix: create data for each editor

* refactor: declare data once

* fix: handle widgets etc. like other data

* fix: store an editor per fileKey

* refactor: clean up types + initial properties

* refactor: remove redundant constructor

* fix: remove redundant comment

* refactor: update comments
2021-07-14 18:09:50 +02:00
Shaun Hamilton
0891d41c35 fix(client): re-ref editor (#42799) 2021-07-09 09:29:11 +05:30
Shaun Hamilton
de2f4e2843 fix(client): open completionModal on shortcut (#42685) 2021-06-30 20:52:18 +05:30
Shaun Hamilton
36ad0dbcc5 feat(client): ts-migrate editor component (#42285)
* class component to functional component

* rename Editor to .tsx

* add @types and no-verify changes

* init ts with no-verify

* refactor: files -> challengeFiles

* prop-types built from GraphQL

* Editor: halfway through 💪

* editor: almost done 🚀

* post-meeting changes with errors

* fix: remove chord keybindings

* Revert "refactor: files -> challengeFiles"

* fix tests type, fix editor bug

* fix linting issues

* re-add Loadable

* kebab-case editor

* remove Range import

* format package and prop-types

* update Show and prop-types

* fix: editor background color

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
2021-06-30 20:52:18 +05:30