gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
27,013 Commits 9 Branches 0 Tags
f08174b5b1655baed54bb5599ac0054d9cbd625a
Commit Graph

137 Commits

Author SHA1 Message Date
Kelvin Sánchez
f08174b5b1 fix(learn): Remove unnecessary inline code tag in challenge (#41177) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-19 09:44:50 +05:30
Kelvin Sánchez
fad168b465 fix(learn): fix some code tags, capitalization and punctuation in challenge (#41161) 
* fix some code tags, capitalization and punctuation

Note: The reserved word in JavaScript is "boolean", so I think it is appropriate to use it like this inside the code tags.

* Remove code tags and capitalize first letter

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* capitalize letter and replace slash

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-18 08:45:12 -07:00
Kelvin Sánchez
2c1280af65 fix(learn): Improve the clarity on a challenge sentence (#41154) 
* Improve the clarity on a challenge sentence

* add string type and remove double quotes

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-02-18 08:29:31 -07:00
Kelvin Sánchez
1fe1371b16 add missing inline-code block (#41153) 2021-02-17 11:24:53 -08:00
Kelvin Sánchez
b45406ec9d fix(learn): Remove repeated definition tag in challenge (#41151) 2021-02-17 23:01:42 +05:30
Nicholas Carrigan (he/him)
21c7abf584 fix(learn): update challenge for crowdin (#41089) 2021-02-16 19:47:40 +05:30
Nicholas Carrigan (he/him)
18e821bcd3 fix: remove clunky sentence (#40751) 2021-02-01 19:22:39 +05:30
matias-miller
8a9f3319c6 fix(learn): Fixed typos in count-backwards-with-a-for-loop.md (#40478) 
* Spelling change in count-backwards-with-a-for-loop

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/count-backwards-with-a-for-loop.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-01-21 08:44:10 -08:00
Nicholas Carrigan (he/him)
062b1cd424 fix: replace h tags (#40750) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2021-01-21 13:41:46 +05:30
Nicholas Carrigan (he/him)
8d8d25e9f2 fix(learn): address escaped backticks (#40717) 
* fix(learn): address escaped backticks

Addresses the instances of escaped backticks - where a backtick is
preceded by a backslash.  In most cases, this was left over from the
old parser. In some cases, a backtick was intended to be wrapped in
code tags and has been adjusted accordingly.

This issue came to light due to a bug in the translation flow on
Crowdin.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: EVEN MORE :( :( :(

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: backslash nightmares

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: When you wish upon a *******

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix(curriculum): md error introduced by formatter

* fix(curriculum): remove extra `s

* fix: restore quote symbol

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: Typo

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>

* fix: apply review changes

Applying review feedback from call with @RandellDawson.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

* fix: markdown does weird stuff sometimes

Can't stick backticks together - use code.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
 2021-01-20 19:01:00 -07:00
Oliver Eyton-Williams
ee1e8abd87 feat(curriculum): restore seed + solution to Chinese (#40683) 
* feat(tools): add seed/solution restore script

* chore(curriculum): remove empty sections' markers

* chore(curriculum): add seed + solution to Chinese

* chore: remove old formatter

* fix: update getChallenges

parse translated challenges separately, without reference to the source

* chore(curriculum): add dashedName to English

* chore(curriculum): add dashedName to Chinese

* refactor: remove unused challenge property 'name'

* fix: relax dashedName requirement

* fix: stray tag

Remove stray `pre` tag from challenge file.

Signed-off-by: nhcarrigan <nhcarrigan@gmail.com>

Co-authored-by: nhcarrigan <nhcarrigan@gmail.com>
 2021-01-12 19:31:00 -07:00
Ilenia
7de8549e02 fix(learn): Made the Escaping literal quotes channel accept the dot inside the double quotes too (#40465) 
* made valid solution dot inside and dot outside quotes

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/escaping-literal-quotes-in-strings.md

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-12-16 08:07:47 -08:00
vbinithyanandamv
7c19c82076 [BUG] Able to pass challenge "Basic JavaScript: Initializing Variables with the Assignment Operator" with incorrect answers #40406 (#40409) 
* [BUG] #40406 Fix

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/initializing-variables-with-the-assignment-operator.md

Requested Change.

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-12-15 18:07:36 -07:00
Oliver Eyton-Williams
0bd52f8bd1 Feat: add new Markdown parser (#39800) 
and change all the challenges to new `md` format.
 2020-11-27 10:02:05 -08:00
Ilenia
f294d9cacc fix(learn): removed use strict from various challenges (#40321) 2020-11-25 15:59:04 -08:00
rajapandi_vijayakumar
e8b6a9e5dd fix(learn): add example declaration for clarity (#40207) 
Variable declaration is added which is used inside the switch case.
 2020-11-09 17:09:21 +00:00
Randell Dawson
895e6b8daf fix(learn): add test to prevent hardcoded pass (#40179) 2020-11-06 17:05:20 +00:00
Oliver Eyton-Williams
a71150074d fix(learn): preserve whitespace in the tool panel (#39973) 2020-10-14 21:40:15 +05:30
dhanush1909
a32427c120 fix(learn): make semicolon at end of line optional (#39821) 2020-10-08 21:02:59 +01:00
Oliver Eyton-Williams
2b9e38a17b fix: replace .english.md extension with .md 2020-09-29 22:09:04 +02:00
Mainak Debnath
362e8254f8 fix(learn): update test to allow negative arguments (#39701) 
* Updated the regex in test

* Changed regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

* Updated changes in regex

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-09-28 16:03:24 +01:00
Nicholas Carrigan
6ccd0d21a1 fix(learn): Update test text in Profile Lookup (#39678) 2020-09-25 00:38:40 +05:30
Gaurav Khairnar
a338d4b79d fix(learn): clear instructions for basic JavaScript: Appending Variables to Strings lesson (#39587) 2020-09-17 13:00:58 -05:00
Hassaan Pasha
80438cac3e feat(client, learn): add helper functions for common validation operations (#38605) 
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>
 2020-09-17 19:38:01 +05:30
Randell Dawson
30c61b808b fix: consolidate misc comments (#39583) 2020-09-16 13:29:50 -05:00
Aleksa S. Stevic
5cb609dc5c Changed "statement" to "expression" (#39564) 
The ternary operator doesn't allow statements, just expressions.
 2020-09-12 10:37:59 +02:00
Randell Dawson
c345bc9886 fix: removed scrimba video links that do not reflect current challenge (#39559) 2020-09-11 11:17:50 -05:00
Siddharth Pathak
5418307936 fix(learn): add whitespace check to else-if test (#39555) 2020-09-09 20:30:33 +01:00
Tom
b79a332984 fix: remove scrimba link for inaccurate video (#39545) 2020-09-08 13:09:53 -07:00
Oliver Eyton-Williams
bd68b70f3d Feat: hide blocks not challenges (#39504) 
* fix: remove isHidden flag from frontmatter

* fix: add isUpcomingChange

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

* feat: hide blocks not challenges

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>

Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
 2020-09-03 15:07:40 -07:00
skaparate
f97c847e29 fix(learn): formatting bug preventing tests to pass (#39045) 
* implemented object validation

* fix: formatting bug preventing tests to pass

* implemented object validation

* fix: formatting bug preventing tests to pass

* integrated changes again

* added suggested changes

* fix: refine instructions

* fix: revert some bad instructions and change album to albumTitle

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-09-03 12:34:12 +01:00
bhagerty
db15a44160 fix(learn): clarify instructions to remove confusion (#39479) 
* Clarify instructions to remove confusion

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/accessing-object-properties-with-variables.english.md

Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
 2020-09-02 18:41:59 +01:00
Beau Carnes
f334734e98 feat: split JS challenge into two (#39044) 
* feat: split JS challenge into two

* fix/change-to-not-use-untaught-assignments

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-08-31 19:44:56 +01:00
anthony
20d397f719 remove MDN links from English challenges (#39337) 
* remove MDN links from English challenges

* add push challenge reference to record-collection

* refactor truthy falsy verbiage

* replace MDN link with news link

* remove unnecessary whitespace
 2020-07-31 15:19:49 +09:00
Bianca Zanardi
35f24c6085 Fix text inconsistency (#39203) 
* Fix text inconsistency

To match the eight ECMAScript Language Types on the previous paragraph.

Co-authored-by: moT01 <20648924+moT01@users.noreply.github.com>
 2020-07-09 16:18:11 +02:00
Nicholas Carrigan
2aee480c46 Remove example code from challenge seed (#39083) 
Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2020-06-22 16:13:21 +05:30
Nicholas Carrigan
62dcb1f3fa fix(curriculum): remove whitespace typo (#39009) 2020-06-05 16:08:38 +02:00
jasnkwcz
95371f92b3 fix(learn): clarify formatting requirements for multiple ternary operators challenge (#38993) 
* fix(learn): clarify formatting requirements for multiple ternary operators challenge

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-06-03 18:33:03 +02:00
JapneetSingh5
87ef15befa Fixes a broken link to 'undefined is a keyword' (#38897) 
Fixes a broken link to 'undefined is a keyword' by replacing the wrong link with the correct one.
 2020-06-02 16:22:59 +09:00
Aditya Nagla
a6c2b5ee1d fix(curriculum) remove unnecessary */ from description (#38969) 2020-05-31 10:49:10 -05:00
John Montgomery
5cd850f666 Update wording of what multiplyAll should do in "Nesting For Loops" (#38852) 2020-05-31 08:16:00 -05:00
DaVicki
2e819b2e0a fix(curriculum): update instructions (#38865) 
* fix(learn): update instructions

edited text - change "returns a random number" to "returns a random whole number" to be more clear on the problem statement.

Address review comments : add the keyword "whole" to description, to make it consistent with challenge title and Instructions.
 2020-05-29 10:56:17 +02:00
PRAKASH
3c3ceaa3f5 Update declare-javascript-variables.english.md (#38884) 2020-05-27 09:37:34 +02:00
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges 
This includes certificates (where it does nothing), but does not
include any translations.
 2020-05-25 16:25:19 +05:30
Kristofer Koishigawa
b017ce192c fix: dotall flag not supported in firefox (#38762) 
Addresses https://github.com/freeCodeCamp/freeCodeCamp/pull/38546#issuecomment-625611675 where it's pointed out that Firefox doesn't support the /s regex flag yet. This workaround matches anything that's not blank.
 2020-05-08 19:27:32 +02:00
Eric Elli
f757840624 fix(learn): add test to return early pattern (#38751) 
* add: test to return early pattern

Currently no test for a = 0 or b = 0. This results in if(a<=0 || b<= 0) also being a valid solution

* fix: typo in test text

* fix: update return early pattern test

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-05-07 14:37:48 -05:00
Michael Schneider
1f2b66a432 feat: edit 2nd test description for clarity (#38661) 
current description logically fits, yet fails this solution: myVar = ++myVar;
 2020-05-02 08:27:52 -05:00
Farjad Fazli
fd85f57376 fix(learn): fixed typo "in the left" should be "at the left" (#38651) 
* Fixed typo "in the left" should be "at the left"

* Update curriculum/challenges/english/02-javascript-algorithms-and-data-structures/basic-javascript/comparison-with-the-equality-operator.english.md

Co-Authored-By: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>

Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
 2020-05-02 08:17:11 -05:00
Joel Duran
7035516483 fix: typo in 'Build JavaScript Objects' (#38690) 2020-04-30 17:41:55 +05:30
Oliver Eyton-Williams
f2f5dbc4b8 fix(curriculum): improve declaration tests (#38546) 2020-04-29 16:39:48 +05:30