gaspersic/freeCodeCamp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
25,692 Commits 9 Branches 0 Tags
f1c9b08cf322e4268a0a31ae9b5d75bf3cfce7d1
Commit Graph

62 Commits

Author SHA1 Message Date
Oliver Eyton-Williams
f1c9b08cf3 fix(curriculum): add isHidden: false to challenges 
This includes certificates (where it does nothing), but does not
include any translations.
 2020-05-25 16:25:19 +05:30
Ashraf Nazar
99c2f0d4f5 fix(curriculum): allow hex triplets for red and green colors to pass tests (#38523) 2020-04-12 17:15:31 +03:00
Randell Dawson
41718abf76 fix(learn): consolidate comments for responsive web design cert (#38256) 
Related to PR #38040

This PR is an attempt to consolidate/remove as many comments in the challenge seed code in the Responsive Web Design certification challenges, to be able to create a small translation lookup object for translating the English comments to other languages.
 2020-02-27 20:50:46 +05:30
lasjorg
9a5ae756ac fix(challenge): check inline style for color (#38211) 
* fix(challenge): check inline style for color

* Update curriculum/challenges/english/01-responsive-web-design/basic-css/change-the-color-of-text.english.md

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>

Co-authored-by: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2020-02-18 23:38:16 +05:30
John A Maloney
c935d21f84 Fixed bad capture group in regex (#37575) 2019-12-13 22:16:30 -06:00
Christoph Deil
dc5c0c7f82 Fix minor grammar issue in override-styles-in-subsequent-css.english.md (#37871) 2019-12-04 14:32:55 -08:00
mikemorr
62e1464eb7 change "given" to "adding" (Was: change "given" to "giving") (#37823) 
* change "given" to "giving"

* change to "adding" as suggested

As suggested in https://github.com/freeCodeCamp/freeCodeCamp/pull/37823
 2019-11-25 08:14:08 -08:00
Randell Dawson
9bf3fdbf38 fix(curriculum): changed challenge test text to use the word should for Responsive Web Design (#36860) 
* fix: changed challenge test text to use should

* fix: changed have to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: reworded test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: improved test verbiage

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected typo

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: changed have the to be used in

Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com>

* fix: corrected verbiage

Co-Authored-By: Parth Parth <34807532+thecodingaviator@users.noreply.github.com>
 2019-11-20 20:15:19 +05:30
Tristan Michael Lawrence
5296d5c731 fix: removed trailing spaces, fixed a typo (#37572) 
* removed trailing spaces, fixed a typo

* removed trailing spaces from basic-css challenges
 2019-11-10 04:33:10 -08:00
Daniel Veazey
7f4531aed0 replace the word "dashes" with "hyphens" (#37705) 2019-11-07 01:19:39 -05:00
SomeDer
bfa5c26288 fix: use dfn instead of code tag (#36640) 
* Use dfn tags

* remove misused <dfn> tags

* Revert "remove misused <dfn> tags"

This reverts commit b24968a968.

* Update curriculum/challenges/english/01-responsive-web-design/basic-html-and-html5/fill-in-the-blank-with-placeholder-text.english.md

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Make "array" lowercase

Co-Authored-By: Randell Dawson <5313213+RandellDawson@users.noreply.github.com>

* Fix dfn usage

* Address last dfn tags
 2019-10-27 12:45:37 -04:00
Ahmad Shahzad
9db88a0d7c Fixed a typo in Specify How Fonts Degrade lesson. (#37567) 
* Fixed a typo in Specify How Fonts Degrade.

'-->!' inside the code is misleading and prompts a learner
to put the exclamation mark when it is not needed as '-->!' is
also followed by a period.

Instead of "'-->!'.", it should be "'-->'."

* Made text wording consistent for the test instructions.

* Changed "To begin with," to "To begin," and fixed a minor typo.

If we are going to use "To begin with," the sentence should be
"To begin with the lesson/challenge", otherwise, "To begin" will
be more than enough.

Also added a space between "font(using HTML..." and changed it to
"font (using HTML...".
 2019-10-26 16:55:10 -04:00
Randell Dawson
568f00e02a fix(curriculum): Added forumTopicId to remaining 1200 challeng… (#36558) 2019-08-05 22:14:37 +05:30
Randell Dawson
3ec1fe8ea7 feat: add forumTopicId to challenge frontmatter [pre-existing] 
This commit adds the pre-existing challenge guide topics in the
forum to the forntmatter of their challenge markdown files.
 2019-08-05 22:14:37 +05:30
Randell Dawson
d0d8282f86 fix(curriculum): Remove additional unnecessary assert message argument wrapped in double quotes from various curriculum sections (#36457) 
* fix: remove double quoted assert msg arg - responsive

* fix: remove double quoted assert msg arg - js

* fix: remove double quoted assert msg arg - libraries

* fix: remove double quoted assert msg arg - coding interview
 2019-07-24 13:06:12 +01:00
Randell Dawson
87615d2a7b fix: removed assert msg argument (#36406) 2019-07-24 11:50:51 +02:00
Randell Dawson
c387873640 fix(curriculum): added extra line before </section> tag - Engl… (#36278) 2019-07-19 15:30:17 +05:30
Oliver Eyton-Williams
43fa451a38 fix(curriculum): Change wording to talk about inheritance not cascade (#36110) 2019-06-08 19:09:00 -07:00
Val Lipat
6feda1badb Improve capitalization (#36166) 2019-06-04 07:52:52 -07:00
Kyle Cheung
937dc23b5d fixed typos in custom css-variable challenge #36038 (#36041) 
* fixed typos in custom css-variable challenge

* fix: Remove extra line
 2019-05-14 20:31:03 +07:00
Randell Dawson
df8659ab8c fix(curriculum): Convert blockquote elements to triple backtick syntax for Responsive Web Design (#35993) 
* fix: converted blockquotes to code fences
 2019-05-14 10:11:58 +02:00
Huyen Nguyen
791e589c93 Remove tag characters (#36037) 2019-05-14 00:14:16 +05:30
Manish Giri
e736179720 fix(curriculum): Add solutions to CSS challenges (#35873) 2019-04-22 11:27:43 +05:30
Catalina
ffcb092bf1 Fixed CSS Challenge English version (#35849) 2019-04-20 09:49:23 -07:00
lasjorg
69d9d522a2 fix(challenge): fix broken regex (#35632) 
* fix(challenge): fix broken regex

* fix(challenge): update solution
 2019-03-26 21:48:52 -07:00
lasjorg
a1e853337b fix(challenge): simplify and cleanup tests (#35535) 2019-03-26 21:35:38 -07:00
Oliver Eyton-Williams
b10589fadf fix: Challenge solution added and broken test updated. (#35526) 
* fix: solution added and broken test updated.

* fix: Change test to equality and finish solution

* Update use-css-selectors-to-style-elements.english.md
 2019-03-26 21:01:22 -07:00
rupali317
bc72c86dc6 fix: updated the note sections for responsive web design english (#35528) 2019-03-22 15:02:12 +01:00
Nathan Lakritz
c31d1e2de9 Add semicolon to inline CSS (#34737) 2019-03-14 01:08:25 +05:30
Ron Sogueco
748212f99c fix: Test fails with comments (#35079) 
* fix: Test fails with comments

* fix: Account for last line of code

* fix: false positive for padding clockwise notation

* fix: false positive for commented blue-box class

* fix: use same assertion as #35342

* fix: update Solution section

* fix: update last test for margin/padding challenges
 2019-03-13 13:54:59 -04:00
Randell Dawson
9e07f99b9e fix(curriculum): Added test to validate clockwise notation is used for the Use Clockwise Notation to Specify the Margin of an Element challenge (#35342) 
* fix: corrected last test which validates clockwise notation

* fix: removed helper function

* fix: used jQuery to get style and removed extra slash
 2019-02-25 02:07:11 -05:00
Randell Dawson
aa621a20b5 fix: removed unecessary guideUrl from frontmatter 2019-02-19 11:34:27 +03:00
Riyaad Azad
2f27b6e687 Fix typo in description (#34413) 
Change "giving" in the Description section to "given"
 2019-02-18 00:53:36 +05:30
Nelson Wu
6128976cc5 Added a solution to fix stub (#34813) 
I am brand new to FCC and contributing on Github. I read the guide from FCC on best contributing practices, but this is all still very overwhelming to me.  If I did something incorrectly in my first attempt at a pull request, please let me know.
 2019-02-17 11:41:48 -05:00
Oliver Eyton-Williams
ba9e45023d fix: make border radius challenge Firefox compatible (#35009) 
* fix: make border radius challenge Firefox compatible

* fix: make border radius challenge Firefox compatible mk2
 2019-02-16 17:17:11 +00:00
gokulsg
63c5a94321 Expected solution for the challenge seed code (#32532) 
* Expected solution for the challenge seed code

I have updated the expected output for the challenge seed code.

* Update change-the-color-of-text.english.md

* fix: corrected solution section syntax
 2019-02-15 12:48:30 -05:00
JustinBen-Tzioni
ba0d4fb15f Improved grammar and message (#28795) 
* Improved grammar and message

* Update import-a-google-font.english.md
 2019-02-14 13:38:58 -08:00
JustinBen-Tzioni
7a3f9b0e94 Improved clarity of sentence. (#28791) 2019-02-14 12:11:39 -08:00
Tammy
9e4583b1f3 fix: change video url for clockwise-notation challenge (#35013) 2019-02-04 16:29:26 +03:00
Nelson Sandoval
a284b296fc fix: Capitalize test text for Cascading CSS variables (#34910) 2019-01-27 18:11:49 -07:00
lucielchoi707
2fea28aca8 add solution (#28406) 
LGTM!
 2019-01-24 15:57:09 -05:00
Ismael Casimpan
cffe1be295 Grammar consistency fix. (#24228) 
Entire article is using "isn't" so the "wasn't" seems out of place. I'm just following https://english.stackexchange.com/questions/283758/proper-use-of-was-vs-is
 2018-12-04 16:12:48 +00:00
Lxsthorne
786cda2627 Add challenge solution 
Added a solution. Please let me know if this is submitted incorrectly or in the wrong location.

<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->

- [X] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).
- [X] My pull request has a descriptive title (not a vague title like `Update index.md`)
- [X] My pull request targets the `master` branch of freeCodeCamp.
- [X] None of my changes are plagiarized from another source without proper attribution.
- [X] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.

Closes #XXXXX
 2018-12-03 23:10:41 +00:00
Anuj Jindal
bdbf83e5a2 added 01-responsive-web-design/basic-css/ (#22531) 
I have added use rgb-to-mix-color
 2018-11-25 10:20:27 -07:00
The Coding Aviator
b2328e96db Update import-a-google-font.english.md (#19717) 2018-11-18 08:45:03 -06:00
Dennis Wolfers
9c44af828d added missing word 'like' to the Instructions (#34215) 2018-11-05 19:20:22 +00:00
Prakhar Yadav
6ce41d6203 fixed a typo (#34170) 2018-11-03 01:24:58 +05:30
Lauren Van Sloun
c54896273b Added a missing space and period in basic-css challenge files (#20480) 
* Added missing space

* Added missing period in add-borders-around-your-elements.md

* Added missing space in adjust-the-padding-of-an-element.english.md
 2018-10-29 22:13:45 +07:00
Valeriy
dc7bb257b9 fix(curriculum): correct test 2018-10-28 03:16:22 +05:30
MackenzieThomasDevelopment
022a2fce8a Add solution using all code (#25669) 2018-10-25 08:22:13 -04:00