f613a1e5fd
* fix: replace index with script/styles as needed * fix: remove redundant fileKey It's overwritten by createPoly, so the parser does not need to create it * fix: curriculum test suite * Update client/src/templates/Challenges/classic/MultifileEditor.js Co-authored-by: Shaun Hamilton <shauhami020@gmail.com> Co-authored-by: Shaun Hamilton <shauhami020@gmail.com>
292 lines
9.6 KiB
JavaScript
292 lines
9.6 KiB
JavaScript
const isArray = require('lodash/isArray');
|
|
|
|
const adjacentKeysAST = require('../__fixtures__/ast-adjacent-keys.json');
|
|
const withBeforeAfterAST = require('../__fixtures__/ast-before-after.json');
|
|
const cCodeAST = require('../__fixtures__/ast-c-code.json');
|
|
const doubleMarkerAST = require('../__fixtures__/ast-double-marker.json');
|
|
const emptyAfterAST = require('../__fixtures__/ast-empty-after.json');
|
|
const emptyBeforeAST = require('../__fixtures__/ast-empty-before.json');
|
|
const emptyContentAST = require('../__fixtures__/ast-empty-contents.json');
|
|
const emptyCSSAST = require('../__fixtures__/ast-empty-css.json');
|
|
const emptyHTMLAST = require('../__fixtures__/ast-empty-html.json');
|
|
const explodedMarkerAST = require('../__fixtures__/ast-exploded-marker.json');
|
|
const jsxSeedAST = require('../__fixtures__/ast-jsx-seed.json');
|
|
const orphanKeyAST = require('../__fixtures__/ast-orphan-key.json');
|
|
const withSeedKeysAST = require('../__fixtures__/ast-seed-keys.json');
|
|
const simpleAST = require('../__fixtures__/ast-simple.json');
|
|
const withExtraLinesAST = require('../__fixtures__/ast-with-extra-lines.json');
|
|
const withEditableAST = require('../__fixtures__/ast-with-markers.json');
|
|
|
|
const addSeed = require('./add-seed');
|
|
|
|
describe('add-seed plugin', () => {
|
|
const plugin = addSeed();
|
|
let file = { data: {} };
|
|
|
|
beforeEach(() => {
|
|
file = { data: {} };
|
|
});
|
|
|
|
it('returns a function', () => {
|
|
expect(typeof plugin).toEqual('function');
|
|
});
|
|
|
|
it('adds a `challengeFiles` property to `file.data`', () => {
|
|
plugin(simpleAST, file);
|
|
expect('challengeFiles' in file.data).toBe(true);
|
|
});
|
|
|
|
it('ensures that the `challengeFiles` property is an array', () => {
|
|
plugin(simpleAST, file);
|
|
expect(isArray(file.data.challengeFiles)).toBe(true);
|
|
});
|
|
|
|
it('adds test objects to the challengeFiles array following a schema', () => {
|
|
expect.assertions(15);
|
|
plugin(simpleAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const testObject = challengeFiles.find(x => x.ext === 'js');
|
|
expect(Object.keys(testObject).length).toEqual(7);
|
|
expect(testObject).toHaveProperty('ext');
|
|
expect(typeof testObject['ext']).toBe('string');
|
|
expect(testObject).toHaveProperty('name');
|
|
expect(typeof testObject['name']).toBe('string');
|
|
expect(testObject).toHaveProperty('contents');
|
|
expect(typeof testObject['contents']).toBe('string');
|
|
expect(testObject).toHaveProperty('head');
|
|
expect(typeof testObject['head']).toBe('string');
|
|
expect(testObject).toHaveProperty('tail');
|
|
expect(typeof testObject['tail']).toBe('string');
|
|
expect(testObject).toHaveProperty('id');
|
|
expect(typeof testObject['id']).toBe('string');
|
|
expect(testObject).toHaveProperty('editableRegionBoundaries');
|
|
expect(isArray(testObject['editableRegionBoundaries'])).toBe(true);
|
|
});
|
|
|
|
it('parses seeds without ids', () => {
|
|
expect.assertions(3);
|
|
plugin(simpleAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(scriptjs.contents).toBe(`var x = 'y';`);
|
|
expect(indexhtml.contents).toBe(`<html>
|
|
<body>
|
|
</body>
|
|
</html>`);
|
|
expect(stylescss.contents).toBe(`body {
|
|
background: green;
|
|
}`);
|
|
});
|
|
|
|
it('removes region markers from contents', () => {
|
|
expect.assertions(2);
|
|
plugin(withEditableAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(stylescss.contents).not.toMatch('--fcc-editable-region--');
|
|
expect(stylescss.editableRegionBoundaries).toEqual([1, 4]);
|
|
});
|
|
|
|
// TODO: can we reuse 'name'? It's always 'index', I think, which suggests
|
|
// it could be reused as an id. Revisit this once the parser is live.
|
|
it('parses seeds with adjacent ids, adding the id to data', () => {
|
|
expect.assertions(3);
|
|
plugin(withSeedKeysAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(indexhtml.id).toBe('');
|
|
expect(stylescss.id).toBe('key-for-css');
|
|
expect(scriptjs.id).toBe('key-for-js');
|
|
});
|
|
|
|
it('throws if an id is anywhere except directly before a code node', () => {
|
|
expect.assertions(2);
|
|
expect(() => plugin(adjacentKeysAST, file)).toThrow(
|
|
'::id{#id}s must come before code blocks'
|
|
);
|
|
expect(() => plugin(orphanKeyAST, file)).toThrow(
|
|
'::id{#id}s must come before code blocks'
|
|
);
|
|
});
|
|
|
|
it('ignores empty lines between ::id{#id}s and code blocks', () => {
|
|
expect.assertions(1);
|
|
plugin(withSeedKeysAST, file);
|
|
const fileTwo = { data: {} };
|
|
plugin(withExtraLinesAST, fileTwo);
|
|
expect(file).toEqual(fileTwo);
|
|
});
|
|
|
|
it('gets the before-user-code for each language', () => {
|
|
expect.assertions(3);
|
|
plugin(withBeforeAfterAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(scriptjs.head).toBe('');
|
|
expect(indexhtml.head).toBe(`<!-- comment -->`);
|
|
expect(stylescss.head).toBe(`body {
|
|
etc: ''
|
|
}`);
|
|
});
|
|
|
|
it('gets the after-user-code for each language', () => {
|
|
expect.assertions(3);
|
|
plugin(withBeforeAfterAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(scriptjs.tail).toBe(`function teardown(params) {
|
|
// after
|
|
}`);
|
|
expect(indexhtml.tail).toBe('');
|
|
expect(stylescss.tail).toBe(`body {
|
|
background: blue;
|
|
}`);
|
|
});
|
|
|
|
it('throws an error if there is any code of an unsupported language', () => {
|
|
expect.assertions(1);
|
|
expect(() => plugin(cCodeAST, file)).toThrow(
|
|
"On line 30 'c' is not a supported language.\n" +
|
|
' Please use one of js, css, html, jsx or py'
|
|
);
|
|
});
|
|
|
|
it('throws if there is before/after code with empty blocks', () => {
|
|
expect.assertions(2);
|
|
expect(() => plugin(emptyHTMLAST, file)).toThrow(
|
|
'Empty code block in --before-user-code-- section'
|
|
);
|
|
expect(() => plugin(emptyCSSAST, file)).toThrow(
|
|
'Empty code block in --after-user-code-- section'
|
|
);
|
|
});
|
|
|
|
it('quietly ignores empty before sections', () => {
|
|
expect.assertions(6);
|
|
plugin(emptyBeforeAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(scriptjs.head).toBe('');
|
|
expect(scriptjs.tail).toBe('function teardown(params) {\n // after\n}');
|
|
expect(indexhtml.head).toBe('');
|
|
expect(indexhtml.tail).toBe('');
|
|
expect(stylescss.head).toBe('');
|
|
expect(stylescss.tail).toBe('body {\n background: blue;\n}');
|
|
});
|
|
|
|
it('quietly ignores empty after sections', () => {
|
|
expect.assertions(6);
|
|
plugin(emptyAfterAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const scriptjs = challengeFiles.find(x => x.ext === 'js');
|
|
const indexhtml = challengeFiles.find(x => x.ext === 'html');
|
|
const stylescss = challengeFiles.find(x => x.ext === 'css');
|
|
|
|
expect(scriptjs.head).toBe('');
|
|
expect(scriptjs.tail).toBe('');
|
|
expect(indexhtml.head).toBe('<!-- comment -->');
|
|
expect(indexhtml.tail).toBe('');
|
|
expect(stylescss.head).toBe("body {\n etc: ''\n}");
|
|
expect(stylescss.tail).toBe('');
|
|
});
|
|
|
|
it('throws an error (with line number) if 2 markers appear on 1 line', () => {
|
|
expect.assertions(1);
|
|
expect(() => plugin(doubleMarkerAST, file)).toThrow(
|
|
`Line 8 has two markers. Each line should only have one.`
|
|
);
|
|
});
|
|
|
|
it('throws if a javascript file has formatted a marker', () => {
|
|
expect.assertions(1);
|
|
expect(() => plugin(explodedMarkerAST, file)).toThrow(
|
|
`Line 66 has a malformed marker. It should be --fcc-editable-region--`
|
|
);
|
|
});
|
|
|
|
it('handles jsx', () => {
|
|
expect.assertions(3);
|
|
plugin(jsxSeedAST, file);
|
|
const {
|
|
data: { challengeFiles }
|
|
} = file;
|
|
const indexjsx = challengeFiles.find(x => x.ext === 'jsx');
|
|
|
|
expect(indexjsx.head).toBe(`function setup() {}`);
|
|
expect(indexjsx.tail).toBe(`function teardown(params) {
|
|
// after
|
|
}`);
|
|
expect(indexjsx.contents).toBe(`var x = 'y';
|
|
|
|
/* comment */
|
|
const Button = () => {
|
|
return <button> {/* another comment! */} text </button>;
|
|
};`);
|
|
});
|
|
|
|
it('combines all the code of a specific language into a single file', () => {
|
|
/* Revisit this once we've decided what to do about multifile imports. I
|
|
think the best approach is likely to be use the following format for .files
|
|
|
|
{ css: [css files],
|
|
html: [html files],
|
|
...
|
|
}
|
|
|
|
or
|
|
|
|
{ css: {css files},
|
|
html: {html files},
|
|
...
|
|
}
|
|
|
|
depending on what's easier to work with in graphQL
|
|
|
|
*/
|
|
});
|
|
|
|
it('should throw an error if a seed has no contents', () => {
|
|
expect.assertions(1);
|
|
expect(() => plugin(emptyContentAST, file)).toThrow(
|
|
`## --seed-contents-- must appear in # --seed-- sections`
|
|
);
|
|
});
|
|
|
|
it('should have an output to match the snapshot', () => {
|
|
plugin(simpleAST, file);
|
|
expect(file.data).toMatchSnapshot();
|
|
});
|
|
});
|