Merge pull request #3535 from fjl/all-ineffassign

all: fix ineffectual assignments
This commit is contained in:
Péter Szilágyi
2017-01-09 23:53:17 +02:00
committed by GitHub
34 changed files with 111 additions and 187 deletions

View File

@ -267,8 +267,7 @@ func (self *CodeRequest) Valid(db ethdb.Database, msg *Msg) bool {
return false
}
data := reply[0]
hash := crypto.Sha3Hash(data)
if !bytes.Equal(self.Hash[:], hash[:]) {
if hash := crypto.Keccak256Hash(data); self.Hash != hash {
glog.V(logger.Debug).Infof("ODR: requested hash %08x does not match received data hash %08x", self.Hash[:4], hash[:4])
return false
}