mobile: don't retain transient []byte in CallMsg.SetData (#14804)
* mobile: don't retain transient []byte in CallMsg.SetData Go mobile doesn't copy []byte parameters, for performance and to allow writes to the byte array be reflected in the native byte array. Unfortunately, that means []byte arguments are only valid during the call it is being passed into. CallMsg.SetData retains such a byte array. Copy it instead Fixes #14675 * mobile: copy all []byte arguments from gomobile To avoid subtle errors when accidentially retaining an otherwise transient byte slice coming from gomobile, copy all byte slices before use. * mobile: replace copySlice with common.CopyBytes
This commit is contained in:
committed by
Péter Szilágyi
parent
cf5d4b5541
commit
23c6fcdbe8
@ -21,6 +21,8 @@ package geth
|
||||
import (
|
||||
"errors"
|
||||
"math/big"
|
||||
|
||||
"github.com/ethereum/go-ethereum/common"
|
||||
)
|
||||
|
||||
// A BigInt represents a signed multi-precision integer.
|
||||
@ -52,7 +54,7 @@ func (bi *BigInt) GetInt64() int64 {
|
||||
// SetBytes interprets buf as the bytes of a big-endian unsigned integer and sets
|
||||
// the big int to that value.
|
||||
func (bi *BigInt) SetBytes(buf []byte) {
|
||||
bi.bigint.SetBytes(buf)
|
||||
bi.bigint.SetBytes(common.CopyBytes(buf))
|
||||
}
|
||||
|
||||
// SetInt64 sets the big int to x.
|
||||
|
Reference in New Issue
Block a user