all: use gometalinter.v2, fix new gosimple issues (#15650)

2017-12-12 18:05:47 +00:00
parent bbea4b2b53
commit 3da1bf8ca1
24 changed files with 57 additions and 67 deletions
--- a/core/asm/asm.go
+++ b/core/asm/asm.go
@@ -114,10 +114,7 @@ func PrintDisassembled(code string) error {
 			fmt.Printf("%06v: %v\n", it.PC(), it.Op())
 		}
 	}
-	if err := it.Error(); err != nil {
-		return err
-	}
-	return nil
+	return it.Error()
 }

 // Return all disassembled EVM instructions in human-readable format.