cmd/devp2p: refactor eth test suite (#22843)

Browse Source

This PR refactors the eth test suite to make it more readable and
easier to use. Some notable differences:

- A new file helpers.go stores all of the methods used between
  both eth66 and eth65 and below tests, as well as methods shared
  among many test functions.
- suite.go now contains all of the test functions for both eth65
  tests and eth66 tests.
- The utesting.T object doesn't get passed through to other helper methods,
  but is instead only used within the scope of the test function,
  whereas helper methods return errors, so only the test function
  itself can fatal out in the case of an error.
- The full test suite now only takes 13.5 seconds to run.

...

This commit is contained in:

rene

2021-05-25 23:09:11 +02:00

committed by GitHub

parent 6c7d6cf886

commit 49bde05a55

7 changed files with 1506 additions and 1461 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

920

cmd/devp2p/internal/ethtest/suite.go

File diff suppressed because it is too large Load Diff