gaspersic/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

network/bitvector: Multibit set/unset + string rep (#1530)

Browse Source 
* network/bitvector: Multibit set/unset + string rep

* network/bitvector: Add code comments

* network/bitvector: Make Unset -> Set with bool false

* network/bitvector: Revert to Set/Unset

* network/stream: Update to new bitvector signature
This commit is contained in:
lash
2019-07-02 18:08:00 +02:00
committed by GitHub
parent b3f21ddbba
commit a6e64aea67
3 changed files with 102 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
network/bitvector/bitvector_test.go
View File

@@ -18,6 +18,7 @@ package bitvector
import "testing"
// TestBitvectorNew checks that enforcements of argument length works in the constructors
func TestBitvectorNew(t *testing.T) {
_, err := New(0)
if err != errInvalidLength {
@@ -40,6 +41,7 @@ func TestBitvectorNew(t *testing.T) {
}
}
// TestBitvectorGetSet tests correctness of individual Set and Get commands
func TestBitvectorGetSet(t *testing.T) {
for _, length := range []int{
1,
@@ -71,7 +73,7 @@ func TestBitvectorGetSet(t *testing.T) {
}()
for i := 0; i < length; i++ {
bv.Set(i, true)
bv.Set(i)
for j := 0; j < length; j++ {
if j == i {
if !bv.Get(j) {
@@ -84,7 +86,7 @@ func TestBitvectorGetSet(t *testing.T) {
}
}
bv.Set(i, false)
bv.Unset(i)
if bv.Get(i) {
t.Errorf("element on index %v is not set to false", i)
@@ -93,6 +95,7 @@ func TestBitvectorGetSet(t *testing.T) {
}
}
// TestBitvectorNewFromBytesGet tests that bit vector is initialized correctly from underlying byte slice
func TestBitvectorNewFromBytesGet(t *testing.T) {
bv, err := NewFromBytes([]byte{8}, 8)
if err != nil {
@@ -102,3 +105,36 @@ func TestBitvectorNewFromBytesGet(t *testing.T) {
t.Fatalf("element 3 is not set to true: state %08b", bv.b[0])
}
}
// TestBitVectorString tests that string representation of bit vector is correct
func TestBitVectorString(t *testing.T) {
b := []byte{0xa5, 0x81}
expect := "1010010110000001"
bv, err := NewFromBytes(b, 2)
if err != nil {
t.Fatal(err)
}
if bv.String() != expect {
t.Fatalf("bitvector string fail: got %s, expect %s", bv.String(), expect)
}
}
// TestBitVectorSetUnsetBytes tests that setting and unsetting by byte slice modifies the bit vector correctly
func TestBitVectorSetBytes(t *testing.T) {
b := []byte{0xff, 0xff}
cb := []byte{0xa5, 0x81}
expectUnset := "0101101001111110"
expectReset := "1111111111111111"
bv, err := NewFromBytes(b, 2)
if err != nil {
t.Fatal(err)
}
bv.UnsetBytes(cb)
if bv.String() != expectUnset {
t.Fatalf("bitvector unset bytes fail: got %s, expect %s", bv.String(), expectUnset)
}
bv.SetBytes(cb)
if bv.String() != expectReset {
t.Fatalf("bitvector reset bytes fail: got %s, expect %s", bv.String(), expectReset)
}
}