all: seperate consensus error and evm internal error (#20830)
* all: seperate consensus error and evm internal error There are actually two types of error will be returned when a tranaction/message call is executed: (a) consensus error (b) evm internal error. The former should be converted to a consensus issue, e.g. The sender doesn't enough asset to purchase the gas it specifies. The latter is allowed since evm itself is a blackbox and internal error is allowed to happen. This PR emphasizes the difference by introducing a executionResult structure. The evm error is embedded inside. So if any error returned, it indicates consensus issue happens. And also this PR improve the `EstimateGas` API to return the concrete revert reason if the transaction always fails * all: polish * accounts/abi/bind/backends: add tests * accounts/abi/bind/backends, internal: cleanup error message * all: address comments * core: fix lint * accounts, core, eth, internal: address comments * accounts, internal: resolve revert reason if possible * accounts, internal: address comments
This commit is contained in:
		@@ -186,7 +186,7 @@ func (t *StateTest) RunNoVerify(subtest StateSubtest, vmconfig vm.Config, snapsh
 | 
			
		||||
	gaspool := new(core.GasPool)
 | 
			
		||||
	gaspool.AddGas(block.GasLimit())
 | 
			
		||||
	snapshot := statedb.Snapshot()
 | 
			
		||||
	if _, _, _, err := core.ApplyMessage(evm, msg, gaspool); err != nil {
 | 
			
		||||
	if _, err := core.ApplyMessage(evm, msg, gaspool); err != nil {
 | 
			
		||||
		statedb.RevertToSnapshot(snapshot)
 | 
			
		||||
	}
 | 
			
		||||
	// Commit block
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user