gaspersic/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tests/fuzzers: fix goroutine leak in les fuzzer (#22455)

Browse Source 
The oss-fuzz fuzzer has been reporting some failing testcases for les. They're all spurious, and cannot reliably be reproduced. However, running them showed that there was a goroutine leak: the tests created a lot of new clients, which started an exec queue that was never torn down.

This PR fixes the goroutine leak, and also a log message which was erroneously formatted.
This commit is contained in:
Martin Holst Swende
2021-03-16 09:43:33 +01:00
committed by GitHub
parent faacc8e0fa
commit bc47993692
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/fuzzers/les/les-fuzzer.go
View File

@ -261,18 +261,18 @@ func (d dummyMsg) Decode(val interface{}) error {
}
func (f *fuzzer) doFuzz(msgCode uint64, packet interface{}) {
version := f.randomInt(3) + 2 // [LES2, LES3, LES4]
peer := l.NewFuzzerPeer(version)
enc, err := rlp.EncodeToBytes(packet)
if err != nil {
panic(err)
}
version := f.randomInt(3) + 2 // [LES2, LES3, LES4]
peer, closeFn := l.NewFuzzerPeer(version)
defer closeFn()
fn, _, _, err := l.Les3[msgCode].Handle(dummyMsg{enc})
if err != nil {
panic(err)
}
fn(f, peer, func() bool { return true })
}
func Fuzz(input []byte) int {