gaspersic/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

accounts/abi: remove check for len%32==0 when unpacking events (#15670)

Browse Source 
This change inlines the logic of bytesAreProper at its sole
callsite, ABI.Unpack, and applies the multiple-of-32 test only in
the case of unpacking methods. Event data is not required to be a
multiple of 32 bytes long.
This commit is contained in:
Bob Glickstein
2017-12-21 01:59:14 -08:00
committed by Felix Lange
parent 9f1007e554
commit e21aa0fda3
3 changed files with 47 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
accounts/abi/unpack.go
View File

@ -203,14 +203,3 @@ func lengthPrefixPointsTo(index int, output []byte) (start int, length int, err
//fmt.Printf("LENGTH PREFIX INFO: \nsize: %v\noffset: %v\nstart: %v\n", length, offset, start)
return
}
// checks for proper formatting of byte output
func bytesAreProper(output []byte) error {
if len(output) == 0 {
return fmt.Errorf("abi: unmarshalling empty output")
} else if len(output)%32 != 0 {
return fmt.Errorf("abi: improperly formatted output")
} else {
return nil
}
}