gaspersic/go-ethereum
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

p2p: changed if-else blocks to conform with golint (#16660)

Browse Source
This commit is contained in:
GagziW
2018-05-03 01:33:39 -07:00
committed by Péter Szilágyi
parent ea1724de1a
commit f2447bd4c3
2 changed files with 15 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
p2p/message.go
View File

@ -229,21 +229,20 @@ func ExpectMsg(r MsgReader, code uint64, content interface{}) error {
} }
if content == nil { if content == nil {
return msg.Discard() return msg.Discard()
} else { }
contentEnc, err := rlp.EncodeToBytes(content) contentEnc, err := rlp.EncodeToBytes(content)
if err != nil { if err != nil {
panic("content encode error: " + err.Error()) panic("content encode error: " + err.Error())
} }
if int(msg.Size) != len(contentEnc) { if int(msg.Size) != len(contentEnc) {
return fmt.Errorf("message size mismatch: got %d, want %d", msg.Size, len(contentEnc)) return fmt.Errorf("message size mismatch: got %d, want %d", msg.Size, len(contentEnc))
} }
actualContent, err := ioutil.ReadAll(msg.Payload) actualContent, err := ioutil.ReadAll(msg.Payload)
if err != nil { if err != nil {
return err return err
} }
if !bytes.Equal(actualContent, contentEnc) { if !bytes.Equal(actualContent, contentEnc) {
return fmt.Errorf("message payload mismatch:\ngot: %x\nwant: %x", actualContent, contentEnc) return fmt.Errorf("message payload mismatch:\ngot: %x\nwant: %x", actualContent, contentEnc)
}
} }
return nil return nil
} }

3
p2p/simulations/network.go
View File

@ -738,7 +738,6 @@ func (self *Network) executeNodeEvent(e *Event) error {
func (self *Network) executeConnEvent(e *Event) error { func (self *Network) executeConnEvent(e *Event) error {
if e.Conn.Up { if e.Conn.Up {
return self.Connect(e.Conn.One, e.Conn.Other) return self.Connect(e.Conn.One, e.Conn.Other)
} else {
return self.Disconnect(e.Conn.One, e.Conn.Other)
} }
return self.Disconnect(e.Conn.One, e.Conn.Other)
} }