p2p: rework protocol API

p2p/message_test.go

@@ -1,38 +1,67 @@
 package p2p
 
 import (
+	"bytes"
+	"io/ioutil"
 	"testing"
+
+	"github.com/ethereum/go-ethereum/ethutil"
 )
 
 func TestNewMsg(t *testing.T) {
-	msg, _ := NewMsg(3, 1, "000")
-	if msg.Code() != 3 {
-		t.Errorf("incorrect code %v", msg.Code())
+	msg := NewMsg(3, 1, "000")
+	if msg.Code != 3 {
+		t.Errorf("incorrect code %d, want %d", msg.Code)
 	}
-	data0 := msg.Data().Get(0).Uint()
-	data1 := string(msg.Data().Get(1).Bytes())
-	if data0 != 1 {
-		t.Errorf("incorrect data %v", data0)
+	if msg.Size != 5 {
+		t.Errorf("incorrect size %d, want %d", msg.Size, 5)
 	}
-	if data1 != "000" {
-		t.Errorf("incorrect data %v", data1)
+	pl, _ := ioutil.ReadAll(msg.Payload)
+	expect := []byte{0x01, 0x83, 0x30, 0x30, 0x30}
+	if !bytes.Equal(pl, expect) {
+		t.Errorf("incorrect payload content, got %x, want %x", pl, expect)
 	}
 }
 
 func TestEncodeDecodeMsg(t *testing.T) {
-	msg, _ := NewMsg(3, 1, "000")
-	encoded := msg.Encode(3)
-	msg, _ = NewMsgFromBytes(encoded)
-	msg.Decode(3)
-	if msg.Code() != 3 {
-		t.Errorf("incorrect code %v", msg.Code())
+	msg := NewMsg(3, 1, "000")
+	buf := new(bytes.Buffer)
+	if err := writeMsg(buf, msg); err != nil {
+		t.Fatalf("encodeMsg error: %v", err)
 	}
-	data0 := msg.Data().Get(0).Uint()
-	data1 := msg.Data().Get(1).Str()
-	if data0 != 1 {
-		t.Errorf("incorrect data %v", data0)
+
+	t.Logf("encoded: %x", buf.Bytes())
+
+	decmsg, err := readMsg(buf)
+	if err != nil {
+		t.Fatalf("readMsg error: %v", err)
 	}
-	if data1 != "000" {
-		t.Errorf("incorrect data %v", data1)
+	if decmsg.Code != 3 {
+		t.Errorf("incorrect code %d, want %d", decmsg.Code, 3)
+	}
+	if decmsg.Size != 5 {
+		t.Errorf("incorrect size %d, want %d", decmsg.Size, 5)
+	}
+	data, err := decmsg.Data()
+	if err != nil {
+		t.Fatalf("first payload item decode error: %v", err)
+	}
+	if v := data.Get(0).Uint(); v != 1 {
+		t.Errorf("incorrect data[0]: got %v, expected %d", v, 1)
+	}
+	if v := data.Get(1).Str(); v != "000" {
+		t.Errorf("incorrect data[1]: got %q, expected %q", v, "000")
+	}
+}
+
+func TestDecodeRealMsg(t *testing.T) {
+	data := ethutil.Hex2Bytes("2240089100000080f87e8002b5457468657265756d282b2b292f5065657220536572766572204f6e652f76302e372e382f52656c656173652f4c696e75782f672b2bc082765fb84086dd80b7aefd6a6d2e3b93f4f300a86bfb6ef7bdc97cb03f793db6bb")
+	msg, err := readMsg(bytes.NewReader(data))
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+
+	if msg.Code != 0 {
+		t.Errorf("incorrect code %d, want %d", msg.Code, 0)
 	}
 }