common/fdlimit: cap on MacOS file limits, fixes #18994 (#19035)

* common/fdlimit: cap on MacOS file limits, fixes #18994

* common/fdlimit: fix Maximum-check to respect OPEN_MAX

* common/fdlimit: return error if OPEN_MAX is exceeded in Raise()

* common/fdlimit: goimports

* common/fdlimit: check value after setting fdlimit

* common/fdlimit: make comment a bit more descriptive

* cmd/utils: make fdlimit happy path a bit cleaner
This commit is contained in:
Martin Holst Swende
2019-02-12 11:29:05 +01:00
committed by Péter Szilágyi
parent 3de19c8b31
commit f48da43bae
5 changed files with 22 additions and 13 deletions

View File

@ -20,7 +20,7 @@ import "errors"
// Raise tries to maximize the file descriptor allowance of this process
// to the maximum hard-limit allowed by the OS.
func Raise(max uint64) error {
func Raise(max uint64) (uint64, error) {
// This method is NOP by design:
// * Linux/Darwin counterparts need to manually increase per process limits
// * On Windows Go uses the CreateFile API, which is limited to 16K files, non
@ -30,7 +30,7 @@ func Raise(max uint64) error {
if max > 16384 {
return errors.New("file descriptor limit (16384) reached")
}
return nil
return max, nil
}
// Current retrieves the number of file descriptors allowed to be opened by this