rlp: allow encoding non-empty interface values
This needs to be supported because []someInterface does occur sometimes. Funny enough, the fix involves changes to the decoder. makeDecoder cannot return an error for non-empty interfaces anymore because the type cache builds both decoder and writer. Do the check at 'runtime' instead.
This commit is contained in:
@ -32,9 +32,19 @@ func (e byteEncoder) EncodeRLP(w io.Writer) error {
|
||||
return nil
|
||||
}
|
||||
|
||||
type encodableReader struct {
|
||||
A, B uint
|
||||
}
|
||||
|
||||
func (e *encodableReader) Read(b []byte) (int, error) {
|
||||
panic("called")
|
||||
}
|
||||
|
||||
var (
|
||||
_ = Encoder(&testEncoder{})
|
||||
_ = Encoder(byteEncoder(0))
|
||||
|
||||
reader io.Reader = &encodableReader{1, 2}
|
||||
)
|
||||
|
||||
type encTest struct {
|
||||
@ -176,6 +186,9 @@ var encTests = []encTest{
|
||||
{val: (*[]struct{ uint })(nil), output: "C0"},
|
||||
{val: (*interface{})(nil), output: "C0"},
|
||||
|
||||
// interfaces
|
||||
{val: []io.Reader{reader}, output: "C3C20102"}, // the contained value is a struct
|
||||
|
||||
// Encoder
|
||||
{val: (*testEncoder)(nil), output: "00000000"},
|
||||
{val: &testEncoder{}, output: "00010001000100010001"},
|
||||
|
Reference in New Issue
Block a user