* Charge witness gas when calling/creating a contract
Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
* gofmt
* replace checks with evm.Access!=nil with IsCancun
* remove double-charging of witness access costs for contract creation initialization
Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
* core/vm: verkle extcodecopy naive way (do jumpdest analysis on target contract every EXTCODECOPY)
* no double-charge
* address edge-case in touchEachChunksAndChargeGas
* simplify line
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
* replace sha256 with pedersen_hash
* fix: prevent an OOB
* workaround timeout in unit test
* update go-ipa and reduce the timeout
* fix for unit tests: do not call NewAccessWitness in NewEVMTxContext (#49)
* potential fix: do not call NewAccessWitness in NewEVMTxContext
* more fixes: check for the existence of Accesses
* fix absence of witness in copy
* fix another witness issue
* workaround: ensure the prefetcher is off in verkle mode
* fix the remaining issues in tests
* review feedback
* fix witness allocation in stateless test
* make push dynamically-charged. charge witness gas costs for push. refactor evm witness gas charging to move logic for touching a range of bytecode into a helper method 'touchEachChunksAndChargeGas'
* add witness gas calculation for CodeCopy, ExtCodeCopy, SLoad back to gas_table.go
* witness gas charging for CALL
* remove explicit reference to evm.TxContext
* core/vm: make touchEachChunksAndCharge gas handle nil code value
* core/vm: call implementation, separate out witnesses into touch/set
* some fixes
* remove witness touching from opCall: this will go in evm.go
* remove witness touching for call from gas_table.go
* (hopefully) fix tests
* add SSTORE witness charging that was removed mistakenly
* charge witness gas for call
* clean up and comment touchEachChunksAndChargeGas
* make suggested changes
* address remaining points
* fix build issues
* remove double-charging for contract creation witness gas charging
upgrade to latest go-verkle
update go-verkle to get more fixes
simplify code by removing all stateless references (#25)
fix verkle proof test by enforcing values alignment to 32 bytes
remove unneeded KZG tag
fix the stateless test
Move AccessWitness into StateDB (#27)
* move AccessWitness into StateDB
* set Accesses in TxContext constructor
* Ensures that a statedb is initialized with a witness
* copy AccessWitness in StateDB.Copy. use copied state in miner worker.commit.
* remove redundant line
Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com>
Fix contract creation issue
verkle: Implement Trie, NodeIterator and Database ifs
Fix crash in TestDump
Fix TestDump
Fix TrieCopy
remove unnecessary traces
fix: Error() returned errIteratorEnd in verkle node iterator
rewrite the iterator and change the signature of OpenStorageTrie
add the adapter to reuse the account trie for storage
don't try to deserialize a storage leaf into an account
Fix statedb unit tests (#14)
* debug code
* Fix more unit tests
* remove traces
* Go back to the full range
One tree to rule them all
remove updateRoot, there is no root to update
store code inside the account leaf
fix build
save current state for Sina
Update go-verkle to latest
Charge WITNESS_*_COST gas on storage loads
Add witness costs for SSTORE as well
Charge witness gas in the case of code execution
corresponding code deletion
add a --verkle flag to separate verkle experiments from regular geth operations
use the snapshot to get data
stateless execution from block witness
AccessWitness functions
Add block generation test + genesis snapshot generation
test stateless block execution (#18)
* test stateless block execution
* Force tree resolution before generating the proof
increased coverage in stateless test execution (#19)
* test stateless block execution
* Force tree resolution before generating the proof
* increase coverage in stateless test execution
ensure geth compiles
fix issues in tests with verkle trees deactivated
Ensure stateless data is available when executing statelessly (#20)
* Ensure stateless data is available when executing statelessly
* Actual execution of a statless block
* bugfixes in stateless block execution
* code cleanup
- Reduce PR footprint by reverting NewEVM to its original signature
- Move the access witness to the block context
- prepare for a change in AW semantics
Need to store the initial values.
- Use the touch helper function, DRY
* revert the signature of MustCommit to its original form (#21)
fix leaf proofs in stateless execution (#22)
* Fixes in witness pre-state
* Add the recipient's nonce to the witness
* reduce PR footprint and investigate issue in root state calculation
* quick build fix
cleanup: Remove extra parameter in ToBlock
revert ToBlock to its older signature
fix import cycle in vm tests
fix linter issue
fix appveyor build
fix nil pointers in tests
Add indices, yis and Cis to the block's Verkle proof
upgrade geth dependency to drop geth's common dep
fix cmd/devp2p tests
fix rebase issues
quell an appveyor warning
fix address touching in SLOAD and SSTORE
fix access witness for code size
touch target account data before calling
make sure the proper locations get touched in (ext)codecopy
touch all code pages in execution
add pushdata to witness
remove useless code in genesis snapshot generation
testnet: fix some of the rebase/drift issues
Fix verkle proof generation in block
fix an issue occuring when chunking past the code size
fix: ensure the code copy doesn't extend past the code size
* all: mv loggers to eth/tracers
* core/vm: minor
* eth/tracers: tmp comment out testStoreCapture
* eth/tracers: uncomment and fix logger test
* eth/tracers: simplify test
* core/vm: re-add license
* core/vm: minor
* rename LogConfig to Config
This change introduces 2 new optional methods; `enter()` and `exit()` for js tracers, and makes `step()` optiona. The two new methods are invoked when entering and exiting a call frame (but not invoked for the outermost scope, which has it's own methods). Currently these are the data fields passed to each of them:
enter: type (opcode), from, to, input, gas, value
exit: output, gasUsed, error
The PR also comes with a re-write of the callTracer. As a backup we keep the previous tracing script under the name `callTracerLegacy`. Behaviour of both tracers are equivalent for the most part, although there are some small differences (improvements), where the new tracer is more correct / has more information.
* internal/ethapi: revert + fix properly in al tracer
* internal/ethapi: use toMessage instead of creating new message
* internal/ethapi: remove ineffassign
* core: fix invalid unmarshalling, fix test
Co-authored-by: Martin Holst Swende <martin@swende.se>
Previously, the makeCallVariantGasCallEIP2929 charged the cold account access cost directly, leading to an incorrect gas cost passed to the tracer from the main execution loop.
This change still temporarily charges the cost (to allow for an accurate calculation of the available gas for the call), but then afterwards refunds it and instead returns the correct total gas cost to be then properly charged in the main loop.
* core/vm: implement AccessListTracer
* eth: implement debug.createAccessList
* core/vm: fixed nil panics in accessListTracer
* eth: better error messages for createAccessList
* eth: some fixes on CreateAccessList
* eth: allow for provided accesslists
* eth: pass accesslist by value
* eth: remove created acocunt from accesslist
* core/vm: simplify access list tracer
* core/vm: unexport accessListTracer
* eth: return best guess if al iteration times out
* eth: return best guess if al iteration times out
* core: docstring, unexport methods
* eth: typo
* internal/ethapi: move createAccessList to eth package
* internal/ethapi: remove reexec from createAccessList
* internal/ethapi: break if al is equal to last run, not if gas is equal
* internal/web3ext: fixed arguments
* core/types: fixed equality check for accesslist
* core/types: no hardcoded vals
* core, internal: simplify access list generation, make it precise
* core/vm: fix typo
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Fixes the CaptureStart api to include the EVM, thus being able to set the statedb early on. This pr also exposes the struct we used internally in the interpreter to encapsulate the contract, mem, stack, rstack, so we pass it as a single struct to the tracer, and removes the error returns on the capture methods.
