This adds type and struct field context to error messages. Instead of "hex string of odd length" users will now see "json: cannot unmarshal hex string of odd length into Go struct field SendTxArgs.from of type common.Address".
		
			
				
	
	
		
			97 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			97 lines
		
	
	
		
			2.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2015 The go-ethereum Authors
 | 
						|
// This file is part of the go-ethereum library.
 | 
						|
//
 | 
						|
// The go-ethereum library is free software: you can redistribute it and/or modify
 | 
						|
// it under the terms of the GNU Lesser General Public License as published by
 | 
						|
// the Free Software Foundation, either version 3 of the License, or
 | 
						|
// (at your option) any later version.
 | 
						|
//
 | 
						|
// The go-ethereum library is distributed in the hope that it will be useful,
 | 
						|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 | 
						|
// GNU Lesser General Public License for more details.
 | 
						|
//
 | 
						|
// You should have received a copy of the GNU Lesser General Public License
 | 
						|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 | 
						|
package common
 | 
						|
 | 
						|
import (
 | 
						|
	"encoding/json"
 | 
						|
	"math/big"
 | 
						|
	"strings"
 | 
						|
	"testing"
 | 
						|
)
 | 
						|
 | 
						|
func TestBytesConversion(t *testing.T) {
 | 
						|
	bytes := []byte{5}
 | 
						|
	hash := BytesToHash(bytes)
 | 
						|
 | 
						|
	var exp Hash
 | 
						|
	exp[31] = 5
 | 
						|
 | 
						|
	if hash != exp {
 | 
						|
		t.Errorf("expected %x got %x", exp, hash)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestHashJsonValidation(t *testing.T) {
 | 
						|
	var tests = []struct {
 | 
						|
		Prefix string
 | 
						|
		Size   int
 | 
						|
		Error  string
 | 
						|
	}{
 | 
						|
		{"", 62, "json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash"},
 | 
						|
		{"0x", 66, "hex string has length 66, want 64 for common.Hash"},
 | 
						|
		{"0x", 63, "json: cannot unmarshal hex string of odd length into Go value of type common.Hash"},
 | 
						|
		{"0x", 0, "hex string has length 0, want 64 for common.Hash"},
 | 
						|
		{"0x", 64, ""},
 | 
						|
		{"0X", 64, ""},
 | 
						|
	}
 | 
						|
	for _, test := range tests {
 | 
						|
		input := `"` + test.Prefix + strings.Repeat("0", test.Size) + `"`
 | 
						|
		var v Hash
 | 
						|
		err := json.Unmarshal([]byte(input), &v)
 | 
						|
		if err == nil {
 | 
						|
			if test.Error != "" {
 | 
						|
				t.Errorf("%s: error mismatch: have nil, want %q", input, test.Error)
 | 
						|
			}
 | 
						|
		} else {
 | 
						|
			if err.Error() != test.Error {
 | 
						|
				t.Errorf("%s: error mismatch: have %q, want %q", input, err, test.Error)
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestAddressUnmarshalJSON(t *testing.T) {
 | 
						|
	var tests = []struct {
 | 
						|
		Input     string
 | 
						|
		ShouldErr bool
 | 
						|
		Output    *big.Int
 | 
						|
	}{
 | 
						|
		{"", true, nil},
 | 
						|
		{`""`, true, nil},
 | 
						|
		{`"0x"`, true, nil},
 | 
						|
		{`"0x00"`, true, nil},
 | 
						|
		{`"0xG000000000000000000000000000000000000000"`, true, nil},
 | 
						|
		{`"0x0000000000000000000000000000000000000000"`, false, big.NewInt(0)},
 | 
						|
		{`"0x0000000000000000000000000000000000000010"`, false, big.NewInt(16)},
 | 
						|
	}
 | 
						|
	for i, test := range tests {
 | 
						|
		var v Address
 | 
						|
		err := json.Unmarshal([]byte(test.Input), &v)
 | 
						|
		if err != nil && !test.ShouldErr {
 | 
						|
			t.Errorf("test #%d: unexpected error: %v", i, err)
 | 
						|
		}
 | 
						|
		if err == nil {
 | 
						|
			if test.ShouldErr {
 | 
						|
				t.Errorf("test #%d: expected error, got none", i)
 | 
						|
			}
 | 
						|
			if v.Big().Cmp(test.Output) != 0 {
 | 
						|
				t.Errorf("test #%d: address mismatch: have %v, want %v", i, v.Big(), test.Output)
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |